Commit a0c45b45 authored by Sylvain Defresne's avatar Sylvain Defresne Committed by Commit Bot

Remove set_sources_assignment_filter from //components/update_client

set_sources_assignment_filter() is considered as a mis-feature
of gn (as it makes it difficult to reason about the BUILD.gn
files individually).

Bug: 1018739
Change-Id: I0f59c9d6812ca93e2d7b5d100d7857467b685f42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414193
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: default avatarSorin Jianu <sorin@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807512}
parent 82d1931a
...@@ -5,6 +5,12 @@ ...@@ -5,6 +5,12 @@
import("//net/features.gni") import("//net/features.gni")
import("//testing/libfuzzer/fuzzer_test.gni") import("//testing/libfuzzer/fuzzer_test.gni")
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
source_set("network_impl") { source_set("network_impl") {
sources = [ sources = [
"net/network_chromium.h", "net/network_chromium.h",
...@@ -58,8 +64,6 @@ static_library("update_client") { ...@@ -58,8 +64,6 @@ static_library("update_client") {
"action_runner.cc", "action_runner.cc",
"action_runner.h", "action_runner.h",
"activity_data_service.h", "activity_data_service.h",
"background_downloader_win.cc",
"background_downloader_win.h",
"command_line_config_policy.cc", "command_line_config_policy.cc",
"command_line_config_policy.h", "command_line_config_policy.h",
"component.cc", "component.cc",
...@@ -120,8 +124,6 @@ static_library("update_client") { ...@@ -120,8 +124,6 @@ static_library("update_client") {
"update_query_params_delegate.h", "update_query_params_delegate.h",
"updater_state.cc", "updater_state.cc",
"updater_state.h", "updater_state.h",
"updater_state_mac.mm",
"updater_state_win.cc",
"url_fetcher_downloader.cc", "url_fetcher_downloader.cc",
"url_fetcher_downloader.h", "url_fetcher_downloader.h",
"utils.cc", "utils.cc",
...@@ -139,6 +141,18 @@ static_library("update_client") { ...@@ -139,6 +141,18 @@ static_library("update_client") {
"//crypto", "//crypto",
"//url", "//url",
] ]
if (is_win) {
sources += [
"background_downloader_win.cc",
"background_downloader_win.h",
"updater_state_win.cc",
]
}
if (is_mac) {
sources += [ "updater_state_mac.mm" ]
}
} }
static_library("test_support") { static_library("test_support") {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment