Commit a0fd0993 authored by tfarina's avatar tfarina Committed by Commit bot

ui: Fix the test names for ui/aura and ui/base.

Brett prefers we go with foo_unittests, it makes Windows users life
easier. And others easier, so they don't need to know/remember the other
possibility: /path/to:unittests

BUG=None
TEST=gn gen out_gn/Debug && ninja -C out_gn/Debug aura_unittests
ui_unittests
R=brettw@chromium.org
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/601753003

Cr-Commit-Position: refs/heads/master@{#297128}
parent d6be16e9
...@@ -273,8 +273,7 @@ executable("bench") { ...@@ -273,8 +273,7 @@ executable("bench") {
} }
} }
test("unittests") { test("aura_unittests") {
output_name = "aura_unittests"
sources = [ sources = [
"gestures/gesture_recognizer_unittest.cc", "gestures/gesture_recognizer_unittest.cc",
"test/run_all_unittests.cc", "test/run_all_unittests.cc",
......
...@@ -701,15 +701,14 @@ if (is_android) { ...@@ -701,15 +701,14 @@ if (is_android) {
# TODO(GYP): Make this work on Android and reenable it. # TODO(GYP): Make this work on Android and reenable it.
if (!is_android) { if (!is_android) {
# TODO(tfarina): Rename this target to ui_base_unittests.
# In order to do this we will need to keep this target, add a dummy
# ui_base_unittests target that just points to ui_unittests, change
# buildbot code to reference the new 'ui_base_unittests' target.
# After buildbot is updated, we can make the changes in Chromium and
# remove 'ui_unittests' target. crbug.com/331829
# GYP version: ui/base/ui_base_tests.gyp:ui_unittests # GYP version: ui/base/ui_base_tests.gyp:ui_unittests
test("unittests") { test("ui_unittests") {
# TODO(tfarina): Rename this target to ui_base_unittests.
# In order to do this we will need to keep this target, add a dummy
# ui_base_unittests target that just points to ui_unittests, change
# buildbot code to reference the new 'ui_base_unittests' target.
# After buildbot is updated, we can make the changes in Chromium and
# remove 'ui_unittests' target. crbug.com/331829
output_name = "ui_unittests"
sources = [ sources = [
"l10n/l10n_util_mac_unittest.mm", "l10n/l10n_util_mac_unittest.mm",
"l10n/l10n_util_unittest.cc", "l10n/l10n_util_unittest.cc",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment