Commit a1225070 authored by nednguyen's avatar nednguyen Committed by Commit bot

[Telemetry] Kill action_runner.NavigateToPage API

BUG=487800

Review URL: https://codereview.chromium.org/1139743005

Cr-Commit-Position: refs/heads/master@{#330450}
parent e19cc6a6
...@@ -18,7 +18,7 @@ class SafebrowsingPage(page_module.Page): ...@@ -18,7 +18,7 @@ class SafebrowsingPage(page_module.Page):
self.archive_data_file = '../data/chrome_proxy_safebrowsing.json' self.archive_data_file = '../data/chrome_proxy_safebrowsing.json'
def RunNavigateSteps(self, action_runner): def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self, timeout_in_seconds=5) action_runner.Navigate(self.url, timeout_in_seconds=5)
class SafebrowsingPageSet(page_set_module.PageSet): class SafebrowsingPageSet(page_set_module.PageSet):
......
...@@ -97,23 +97,6 @@ class ActionRunner(object): ...@@ -97,23 +97,6 @@ class ActionRunner(object):
""" """
return self.CreateInteraction('Gesture_' + label, repeatable) return self.CreateInteraction('Gesture_' + label, repeatable)
def NavigateToPage(self, page, timeout_in_seconds=60):
"""Navigates to the given page.
TODO(ariblue): Remove this sometime in/after Feb 2015. NavigateToPage has
been deprecated since action_runner will support arbitrary user stories
and web contents.
"""
logging.warn('NavigateToPage is deprecated. Please use Navigate instead.')
if page.is_file:
target_side_url = self._tab.browser.http_server.UrlOf(page.file_path_url)
else:
target_side_url = page.url
self._RunAction(NavigateAction(
url=target_side_url,
script_to_evaluate_on_commit=page.script_to_evaluate_on_commit,
timeout_in_seconds=timeout_in_seconds))
def Navigate(self, url, script_to_evaluate_on_commit=None, def Navigate(self, url, script_to_evaluate_on_commit=None,
timeout_in_seconds=60): timeout_in_seconds=60):
"""Navigates to url. """Navigates to url.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment