Remove some dead BrowserPlugin and OOPIF compositing code.

BUG=330264

Review URL: https://codereview.chromium.org/590523003

Cr-Commit-Position: refs/heads/master@{#295804}

content/browser/browser_plugin/browser_plugin_message_filter.cc

@@ -10,7 +10,6 @@
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/common/browser_plugin/browser_plugin_constants.h"
 #include "content/common/browser_plugin/browser_plugin_messages.h"
-#include "content/common/gpu/gpu_messages.h"
 #include "content/common/view_messages.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_plugin_guest_manager.h"
@@ -39,14 +38,7 @@ bool BrowserPluginMessageFilter::OnMessageReceived(
     // thread.
     return true;
   }
-  bool handled = true;
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
-  IPC_BEGIN_MESSAGE_MAP(BrowserPluginMessageFilter, message)
-    IPC_MESSAGE_HANDLER(BrowserPluginHostMsg_BuffersSwappedACK,
-                        OnSwapBuffersACK)
-    IPC_MESSAGE_UNHANDLED(handled = false)
-  IPC_END_MESSAGE_MAP()
-  return handled;
+  return false;
 }
 
 void BrowserPluginMessageFilter::OnDestruct() const {
@@ -87,16 +79,4 @@ void BrowserPluginMessageFilter::ForwardMessageToGuest(
       ->OnMessageReceivedFromEmbedder(message);
 }
 
-void BrowserPluginMessageFilter::OnSwapBuffersACK(
-    const FrameHostMsg_BuffersSwappedACK_Params& params) {
-  GpuProcessHost* gpu_host = GpuProcessHost::FromID(params.gpu_host_id);
-  if (!gpu_host)
-    return;
-  AcceleratedSurfaceMsg_BufferPresented_Params ack_params;
-  ack_params.mailbox = params.mailbox;
-  ack_params.sync_point = params.sync_point;
-  gpu_host->Send(new AcceleratedSurfaceMsg_BufferPresented(params.gpu_route_id,
-                                                           ack_params));
-}
-
 } // namespace content

content/browser/browser_plugin/browser_plugin_message_filter.h

@@ -34,8 +34,6 @@ class BrowserPluginMessageFilter : public BrowserMessageFilter {
 
   void ForwardMessageToGuest(const IPC::Message& message);
 
-  void OnSwapBuffersACK(const FrameHostMsg_BuffersSwappedACK_Params& params);
-
   int render_process_id_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserPluginMessageFilter);

content/browser/frame_host/cross_process_frame_connector.cc

@@ -30,7 +30,6 @@ bool CrossProcessFrameConnector::OnMessageReceived(const IPC::Message& msg) {
   bool handled = true;
 
   IPC_BEGIN_MESSAGE_MAP(CrossProcessFrameConnector, msg)
-    IPC_MESSAGE_HANDLER(FrameHostMsg_BuffersSwappedACK, OnBuffersSwappedACK)
     IPC_MESSAGE_HANDLER(FrameHostMsg_CompositorFrameSwappedACK,
                         OnCompositorFrameSwappedACK)
     IPC_MESSAGE_HANDLER(FrameHostMsg_ReclaimCompositorResources,
@@ -65,20 +64,6 @@ void CrossProcessFrameConnector::RenderProcessGone() {
       frame_proxy_in_parent_renderer_->GetRoutingID()));
 }
 
-void CrossProcessFrameConnector::ChildFrameBuffersSwapped(
-    const GpuHostMsg_AcceleratedSurfaceBuffersSwapped_Params& gpu_params,
-    int gpu_host_id) {
-
-  FrameMsg_BuffersSwapped_Params params;
-  params.size = gpu_params.size;
-  params.mailbox = gpu_params.mailbox;
-  params.gpu_route_id = gpu_params.route_id;
-  params.gpu_host_id = gpu_host_id;
-
-  frame_proxy_in_parent_renderer_->Send(new FrameMsg_BuffersSwapped(
-      frame_proxy_in_parent_renderer_->GetRoutingID(), params));
-}
-
 void CrossProcessFrameConnector::ChildFrameCompositorFrameSwapped(
     uint32 output_surface_id,
     int host_id,
@@ -93,18 +78,6 @@ void CrossProcessFrameConnector::ChildFrameCompositorFrameSwapped(
       frame_proxy_in_parent_renderer_->GetRoutingID(), params));
 }
 
-void CrossProcessFrameConnector::OnBuffersSwappedACK(
-    const FrameHostMsg_BuffersSwappedACK_Params& params) {
-  AcceleratedSurfaceMsg_BufferPresented_Params ack_params;
-  ack_params.mailbox = params.mailbox;
-  ack_params.sync_point = params.sync_point;
-  RenderWidgetHostImpl::AcknowledgeBufferPresent(params.gpu_route_id,
-                                                 params.gpu_host_id,
-                                                 ack_params);
-
-  // TODO(kenrb): Special case stuff for Win + Mac.
-}
-
 void CrossProcessFrameConnector::OnCompositorFrameSwappedACK(
     const FrameHostMsg_CompositorFrameSwappedACK_Params& params) {
   RenderWidgetHostImpl::SendSwapCompositorFrameAck(params.producing_route_id,

content/browser/frame_host/cross_process_frame_connector.h

@@ -16,10 +16,8 @@ namespace IPC {
 class Message;
 }
 
-struct FrameHostMsg_BuffersSwappedACK_Params;
 struct FrameHostMsg_CompositorFrameSwappedACK_Params;
 struct FrameHostMsg_ReclaimCompositorResources_Params;
-struct GpuHostMsg_AcceleratedSurfaceBuffersSwapped_Params;
 
 namespace content {
 class RenderFrameProxyHost;
@@ -78,13 +76,6 @@ class CrossProcessFrameConnector {
 
   void RenderProcessGone();
 
-  // 'Platform' functionality exposed to RenderWidgetHostViewChildFrame.
-  // These methods can forward messages to the child frame proxy in the parent
-  // frame's renderer or attempt to handle them within the browser process.
-  void ChildFrameBuffersSwapped(
-      const GpuHostMsg_AcceleratedSurfaceBuffersSwapped_Params& params,
-      int gpu_host_id);
-
   void ChildFrameCompositorFrameSwapped(uint32 output_surface_id,
                                         int host_id,
                                         int route_id,
@@ -94,8 +85,6 @@ class CrossProcessFrameConnector {
 
  private:
   // Handlers for messages received from the parent frame.
-  void OnBuffersSwappedACK(
-      const FrameHostMsg_BuffersSwappedACK_Params& params);
   void OnCompositorFrameSwappedACK(
       const FrameHostMsg_CompositorFrameSwappedACK_Params& params);
   void OnReclaimCompositorResources(

content/browser/frame_host/render_widget_host_view_child_frame.cc

@@ -207,8 +207,7 @@ void RenderWidgetHostViewChildFrame::AcceleratedSurfaceInitialized(int host_id,
 void RenderWidgetHostViewChildFrame::AcceleratedSurfaceBuffersSwapped(
     const GpuHostMsg_AcceleratedSurfaceBuffersSwapped_Params& params,
     int gpu_host_id) {
-  if (frame_connector_)
-    frame_connector_->ChildFrameBuffersSwapped(params, gpu_host_id);
+  NOTREACHED();
 }
 
 void RenderWidgetHostViewChildFrame::AcceleratedSurfacePostSubBuffer(

content/browser/frame_host/render_widget_host_view_guest.cc

@@ -196,17 +196,7 @@ void RenderWidgetHostViewGuest::SetTooltipText(
 void RenderWidgetHostViewGuest::AcceleratedSurfaceBuffersSwapped(
     const GpuHostMsg_AcceleratedSurfaceBuffersSwapped_Params& params,
     int gpu_host_id) {
-  if (!guest_)
-    return;
-
-  FrameMsg_BuffersSwapped_Params guest_params;
-  guest_params.size = params.size;
-  guest_params.mailbox = params.mailbox;
-  guest_params.gpu_route_id = params.route_id;
-  guest_params.gpu_host_id = gpu_host_id;
-  guest_->SendMessageToEmbedder(
-      new BrowserPluginMsg_BuffersSwapped(guest_->browser_plugin_instance_id(),
-                                          guest_params));
+  NOTREACHED();
 }
 
 void RenderWidgetHostViewGuest::AcceleratedSurfacePostSubBuffer(

content/common/browser_plugin/browser_plugin_messages.h

@@ -209,15 +209,6 @@ IPC_MESSAGE_CONTROL4(BrowserPluginMsg_CopyFromCompositingSurface,
                      gfx::Rect  /* source_rect */,
                      gfx::Size  /* dest_size */)
 
-// Guest renders into an FBO with textures provided by the embedder.
-// BrowserPlugin shares mostly the same logic as out-of-process RenderFrames but
-// because BrowserPlugins implement custom a second level of routing logic,
-// the IPCs need to be annotated with an extra browser_plugin_instance_id. These
-// messages provide that extra id.
-IPC_MESSAGE_CONTROL2(BrowserPluginMsg_BuffersSwapped,
-                     int /* browser_plugin_instance_id */,
-                     FrameMsg_BuffersSwapped_Params /* params */)
-
 IPC_MESSAGE_CONTROL2(BrowserPluginMsg_CompositorFrameSwapped,
                      int /* browser_plugin_instance_id */,
                      FrameMsg_CompositorFrameSwapped_Params /* params */)
@@ -227,12 +218,6 @@ IPC_MESSAGE_CONTROL2(BrowserPluginMsg_SetMouseLock,
                      int /* browser_plugin_instance_id */,
                      bool /* enable */)
 
-// See comment about BrowserPluginMsg_BuffersSwapped and
-// BrowserPluginMsg_CompositorFrameSwapped for how these related
-// to the FrameHostMsg variants.
-IPC_MESSAGE_ROUTED1(BrowserPluginHostMsg_BuffersSwappedACK,
-                    FrameHostMsg_BuffersSwappedACK_Params /* params */)
-
 // Acknowledge that we presented an ubercomp frame.
 IPC_MESSAGE_ROUTED2(BrowserPluginHostMsg_CompositorFrameSwappedACK,
                     int /* browser_plugin_instance_id */,

content/common/frame_messages.h

@@ -335,16 +335,6 @@ IPC_STRUCT_END()
 // -----------------------------------------------------------------------------
 // Messages sent from the browser to the renderer.
 
-// When HW accelerated buffers are swapped in an out-of-process child frame
-// renderer, the message is forwarded to the embedding frame to notify it of
-// a new texture available for compositing. When the buffer has finished
-// presenting, a FrameHostMsg_BuffersSwappedACK should be sent back to
-// gpu host that produced this buffer.
-//
-// This is used in the non-ubercomp HW accelerated compositing path.
-IPC_MESSAGE_ROUTED1(FrameMsg_BuffersSwapped,
-                    FrameMsg_BuffersSwapped_Params /* params */)
-
 // Notifies the embedding frame that a new CompositorFrame is ready to be
 // presented. When the frame finishes presenting, a matching
 // FrameHostMsg_CompositorFrameSwappedACK should be sent back to the
@@ -648,14 +638,6 @@ IPC_SYNC_MESSAGE_CONTROL4_2(FrameHostMsg_OpenChannelToPlugin,
                             IPC::ChannelHandle /* channel_handle */,
                             content::WebPluginInfo /* info */)
 
-// Acknowledge that we presented a HW buffer and provide a sync point
-// to specify the location in the command stream when the compositor
-// is no longer using it.
-//
-// See FrameMsg_BuffersSwapped.
-IPC_MESSAGE_ROUTED1(FrameHostMsg_BuffersSwappedACK,
-                    FrameHostMsg_BuffersSwappedACK_Params /* params */)
-
 // Acknowledge that we presented an ubercomp frame.
 //
 // See FrameMsg_CompositorFrameSwapped

content/common/swapped_out_messages.cc

@@ -40,7 +40,6 @@ bool SwappedOutMessages::CanSendWhileSwappedOut(const IPC::Message* msg) {
     case FrameHostMsg_Detach::ID:
     case FrameHostMsg_DomOperationResponse::ID:
     case FrameHostMsg_CompositorFrameSwappedACK::ID:
-    case FrameHostMsg_BuffersSwappedACK::ID:
     case FrameHostMsg_ReclaimCompositorResources::ID:
     // Input events propagate from parent to child.
     case FrameHostMsg_ForwardInputEvent::ID:

content/renderer/browser_plugin/browser_plugin.cc

@@ -102,7 +102,6 @@ bool BrowserPlugin::OnMessageReceived(const IPC::Message& message) {
   IPC_BEGIN_MESSAGE_MAP(BrowserPlugin, message)
     IPC_MESSAGE_HANDLER(BrowserPluginMsg_Attach_ACK, OnAttachACK)
     IPC_MESSAGE_HANDLER(BrowserPluginMsg_AdvanceFocus, OnAdvanceFocus)
-    IPC_MESSAGE_HANDLER(BrowserPluginMsg_BuffersSwapped, OnBuffersSwapped)
     IPC_MESSAGE_HANDLER_GENERIC(BrowserPluginMsg_CompositorFrameSwapped,
                                 OnCompositorFrameSwapped(message))
     IPC_MESSAGE_HANDLER(BrowserPluginMsg_CopyFromCompositingSurface,
@@ -224,18 +223,6 @@ void BrowserPlugin::OnAttachACK(int browser_plugin_instance_id) {
   attach_pending_ = false;
 }
 
-void BrowserPlugin::OnBuffersSwapped(
-    int instance_id,
-    const FrameMsg_BuffersSwapped_Params& params) {
-  EnableCompositing(true);
-
-  compositing_helper_->OnBuffersSwapped(params.size,
-                                        params.mailbox,
-                                        params.gpu_route_id,
-                                        params.gpu_host_id,
-                                        GetDeviceScaleFactor());
-}
-
 void BrowserPlugin::OnCompositorFrameSwapped(const IPC::Message& message) {
   BrowserPluginMsg_CompositorFrameSwapped::Param param;
   if (!BrowserPluginMsg_CompositorFrameSwapped::Read(&message, &param))
@@ -497,7 +484,6 @@ bool BrowserPlugin::ShouldForwardToBrowserPlugin(
   switch (message.type()) {
     case BrowserPluginMsg_Attach_ACK::ID:
     case BrowserPluginMsg_AdvanceFocus::ID:
-    case BrowserPluginMsg_BuffersSwapped::ID:
     case BrowserPluginMsg_CompositorFrameSwapped::ID:
     case BrowserPluginMsg_CopyFromCompositingSurface::ID:
     case BrowserPluginMsg_GuestGone::ID:

content/renderer/browser_plugin/browser_plugin.h

@@ -189,8 +189,6 @@ class CONTENT_EXPORT BrowserPlugin :
   // Please keep in alphabetical order.
   void OnAdvanceFocus(int instance_id, bool reverse);
   void OnAttachACK(int browser_plugin_instance_id);
-  void OnBuffersSwapped(int instance_id,
-                        const FrameMsg_BuffersSwapped_Params& params);
   void OnCompositorFrameSwapped(const IPC::Message& message);
   void OnCopyFromCompositingSurface(int instance_id,
                                     int request_id,

content/renderer/child_frame_compositing_helper.h

@@ -13,7 +13,6 @@
 #include "base/memory/shared_memory.h"
 #include "cc/layers/delegated_frame_resource_collection.h"
 #include "content/common/content_export.h"
-#include "gpu/command_buffer/common/mailbox.h"
 #include "ui/gfx/size.h"
 
 namespace base {
@@ -25,7 +24,6 @@ class CompositorFrame;
 class CopyOutputResult;
 class Layer;
 class SolidColorLayer;
-class TextureLayer;
 class DelegatedFrameProvider;
 class DelegatedFrameResourceCollection;
 class DelegatedRendererLayer;
@@ -67,11 +65,6 @@ class CONTENT_EXPORT ChildFrameCompositingHelper
   void DidCommitCompositorFrame();
   void EnableCompositing(bool);
   void OnContainerDestroy();
-  void OnBuffersSwapped(const gfx::Size& size,
-                        const gpu::Mailbox& mailbox,
-                        int gpu_route_id,
-                        int gpu_host_id,
-                        float device_scale_factor);
   void OnCompositorFrameSwapped(scoped_ptr<cc::CompositorFrame> frame,
                                 int route_id,
                                 uint32 output_surface_id,
@@ -95,23 +88,6 @@ class CONTENT_EXPORT ChildFrameCompositingHelper
       RenderFrameProxy* render_frame_proxy,
       int host_routing_id);
 
-  enum SwapBuffersType {
-    TEXTURE_IMAGE_TRANSPORT,
-    GL_COMPOSITOR_FRAME,
-    SOFTWARE_COMPOSITOR_FRAME,
-  };
-  struct SwapBuffersInfo {
-    SwapBuffersInfo();
-
-    gpu::Mailbox name;
-    SwapBuffersType type;
-    gfx::Size size;
-    int route_id;
-    uint32 output_surface_id;
-    int host_id;
-    unsigned software_frame_id;
-    base::SharedMemory* shared_memory;
-  };
   virtual ~ChildFrameCompositingHelper();
 
   BrowserPluginManager* GetBrowserPluginManager();
@@ -120,19 +96,11 @@ class CONTENT_EXPORT ChildFrameCompositingHelper
 
   void SendCompositorFrameSwappedACKToBrowser(
       FrameHostMsg_CompositorFrameSwappedACK_Params& params);
-  void SendBuffersSwappedACKToBrowser(
-      FrameHostMsg_BuffersSwappedACK_Params& params);
   void SendReclaimCompositorResourcesToBrowser(
       FrameHostMsg_ReclaimCompositorResources_Params& params);
   void CheckSizeAndAdjustLayerProperties(const gfx::Size& new_size,
                                          float device_scale_factor,
                                          cc::Layer* layer);
-  void OnBuffersSwappedPrivate(const SwapBuffersInfo& mailbox,
-                               unsigned sync_point,
-                               float device_scale_factor);
-  void MailboxReleased(SwapBuffersInfo mailbox,
-                       unsigned sync_point,
-                       bool lost_resource);
   void SendReturnedDelegatedResources();
   void CopyFromCompositingSurfaceHasResult(
       int request_id,
@@ -143,11 +111,8 @@ class CONTENT_EXPORT ChildFrameCompositingHelper
   int last_route_id_;
   uint32 last_output_surface_id_;
   int last_host_id_;
-  bool last_mailbox_valid_;
   bool ack_pending_;
-  bool software_ack_pending_;
   bool opaque_;
-  std::vector<unsigned> unacked_software_frames_;
 
   gfx::Size buffer_size_;
 
@@ -161,7 +126,6 @@ class CONTENT_EXPORT ChildFrameCompositingHelper
   scoped_refptr<cc::DelegatedFrameProvider> frame_provider_;
 
   scoped_refptr<cc::SolidColorLayer> background_layer_;
-  scoped_refptr<cc::TextureLayer> texture_layer_;
   scoped_refptr<cc::DelegatedRendererLayer> delegated_layer_;
   scoped_ptr<blink::WebLayer> web_layer_;
   blink::WebFrame* frame_;

content/renderer/render_frame_proxy.cc

@@ -149,7 +149,6 @@ bool RenderFrameProxy::OnMessageReceived(const IPC::Message& msg) {
   IPC_BEGIN_MESSAGE_MAP(RenderFrameProxy, msg)
     IPC_MESSAGE_HANDLER(FrameMsg_DeleteProxy, OnDeleteProxy)
     IPC_MESSAGE_HANDLER(FrameMsg_ChildFrameProcessGone, OnChildFrameProcessGone)
-    IPC_MESSAGE_HANDLER(FrameMsg_BuffersSwapped, OnBuffersSwapped)
     IPC_MESSAGE_HANDLER_GENERIC(FrameMsg_CompositorFrameSwapped,
                                 OnCompositorFrameSwapped(msg))
     IPC_MESSAGE_HANDLER(FrameMsg_DisownOpener, OnDisownOpener)
@@ -189,21 +188,6 @@ void RenderFrameProxy::OnChildFrameProcessGone() {
     compositing_helper_->ChildFrameGone();
 }
 
-void RenderFrameProxy::OnBuffersSwapped(
-    const FrameMsg_BuffersSwapped_Params& params) {
-  if (!compositing_helper_.get()) {
-    compositing_helper_ =
-        ChildFrameCompositingHelper::CreateForRenderFrameProxy(this);
-    compositing_helper_->EnableCompositing(true);
-  }
-  compositing_helper_->OnBuffersSwapped(
-      params.size,
-      params.mailbox,
-      params.gpu_route_id,
-      params.gpu_host_id,
-      web_frame()->view()->deviceScaleFactor());
-}
-
 void RenderFrameProxy::OnCompositorFrameSwapped(const IPC::Message& message) {
   FrameMsg_CompositorFrameSwapped::Param param;
   if (!FrameMsg_CompositorFrameSwapped::Read(&message, &param))

content/renderer/render_frame_proxy.h

@@ -111,7 +111,6 @@ class CONTENT_EXPORT RenderFrameProxy
   // IPC handlers
   void OnDeleteProxy();
   void OnChildFrameProcessGone();
-  void OnBuffersSwapped(const FrameMsg_BuffersSwapped_Params& params);
   void OnCompositorFrameSwapped(const IPC::Message& message);
   void OnDisownOpener();