Commit a1c665d6 authored by cbentzel's avatar cbentzel Committed by Commit bot

Remove Cookie.TimeGet

BUG=429300

Review URL: https://codereview.chromium.org/726933002

Cr-Commit-Position: refs/heads/master@{#305019}
parent 9c9d7fc8
...@@ -1319,16 +1319,12 @@ std::string CookieMonster::GetCookiesWithOptions(const GURL& url, ...@@ -1319,16 +1319,12 @@ std::string CookieMonster::GetCookiesWithOptions(const GURL& url,
if (!HasCookieableScheme(url)) if (!HasCookieableScheme(url))
return std::string(); return std::string();
TimeTicks start_time(TimeTicks::Now());
std::vector<CanonicalCookie*> cookies; std::vector<CanonicalCookie*> cookies;
FindCookiesForHostAndDomain(url, options, true, &cookies); FindCookiesForHostAndDomain(url, options, true, &cookies);
std::sort(cookies.begin(), cookies.end(), CookieSorter); std::sort(cookies.begin(), cookies.end(), CookieSorter);
std::string cookie_line = BuildCookieLine(cookies); std::string cookie_line = BuildCookieLine(cookies);
histogram_time_get_->AddTime(TimeTicks::Now() - start_time);
VLOG(kVlogGetCookies) << "GetCookies() result: " << cookie_line; VLOG(kVlogGetCookies) << "GetCookies() result: " << cookie_line;
return cookie_line; return cookie_line;
...@@ -2245,9 +2241,6 @@ void CookieMonster::InitializeHistograms() { ...@@ -2245,9 +2241,6 @@ void CookieMonster::InitializeHistograms() {
base::Histogram::kUmaTargetedHistogramFlag); base::Histogram::kUmaTargetedHistogramFlag);
// From UMA_HISTOGRAM_{CUSTOM_,}TIMES // From UMA_HISTOGRAM_{CUSTOM_,}TIMES
histogram_time_get_ = base::Histogram::FactoryTimeGet("Cookie.TimeGet",
base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromMinutes(1),
50, base::Histogram::kUmaTargetedHistogramFlag);
histogram_time_blocked_on_load_ = base::Histogram::FactoryTimeGet( histogram_time_blocked_on_load_ = base::Histogram::FactoryTimeGet(
"Cookie.TimeBlockedOnLoad", "Cookie.TimeBlockedOnLoad",
base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromMinutes(1), base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromMinutes(1),
......
...@@ -635,7 +635,6 @@ class NET_EXPORT CookieMonster : public CookieStore { ...@@ -635,7 +635,6 @@ class NET_EXPORT CookieMonster : public CookieStore {
base::HistogramBase* histogram_domain_per_etldp1_count_; base::HistogramBase* histogram_domain_per_etldp1_count_;
base::HistogramBase* histogram_number_duplicate_db_cookies_; base::HistogramBase* histogram_number_duplicate_db_cookies_;
base::HistogramBase* histogram_cookie_deletion_cause_; base::HistogramBase* histogram_cookie_deletion_cause_;
base::HistogramBase* histogram_time_get_;
base::HistogramBase* histogram_time_mac_; base::HistogramBase* histogram_time_mac_;
base::HistogramBase* histogram_time_blocked_on_load_; base::HistogramBase* histogram_time_blocked_on_load_;
......
...@@ -3407,6 +3407,9 @@ Therefore, the affected-histogram name has to have at least one dot in it. ...@@ -3407,6 +3407,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram> </histogram>
<histogram name="Cookie.TimeGet" units="ms"> <histogram name="Cookie.TimeGet" units="ms">
<obsolete>
Deprecated as of 11/2014.
</obsolete>
<owner>Please list the metric's owners. Add more owner tags as needed.</owner> <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<summary> <summary>
The amount of time (ms) to get cookies for each URL request. The amount of time (ms) to get cookies for each URL request.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment