Commit a25188ba authored by Kenichi Ishibashi's avatar Kenichi Ishibashi Committed by Commit Bot

OOM intervention: Fix histogram names

Fix two typos in OomInterventionTabHelper.

Bug: 776665
Change-Id: I4066d742bbfed519b771f2035155ead865f9d4f2
Reviewed-on: https://chromium-review.googlesource.com/802600Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarMaria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521235}
parent 1e609523
...@@ -29,17 +29,17 @@ void SetLastVisibleWebContents(content::WebContents* web_contents) { ...@@ -29,17 +29,17 @@ void SetLastVisibleWebContents(content::WebContents* web_contents) {
// These enums are associated with UMA. Values must be kept in sync with // These enums are associated with UMA. Values must be kept in sync with
// enums.xml and must not be renumbered/reused. // enums.xml and must not be renumbered/reused.
enum class NearOomMonitoringEndReason { enum class NearOomDetectionEndReason {
OOM_PROTECTED_CRASH = 0, OOM_PROTECTED_CRASH = 0,
RENDERER_GONE = 1, RENDERER_GONE = 1,
NAVIGATION = 2, NAVIGATION = 2,
COUNT, COUNT,
}; };
void RecordNearOomMonitoringEndReason(NearOomMonitoringEndReason reason) { void RecordNearOomDetectionEndReason(NearOomDetectionEndReason reason) {
UMA_HISTOGRAM_ENUMERATION( UMA_HISTOGRAM_ENUMERATION(
"Memory.Experimental.OomIntervention.NearOomMonitoringEndReason", reason, "Memory.Experimental.OomIntervention.NearOomDetectionEndReason", reason,
NearOomMonitoringEndReason::COUNT); NearOomDetectionEndReason::COUNT);
} }
void RecordInterventionUserDecision(bool accepted) { void RecordInterventionUserDecision(bool accepted) {
...@@ -114,7 +114,7 @@ void OomInterventionTabHelper::RenderProcessGone( ...@@ -114,7 +114,7 @@ void OomInterventionTabHelper::RenderProcessGone(
elapsed_time); elapsed_time);
ResetInterventionState(); ResetInterventionState();
} else { } else {
RecordNearOomMonitoringEndReason(NearOomMonitoringEndReason::RENDERER_GONE); RecordNearOomDetectionEndReason(NearOomDetectionEndReason::RENDERER_GONE);
} }
} }
...@@ -149,12 +149,12 @@ void OomInterventionTabHelper::DidStartNavigation( ...@@ -149,12 +149,12 @@ void OomInterventionTabHelper::DidStartNavigation(
base::TimeTicks::Now() - near_oom_detected_time_.value(); base::TimeTicks::Now() - near_oom_detected_time_.value();
UMA_HISTOGRAM_MEDIUM_TIMES( UMA_HISTOGRAM_MEDIUM_TIMES(
"Memory.Experimental.OomIntervention." "Memory.Experimental.OomIntervention."
"NavigatedAfterDetectionTime", "NavigationAfterDetectionTime",
elapsed_time); elapsed_time);
ResetInterventionState(); ResetInterventionState();
} else { } else {
// Monitoring but near-OOM hasn't been detected. // Monitoring but near-OOM hasn't been detected.
RecordNearOomMonitoringEndReason(NearOomMonitoringEndReason::NAVIGATION); RecordNearOomDetectionEndReason(NearOomDetectionEndReason::NAVIGATION);
} }
} }
...@@ -192,8 +192,8 @@ void OomInterventionTabHelper::OnForegroundOOMDetected( ...@@ -192,8 +192,8 @@ void OomInterventionTabHelper::OnForegroundOOMDetected(
} }
ResetInterventionState(); ResetInterventionState();
} else { } else {
RecordNearOomMonitoringEndReason( RecordNearOomDetectionEndReason(
NearOomMonitoringEndReason::OOM_PROTECTED_CRASH); NearOomDetectionEndReason::OOM_PROTECTED_CRASH);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment