Commit a2821bea authored by Ali Juma's avatar Ali Juma Committed by Commit Bot

[iOS] Add an about:flags entry for real-time Safe Browsing

This adds an about:flags entry for real-time Safe Browsing
lookups, to make it easier to enable and test.

Bug: 1103213
Change-Id: I28bae0f333ece6d1f5f8f4dcf5b3c89ef6037772
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315236
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Reviewed-by: default avatarVarun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791295}
parent 86788241
...@@ -3736,6 +3736,11 @@ ...@@ -3736,6 +3736,11 @@
], ],
"expiry_milestone": 88 "expiry_milestone": 88
}, },
{
"name": "safe-browsing-real-time",
"owners": [ "//ios/chrome/browser/safe_browsing/OWNERS" ],
"expiry_milestone": 88
},
{ {
"name": "safe-browsing-security-section-ui-android", "name": "safe-browsing-security-section-ui-android",
"owners": [ "owners": [
......
...@@ -578,6 +578,11 @@ const flags_ui::FeatureEntry kFeatureEntries[] = { ...@@ -578,6 +578,11 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
{"safe-browsing-available", flag_descriptions::kSafeBrowsingAvailableName, {"safe-browsing-available", flag_descriptions::kSafeBrowsingAvailableName,
flag_descriptions::kSafeBrowsingAvailableDescription, flags_ui::kOsIos, flag_descriptions::kSafeBrowsingAvailableDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(safe_browsing::kSafeBrowsingAvailableOnIOS)}, FEATURE_VALUE_TYPE(safe_browsing::kSafeBrowsingAvailableOnIOS)},
{"safe-browsing-real-time",
flag_descriptions::kSafeBrowsingRealTimeLookupName,
flag_descriptions::kSafeBrowsingRealTimeLookupDescription,
flags_ui::kOsIos,
FEATURE_VALUE_TYPE(safe_browsing::kRealTimeUrlLookupEnabled)},
{"qr-code-generation", flag_descriptions::kQRCodeGenerationName, {"qr-code-generation", flag_descriptions::kQRCodeGenerationName,
flag_descriptions::kQRCodeGenerationDescription, flags_ui::kOsIos, flag_descriptions::kQRCodeGenerationDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(kQRCodeGeneration)}, FEATURE_VALUE_TYPE(kQRCodeGeneration)},
......
...@@ -407,6 +407,11 @@ const char kSafeBrowsingAvailableDescription[] = ...@@ -407,6 +407,11 @@ const char kSafeBrowsingAvailableDescription[] =
"When enabled, navigation URLs are compared to Safe Browsing blocklists, " "When enabled, navigation URLs are compared to Safe Browsing blocklists, "
"subject to an opt-out preference."; "subject to an opt-out preference.";
const char kSafeBrowsingRealTimeLookupName[] = "Enable real-time Safe Browsing";
const char kSafeBrowsingRealTimeLookupDescription[] =
"When enabled, navigation URLs are checked using real-time queries to Safe "
"Browsing servers, subject to an opt-in preference.";
const char kSafetyCheckIOSName[] = "Enable safety check on iOS"; const char kSafetyCheckIOSName[] = "Enable safety check on iOS";
const char kSafetyCheckIOSDescription[] = const char kSafetyCheckIOSDescription[] =
"When enabled, the iOS version of safety check is available in Chrome " "When enabled, the iOS version of safety check is available in Chrome "
......
...@@ -353,6 +353,10 @@ extern const char kReloadSadTabDescription[]; ...@@ -353,6 +353,10 @@ extern const char kReloadSadTabDescription[];
extern const char kSafeBrowsingAvailableName[]; extern const char kSafeBrowsingAvailableName[];
extern const char kSafeBrowsingAvailableDescription[]; extern const char kSafeBrowsingAvailableDescription[];
// Title and description for the flag to enable real-time Safe Browsing lookups.
extern const char kSafeBrowsingRealTimeLookupName[];
extern const char kSafeBrowsingRealTimeLookupDescription[];
// Title and description for the flag to enable safety check on iOS. // Title and description for the flag to enable safety check on iOS.
extern const char kSafetyCheckIOSName[]; extern const char kSafetyCheckIOSName[];
extern const char kSafetyCheckIOSDescription[]; extern const char kSafetyCheckIOSDescription[];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment