Misc. cleanup, extensions/ edition.

* Use base:: functions to convert float->int
* Rounding is more accurate for percentages than truncating
* Shorten code

Bug: none
Change-Id: Ie968f402c44dd5f7739e11cb29bb32d866bc4fd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359003
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798697}

extensions/browser/api/web_request/web_request_time_tracker.cc

@@ -5,6 +5,7 @@
 #include "extensions/browser/api/web_request/web_request_time_tracker.h"
 
 #include "base/metrics/histogram_macros.h"
+#include "base/numerics/safe_conversions.h"
 
 ExtensionWebRequestTimeTracker::RequestTimeLog::RequestTimeLog() = default;
 ExtensionWebRequestTimeTracker::RequestTimeLog::~RequestTimeLog() = default;
@@ -65,9 +66,9 @@ void ExtensionWebRequestTimeTracker::AnalyzeLogRequest(
   // extra delay the extension adds is likely to be noise.
   constexpr auto kMinRequestTimeToCare = base::TimeDelta::FromMilliseconds(10);
   if (request_duration >= kMinRequestTimeToCare) {
-    double percentage = log.block_duration / request_duration;
-    UMA_HISTOGRAM_PERCENTAGE("Extensions.NetworkDelayPercentage",
-                             static_cast<int>(100 * percentage));
+    const int percentage =
+        base::ClampRound(log.block_duration / request_duration * 100);
+    UMA_HISTOGRAM_PERCENTAGE("Extensions.NetworkDelayPercentage", percentage);
   }
 }
 

extensions/renderer/extension_throttle_simulation_unittest.cc

@@ -393,14 +393,10 @@ class Requester : public DiscreteTimeSimulation::Actor {
   }
 
   void PerformAction() override {
-    TimeDelta effective_delay = time_between_requests_;
-    TimeDelta current_jitter = TimeDelta::FromMilliseconds(
-        request_jitter_.InMilliseconds() * base::RandDouble());
-    if (base::RandInt(0, 1)) {
-      effective_delay -= current_jitter;
-    } else {
-      effective_delay += current_jitter;
-    }
+    const TimeDelta current_jitter = request_jitter_ * base::RandDouble();
+    const TimeDelta effective_delay =
+        time_between_requests_ +
+        (base::RandInt(0, 1) ? -current_jitter : current_jitter);
 
     if (throttler_entry_->ImplGetTimeNow() - time_of_last_attempt_ >
         effective_delay) {