Commit a396a09f authored by fgorski's avatar fgorski Committed by Commit bot

[Offline pages] Addressing TODOs in RemoveRequestTask

Replacing a TODO with actual store state.

BUG=714256
R=petewil@chromium.org

Review-Url: https://codereview.chromium.org/2841113003
Cr-Commit-Position: refs/heads/master@{#468166}
parent bc96e065
......@@ -35,9 +35,8 @@ void RemoveRequestsTask::RemoveRequests() {
}
void RemoveRequestsTask::CompleteEarly(ItemActionStatus status) {
// TODO(fgorski): store_->state() once implemented
std::unique_ptr<UpdateRequestsResult> result(
new UpdateRequestsResult(StoreState::LOADED));
new UpdateRequestsResult(store_->state()));
for (int64_t request_id : request_ids_)
result->item_statuses.push_back(std::make_pair(request_id, status));
CompleteWithResult(std::move(result));
......
......@@ -38,7 +38,6 @@ class RemoveRequestsTask : public Task {
// Store that this task updates.
RequestQueueStore* store_;
// Request IDs to be updated.
// TODO(fgorski): perhaps convert to unique_ptr to a vector.
std::vector<int64_t> request_ids_;
// Callback to complete the task.
RequestQueueStore::UpdateCallback callback_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment