Commit a3fed9ae authored by arthursonzogni's avatar arthursonzogni Committed by Commit Bot

🤠 Disable failing test NewTabPageControllerTest TabSwitcherControllerTest

They are all failling on Android P bots:

org.chromium.chrome.test.pagecontroller.tests...
- NewTabPageControllerTest#testIsCurrentPageThis
- NewTabPageControllerTest#testOmniboxSearch
- NewTabPageControllerTest#testOpenChromeMenu
- TabSwitcherControllerTest#testClickTabSwitcher
- TabSwitcherControllerTest#testCloseAllTabs
- TabSwitcherControllerTest#testNumberOfOpenTabs
- TabSwitcherControllerTest#testOpenNewTab

Builder: android-pie-x86-rel
https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel
First failing build:
https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/b8864538237552640896

BUG=1130617,1141179
TBR=aluo@chromium.org

Change-Id: Ica537957bf1142de5aa8183261bab49864842b54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519974
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: default avatarArthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824367}
parent 09dd7021
...@@ -50,7 +50,10 @@ public class NewTabPageControllerTest { ...@@ -50,7 +50,10 @@ public class NewTabPageControllerTest {
} }
@Test @Test
public void testIsCurrentPageThis() { @DisableIf.Build(sdk_is_greater_than = VERSION_CODES.O_MR1,
message = "https://crbug.com/1130617 https://crbug.com/1141179")
public void
testIsCurrentPageThis() {
Assert.assertTrue(mController.isCurrentPageThis()); Assert.assertTrue(mController.isCurrentPageThis());
} }
...@@ -74,13 +77,19 @@ public class NewTabPageControllerTest { ...@@ -74,13 +77,19 @@ public class NewTabPageControllerTest {
} }
@Test @Test
public void testOpenChromeMenu() { @DisableIf.Build(sdk_is_greater_than = VERSION_CODES.O_MR1,
message = "https://crbug.com/1130617 https://crbug.com/1141179")
public void
testOpenChromeMenu() {
ChromeMenu menu = mController.openChromeMenu(); ChromeMenu menu = mController.openChromeMenu();
Assert.assertTrue(menu.isCurrentPageThis()); Assert.assertTrue(menu.isCurrentPageThis());
} }
@Test @Test
public void testOmniboxSearch() { @DisableIf.Build(sdk_is_greater_than = VERSION_CODES.O_MR1,
message = "https://crbug.com/1130617 https://crbug.com/1141179")
public void
testOmniboxSearch() {
UrlPage urlPage = mController.omniboxSearch("www.google.com"); UrlPage urlPage = mController.omniboxSearch("www.google.com");
Assert.assertTrue(urlPage.isCurrentPageThis()); Assert.assertTrue(urlPage.isCurrentPageThis());
} }
......
...@@ -4,6 +4,8 @@ ...@@ -4,6 +4,8 @@
package org.chromium.chrome.test.pagecontroller.tests; package org.chromium.chrome.test.pagecontroller.tests;
import android.os.Build.VERSION_CODES;
import androidx.test.filters.SmallTest; import androidx.test.filters.SmallTest;
import org.hamcrest.Matchers; import org.hamcrest.Matchers;
...@@ -18,6 +20,7 @@ import org.junit.runner.RunWith; ...@@ -18,6 +20,7 @@ import org.junit.runner.RunWith;
import org.chromium.base.test.BaseJUnit4ClassRunner; import org.chromium.base.test.BaseJUnit4ClassRunner;
import org.chromium.base.test.util.Criteria; import org.chromium.base.test.util.Criteria;
import org.chromium.base.test.util.CriteriaHelper; import org.chromium.base.test.util.CriteriaHelper;
import org.chromium.base.test.util.DisableIf;
import org.chromium.base.test.util.DisabledTest; import org.chromium.base.test.util.DisabledTest;
import org.chromium.chrome.test.pagecontroller.controllers.ntp.NewTabPageController; import org.chromium.chrome.test.pagecontroller.controllers.ntp.NewTabPageController;
import org.chromium.chrome.test.pagecontroller.controllers.tabswitcher.TabSwitcherController; import org.chromium.chrome.test.pagecontroller.controllers.tabswitcher.TabSwitcherController;
...@@ -46,7 +49,10 @@ public class TabSwitcherControllerTest { ...@@ -46,7 +49,10 @@ public class TabSwitcherControllerTest {
} }
@Test @Test
public void testOpenNewTab() { @DisableIf.Build(sdk_is_greater_than = VERSION_CODES.O_MR1,
message = "https://crbug.com/1130617 https://crbug.com/1141179")
public void
testOpenNewTab() {
mController.clickNewTab(); mController.clickNewTab();
Assert.assertTrue(NewTabPageController.getInstance().isCurrentPageThis()); Assert.assertTrue(NewTabPageController.getInstance().isCurrentPageThis());
} }
...@@ -58,21 +64,30 @@ public class TabSwitcherControllerTest { ...@@ -58,21 +64,30 @@ public class TabSwitcherControllerTest {
} }
@Test @Test
public void testCloseAllTabs() { @DisableIf.Build(sdk_is_greater_than = VERSION_CODES.O_MR1,
message = "https://crbug.com/1130617 https://crbug.com/1141179")
public void
testCloseAllTabs() {
mController.clickNewTab().openTabSwitcher().clickNewTab().openTabSwitcher(); mController.clickNewTab().openTabSwitcher().clickNewTab().openTabSwitcher();
mController.clickCloseAllTabs(); mController.clickCloseAllTabs();
waitForTabCount(0); waitForTabCount(0);
} }
@Test @Test
public void testNumberOfOpenTabs() { @DisableIf.Build(sdk_is_greater_than = VERSION_CODES.O_MR1,
message = "https://crbug.com/1130617 https://crbug.com/1141179")
public void
testNumberOfOpenTabs() {
int startTabs = mController.getNumberOfOpenTabs(); int startTabs = mController.getNumberOfOpenTabs();
mController.clickNewTab().openTabSwitcher(); mController.clickNewTab().openTabSwitcher();
waitForTabCount(startTabs + 1); waitForTabCount(startTabs + 1);
} }
@Test @Test
public void testClickTabSwitcher() { @DisableIf.Build(sdk_is_greater_than = VERSION_CODES.O_MR1,
message = "https://crbug.com/1130617 https://crbug.com/1141179")
public void
testClickTabSwitcher() {
mController.clickTabSwitcher(); mController.clickTabSwitcher();
Assert.assertTrue(NewTabPageController.getInstance().isCurrentPageThis()); Assert.assertTrue(NewTabPageController.getInstance().isCurrentPageThis());
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment