Commit a41f7d16 authored by Shakti Sahu's avatar Shakti Sahu Committed by Commit Bot

ThinWebView : Using TextureView for M81

This CL disables SurfaceView for ThinWebView since currently we have an
issue with surface control in Q which breaks this feature.

https://chromium-review.googlesource.com/c/chromium/src/+/2029240 will fix
this, but it will land in M82. Hence disabling SurfaceView for now so
as to unblock features like ephemeral tab.

Bug: 1024622
Change-Id: Id6825934bd2270e6b45d66c2f3e9aa6db9dadf76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048507Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Reviewed-by: default avatarKhushal <khushalsagar@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741207}
parent 2a69b995
...@@ -7,7 +7,6 @@ package org.chromium.chrome.browser.thinwebview.internal; ...@@ -7,7 +7,6 @@ package org.chromium.chrome.browser.thinwebview.internal;
import android.content.Context; import android.content.Context;
import android.graphics.PixelFormat; import android.graphics.PixelFormat;
import android.graphics.SurfaceTexture; import android.graphics.SurfaceTexture;
import android.os.Build;
import android.view.Surface; import android.view.Surface;
import android.view.SurfaceHolder; import android.view.SurfaceHolder;
import android.view.SurfaceView; import android.view.SurfaceView;
...@@ -162,7 +161,9 @@ public class CompositorViewImpl implements CompositorView { ...@@ -162,7 +161,9 @@ public class CompositorViewImpl implements CompositorView {
private boolean useSurfaceView() { private boolean useSurfaceView() {
if (mViewConstraints.supportsOpacity) return false; if (mViewConstraints.supportsOpacity) return false;
return Build.VERSION.SDK_INT >= Build.VERSION_CODES.N; // TODO(shaktisahu): Use TextureView for M81. Revert back in M82 when surface control is
// fully enabled in Q (crbug/1031636).
return false;
} }
@NativeMethods @NativeMethods
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment