Commit a45754b5 authored by Julie Jeongeun Kim's avatar Julie Jeongeun Kim Committed by Commit Bot

Clean up GetURLLoaderFactory to O2TS

This CL is a part of moving access token management to
OAuth2AccessTokenManager.

It cleans up GetURLLoaderFactory as StartRequest* APIs
were moved to OAuth2AccessTokenManager and they access
to SharedURLLoaderFactory through |delegate_| without
helper API.

Bug: 967598
Change-Id: I22db6c4ea985b3c195ea93e3b6fa518fe25ff8ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672090
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Reviewed-by: default avatarColin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671952}
parent 627fd583
...@@ -156,11 +156,6 @@ OAuth2TokenService::StartRequestForClient( ...@@ -156,11 +156,6 @@ OAuth2TokenService::StartRequestForClient(
client_secret, scopes, consumer); client_secret, scopes, consumer);
} }
scoped_refptr<network::SharedURLLoaderFactory>
OAuth2TokenService::GetURLLoaderFactory() const {
return delegate_->GetURLLoaderFactory();
}
std::unique_ptr<OAuth2TokenService::Request> std::unique_ptr<OAuth2TokenService::Request>
OAuth2TokenService::StartRequestWithContext( OAuth2TokenService::StartRequestWithContext(
const CoreAccountId& account_id, const CoreAccountId& account_id,
......
...@@ -139,7 +139,7 @@ class OAuth2TokenService : public OAuth2TokenServiceObserver { ...@@ -139,7 +139,7 @@ class OAuth2TokenService : public OAuth2TokenServiceObserver {
// This method does the same as |StartRequest| except it uses the // This method does the same as |StartRequest| except it uses the
// URLLoaderfactory given by |url_loader_factory| instead of using the one // URLLoaderfactory given by |url_loader_factory| instead of using the one
// returned by |GetURLLoaderFactory| implemented by derived classes. // returned by Delegate::GetURLLoaderFactory().
// Deprecated. It's moved to OAuth2AccessTokenManager. // Deprecated. It's moved to OAuth2AccessTokenManager.
std::unique_ptr<Request> StartRequestWithContext( std::unique_ptr<Request> StartRequestWithContext(
const CoreAccountId& account_id, const CoreAccountId& account_id,
...@@ -299,10 +299,6 @@ class OAuth2TokenService : public OAuth2TokenServiceObserver { ...@@ -299,10 +299,6 @@ class OAuth2TokenService : public OAuth2TokenServiceObserver {
private: private:
friend class OAuth2TokenServiceDelegate; friend class OAuth2TokenServiceDelegate;
// Provide a URLLoaderFactory used for fetching access tokens with the
// |StartRequest| method.
scoped_refptr<network::SharedURLLoaderFactory> GetURLLoaderFactory() const;
std::unique_ptr<OAuth2TokenServiceDelegate> delegate_; std::unique_ptr<OAuth2TokenServiceDelegate> delegate_;
// The depth of batch changes. // The depth of batch changes.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment