Commit a4d42e36 authored by Egor Pasko's avatar Egor Pasko Committed by Commit Bot

benchmarks/startup.mobile: Improve documentation

More than once folks did not realize that the benchmark requires
building maps_go_webapk. Explain it in the error message.

Also explain more verbosely the very unobvious flags that are required
to make Telemetry happy.

Bug: 961624
Change-Id: Ibc2e895424c902cd7180a2e830eea60f3952f90e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605415
Commit-Queue: Egor Pasko <pasko@chromium.org>
Reviewed-by: default avatarJuan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658542}
parent ff82290b
...@@ -46,10 +46,17 @@ from devil.android.sdk import intent # pylint: disable=import-error ...@@ -46,10 +46,17 @@ from devil.android.sdk import intent # pylint: disable=import-error
# --output-dir=/tmp/avoid-polluting-chrome-tree \ # --output-dir=/tmp/avoid-polluting-chrome-tree \
# --also-run-disabled-tests # --also-run-disabled-tests
# #
# The "--also-run-disabled-tests" is necessary because the benchmark is disabled # Important notes on the flags:
# in expectations.config to avoid failures on Android versions below M. This # --also-run-disabled-tests - is necessary because the benchmark is disabled in
# expectations.config to avoid failures on Android versions below M. This
# override is also used on internal bots. See: http://crbug.com/894744 and # override is also used on internal bots. See: http://crbug.com/894744 and
# http://crbug.com/849907. # http://crbug.com/849907.
# --browser=android-chrome - *must* be used *instead* of "android-chromium". The
# latter may silently produce subtly incorrect results. This is because
# MonohromePublic initialization path is less optimized than Monochrome
# (no orderfile, no library prefetch, etc.)
# -v - in some cases the benchmark does not run in non-verbose mode, details
# unknown.
# #
# Recording a WPR archive and uploading it: # Recording a WPR archive and uploading it:
# shell> CHROMIUM_OUTPUT_DIR=gn_android/Release tools/perf/record_wpr \ # shell> CHROMIUM_OUTPUT_DIR=gn_android/Release tools/perf/record_wpr \
...@@ -83,8 +90,12 @@ class _MobileStartupSharedState(story_module.SharedState): ...@@ -83,8 +90,12 @@ class _MobileStartupSharedState(story_module.SharedState):
'--skip-webapk-verification') '--skip-webapk-verification')
self.platform.Initialize() self.platform.Initialize()
self.platform.SetFullPerformanceModeEnabled(True) self.platform.SetFullPerformanceModeEnabled(True)
self.platform.InstallApplication(core_util.FindLatestApkOnHost( maps_webapk = core_util.FindLatestApkOnHost(
finder_options.chrome_root, 'MapsWebApk.apk')) finder_options.chrome_root, 'MapsWebApk.apk')
if not maps_webapk:
raise Exception('MapsWebApk not found! Follow the Mini-HOWTO in '
'startup_mobile.py')
self.platform.InstallApplication(maps_webapk)
wpr_mode = wpr_modes.WPR_REPLAY wpr_mode = wpr_modes.WPR_REPLAY
self._number_of_iterations = _NUMBER_OF_ITERATIONS self._number_of_iterations = _NUMBER_OF_ITERATIONS
if finder_options.use_live_sites: if finder_options.use_live_sites:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment