[layoutng] Minor code cleanup

Use =default in some places where we can, to avoid hand-writing
move constructors and move assignment operators.

Also adds a move constructor to NG{Unp,P}ositionedFloat and adds a
missed std::move call.

R=eae@chromium.org,ikilpatrick@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I8c3c850d495b455a9a6dddff0b62f3dcf1927c64
Reviewed-on: https://chromium-review.googlesource.com/1226008Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591476}

third_party/blink/renderer/core/layout/ng/exclusions/ng_exclusion_space.cc

@@ -179,12 +179,8 @@ NGExclusionSpaceInternal::NGExclusionSpaceInternal(
   other.derived_geometry_ = nullptr;
 }
 
-NGExclusionSpaceInternal::NGExclusionSpaceInternal(
-    NGExclusionSpaceInternal&& other)
-    : exclusions_(std::move(other.exclusions_)),
-      num_exclusions_(other.num_exclusions_),
-      both_clear_offset_(other.both_clear_offset_),
-      derived_geometry_(std::move(other.derived_geometry_)) {}
+NGExclusionSpaceInternal::NGExclusionSpaceInternal(NGExclusionSpaceInternal&&) =
+    default;
 
 NGExclusionSpaceInternal& NGExclusionSpaceInternal::operator=(
     const NGExclusionSpaceInternal& other) {
@@ -196,6 +192,9 @@ NGExclusionSpaceInternal& NGExclusionSpaceInternal::operator=(
   return *this;
 }
 
+NGExclusionSpaceInternal& NGExclusionSpaceInternal::operator=(
+    NGExclusionSpaceInternal&&) = default;
+
 NGExclusionSpaceInternal::DerivedGeometry::DerivedGeometry()
     : last_float_block_start_(LayoutUnit::Min()),
       left_float_clear_offset_(LayoutUnit::Min()),

third_party/blink/renderer/core/layout/ng/exclusions/ng_exclusion_space.h

@@ -31,7 +31,8 @@ class CORE_EXPORT NGExclusionSpaceInternal {
   NGExclusionSpaceInternal(const NGExclusionSpaceInternal&);
   NGExclusionSpaceInternal(NGExclusionSpaceInternal&&) noexcept;
   NGExclusionSpaceInternal& operator=(const NGExclusionSpaceInternal&);
-  ~NGExclusionSpaceInternal(){};
+  NGExclusionSpaceInternal& operator=(NGExclusionSpaceInternal&&);
+  ~NGExclusionSpaceInternal() {}
 
   void Add(scoped_refptr<const NGExclusion> exclusion);
 
@@ -138,25 +139,8 @@ class CORE_EXPORT NGExclusionSpaceInternal {
               base::AdoptRef(new NGShapeExclusions(*other.shape_exclusions))),
           has_shape_exclusions(other.has_shape_exclusions) {}
 
-    NGShelf(NGShelf&& other) noexcept
-        : block_offset(other.block_offset),
-          line_left(other.line_left),
-          line_right(other.line_right),
-          line_left_edges(std::move(other.line_left_edges)),
-          line_right_edges(std::move(other.line_right_edges)),
-          shape_exclusions(std::move(other.shape_exclusions)),
-          has_shape_exclusions(other.has_shape_exclusions) {}
-
-    NGShelf& operator=(NGShelf&& other) noexcept {
-      block_offset = other.block_offset;
-      line_left = other.line_left;
-      line_right = other.line_right;
-      line_left_edges = std::move(other.line_left_edges);
-      line_right_edges = std::move(other.line_right_edges);
-      shape_exclusions = std::move(other.shape_exclusions);
-      has_shape_exclusions = other.has_shape_exclusions;
-      return *this;
-    }
+    NGShelf(NGShelf&& other) noexcept = default;
+    NGShelf& operator=(NGShelf&& other) noexcept = default;
 
     LayoutUnit block_offset;
     LayoutUnit line_left;
@@ -207,12 +191,7 @@ class CORE_EXPORT NGExclusionSpaceInternal {
   // derived_geometry_ data-structure.
   struct DerivedGeometry {
     DerivedGeometry();
-    DerivedGeometry(DerivedGeometry&& o) noexcept
-        : shelves_(std::move(o.shelves_)),
-          opportunities_(std::move(o.opportunities_)),
-          last_float_block_start_(o.last_float_block_start_),
-          left_float_clear_offset_(o.left_float_clear_offset_),
-          right_float_clear_offset_(o.right_float_clear_offset_) {}
+    DerivedGeometry(DerivedGeometry&& o) noexcept = default;
 
     void Add(const NGExclusion& exclusion);
 
@@ -296,8 +275,7 @@ class CORE_EXPORT NGExclusionSpace {
       : exclusion_space_(other.exclusion_space_ ? new NGExclusionSpaceInternal(
                                                       *other.exclusion_space_)
                                                 : nullptr) {}
-  NGExclusionSpace(NGExclusionSpace&& other) noexcept
-      : exclusion_space_(std::move(other.exclusion_space_)) {}
+  NGExclusionSpace(NGExclusionSpace&& other) noexcept = default;
 
   NGExclusionSpace& operator=(const NGExclusionSpace& other) {
     exclusion_space_ = other.exclusion_space_
@@ -306,11 +284,12 @@ class CORE_EXPORT NGExclusionSpace {
                            : nullptr;
     return *this;
   }
+  NGExclusionSpace& operator=(NGExclusionSpace&& other) = default;
 
   void Add(scoped_refptr<const NGExclusion> exclusion) {
     if (!exclusion_space_)
       exclusion_space_ = std::make_unique<NGExclusionSpaceInternal>();
-    exclusion_space_->Add(exclusion);
+    exclusion_space_->Add(std::move(exclusion));
   }
 
   // Returns a layout opportunity, within the BFC.

third_party/blink/renderer/core/layout/ng/ng_positioned_float.h

@@ -18,6 +18,10 @@ struct CORE_EXPORT NGPositionedFloat {
   NGPositionedFloat(scoped_refptr<NGLayoutResult> layout_result,
                     const NGBfcOffset& bfc_offset);
   ~NGPositionedFloat();
+  NGPositionedFloat(NGPositionedFloat&&) noexcept = default;
+  NGPositionedFloat(const NGPositionedFloat&) = default;
+  NGPositionedFloat& operator=(NGPositionedFloat&&) = default;
+  NGPositionedFloat& operator=(const NGPositionedFloat&) = default;
 
   scoped_refptr<NGLayoutResult> layout_result;
   NGBfcOffset bfc_offset;

third_party/blink/renderer/core/layout/ng/ng_unpositioned_float.h

@@ -22,6 +22,11 @@ struct CORE_EXPORT NGUnpositionedFloat final {
   NGUnpositionedFloat(NGBlockNode node, NGBlockBreakToken* token);
   ~NGUnpositionedFloat();
 
+  NGUnpositionedFloat(NGUnpositionedFloat&&) noexcept = default;
+  NGUnpositionedFloat(const NGUnpositionedFloat&) noexcept = default;
+  NGUnpositionedFloat& operator=(NGUnpositionedFloat&&) = default;
+  NGUnpositionedFloat& operator=(const NGUnpositionedFloat&) = default;
+
   NGBlockNode node;
   scoped_refptr<NGBlockBreakToken> token;