Commit a5508959 authored by rlanday's avatar rlanday Committed by Commit bot

Rename DocumentMarkerController::InvalidateRects*() methods

Renaming InvalidateRectsForAllMarkers() to InvalidateRectsForTextMatchMarkers()
and InvalidateRectsForMarkersInNode() to
InvalidateRectsForTextMatchMarkersInNode() to reflect that we're only creating
RenderedDocumentMarkers (which hold the rects) for TextMatch markers after
https://codereview.chromium.org/2886893008.

BUG=707867

Review-Url: https://codereview.chromium.org/2891173002
Cr-Commit-Position: refs/heads/master@{#473483}
parent 0461d19b
...@@ -2279,7 +2279,7 @@ void Document::LayoutUpdated() { ...@@ -2279,7 +2279,7 @@ void Document::LayoutUpdated() {
if (GetFrame() && GetFrame()->GetPage()) if (GetFrame() && GetFrame()->GetPage())
GetFrame()->GetPage()->GetChromeClient().LayoutUpdated(GetFrame()); GetFrame()->GetPage()->GetChromeClient().LayoutUpdated(GetFrame());
Markers().InvalidateRectsForAllMarkers(); Markers().InvalidateRectsForAllTextMatchMarkers();
// The layout system may perform layouts with pending stylesheets. When // The layout system may perform layouts with pending stylesheets. When
// recording first layout time, we ignore these layouts, since painting is // recording first layout time, we ignore these layouts, since painting is
......
...@@ -454,7 +454,7 @@ void DocumentMarkerController::UpdateMarkerRenderedRectIfNeeded( ...@@ -454,7 +454,7 @@ void DocumentMarkerController::UpdateMarkerRenderedRectIfNeeded(
UpdateMarkerRenderedRect(node, marker); UpdateMarkerRenderedRect(node, marker);
} }
void DocumentMarkerController::InvalidateRectsForMarkersInNode( void DocumentMarkerController::InvalidateRectsForTextMatchMarkersInNode(
const Node& node) { const Node& node) {
MarkerLists* markers = markers_.at(&node); MarkerLists* markers = markers_.at(&node);
...@@ -471,10 +471,10 @@ void DocumentMarkerController::InvalidateRectsForMarkersInNode( ...@@ -471,10 +471,10 @@ void DocumentMarkerController::InvalidateRectsForMarkersInNode(
InvalidatePaintForTickmarks(node); InvalidatePaintForTickmarks(node);
} }
void DocumentMarkerController::InvalidateRectsForAllMarkers() { void DocumentMarkerController::InvalidateRectsForAllTextMatchMarkers() {
for (auto& node_markers : markers_) { for (auto& node_markers : markers_) {
const Node& node = *node_markers.key; const Node& node = *node_markers.key;
InvalidateRectsForMarkersInNode(node); InvalidateRectsForTextMatchMarkersInNode(node);
} }
} }
...@@ -738,7 +738,7 @@ void DocumentMarkerController::DidUpdateCharacterData(CharacterData* node, ...@@ -738,7 +738,7 @@ void DocumentMarkerController::DidUpdateCharacterData(CharacterData* node,
return; return;
if (!node->GetLayoutObject()) if (!node->GetLayoutObject())
return; return;
InvalidateRectsForMarkersInNode(*node); InvalidateRectsForTextMatchMarkersInNode(*node);
// repaint the affected node // repaint the affected node
node->GetLayoutObject()->SetShouldDoFullPaintInvalidation(); node->GetLayoutObject()->SetShouldDoFullPaintInvalidation();
} }
......
...@@ -96,8 +96,8 @@ class CORE_EXPORT DocumentMarkerController final ...@@ -96,8 +96,8 @@ class CORE_EXPORT DocumentMarkerController final
DocumentMarkerVector Markers(); DocumentMarkerVector Markers();
Vector<IntRect> RenderedRectsForTextMatchMarkers(); Vector<IntRect> RenderedRectsForTextMatchMarkers();
void UpdateMarkerRenderedRectIfNeeded(const Node&, RenderedDocumentMarker&); void UpdateMarkerRenderedRectIfNeeded(const Node&, RenderedDocumentMarker&);
void InvalidateRectsForAllMarkers(); void InvalidateRectsForAllTextMatchMarkers();
void InvalidateRectsForMarkersInNode(const Node&); void InvalidateRectsForTextMatchMarkersInNode(const Node&);
DECLARE_TRACE(); DECLARE_TRACE();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment