Commit a564437e authored by Fergal Daly's avatar Fergal Daly Committed by Commit Bot

Add more debugging to try track down https://crbug.com/1006814

The widget host is unexpectedly initialized when we go to initialize
the view. So, check at the earliest stage possible if the widget host
is already initialized. If it's not, then finding out when and how it
flips should be easy.

Bug: 1006814
Change-Id: I0a592c9411323ef8966357da960e347cb2647d51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100588
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: default avatarArthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749962}
parent cf81f522
...@@ -813,8 +813,16 @@ RenderFrameHostImpl* RenderFrameHostManager::GetFrameHostForNavigation( ...@@ -813,8 +813,16 @@ RenderFrameHostImpl* RenderFrameHostManager::GetFrameHostForNavigation(
// If a crashed RenderFrameHost must not be reused, replace it by a // If a crashed RenderFrameHost must not be reused, replace it by a
// new one immediately. // new one immediately.
if (render_frame_host_->must_be_replaced()) if (render_frame_host_->must_be_replaced()) {
use_current_rfh = false; use_current_rfh = false;
// TODO(https://crbug.com/1006814): Remove this.
if (render_frame_host_->render_view_host()
->GetWidget()
->renderer_initialized()) {
base::debug::DumpWithoutCrashing();
NOTREACHED();
}
}
// Force using a different RenderFrameHost when RenderDocument is enabled. // Force using a different RenderFrameHost when RenderDocument is enabled.
// TODO(arthursonzogni, fergal): Add support for the main frame. // TODO(arthursonzogni, fergal): Add support for the main frame.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment