Commit a5f699ad authored by Nico Weber's avatar Nico Weber

Work more on getting things built with -Wimplicit-fallthrough.

This CL was uploaded by git cl split.

R=fmalita@chromium.org

Bug: 177475
Change-Id: I0a26702441737b9c47b5608f0908f66e5d8340fe
Reviewed-on: https://chromium-review.googlesource.com/890062Reviewed-by: default avatarMorten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532225}
parent 1b3e943e
...@@ -701,7 +701,7 @@ void LayoutBlockFlow::UpdateLogicalWidthForAlignment( ...@@ -701,7 +701,7 @@ void LayoutBlockFlow::UpdateLogicalWidthForAlignment(
} }
break; break;
} }
// Fall through FALLTHROUGH;
case ETextAlign::kStart: case ETextAlign::kStart:
if (direction == TextDirection::kLtr) if (direction == TextDirection::kLtr)
UpdateLogicalWidthForLeftAlignedBlock( UpdateLogicalWidthForLeftAlignedBlock(
......
...@@ -400,10 +400,10 @@ int TableLayoutAlgorithmAuto::CalcEffectiveLogicalWidth() { ...@@ -400,10 +400,10 @@ int TableLayoutAlgorithmAuto::CalcEffectiveLogicalWidth() {
// mozilla doesn't do this so I decided we don't neither. // mozilla doesn't do this so I decided we don't neither.
break; break;
} }
// fall through FALLTHROUGH;
case kAuto: case kAuto:
have_auto = true; have_auto = true;
// fall through FALLTHROUGH;
default: default:
// If the column is a percentage width, do not let the spanning cell // If the column is a percentage width, do not let the spanning cell
// overwrite the width value. This caused a mis-layout on amazon.com. // overwrite the width value. This caused a mis-layout on amazon.com.
......
...@@ -98,6 +98,7 @@ static SVGPaintDescription RequestPaint(const LayoutObject& object, ...@@ -98,6 +98,7 @@ static SVGPaintDescription RequestPaint(const LayoutObject& object,
color = apply_to_fill ? svg_style.FillPaintColor() color = apply_to_fill ? svg_style.FillPaintColor()
: svg_style.StrokePaintColor(); : svg_style.StrokePaintColor();
has_color = true; has_color = true;
break;
default: default:
break; break;
} }
......
...@@ -33,6 +33,7 @@ float CalculateTextAnchorShift(const ComputedStyle& style, float length) { ...@@ -33,6 +33,7 @@ float CalculateTextAnchorShift(const ComputedStyle& style, float length) {
switch (style.SvgStyle().TextAnchor()) { switch (style.SvgStyle().TextAnchor()) {
default: default:
NOTREACHED(); NOTREACHED();
FALLTHROUGH;
case TA_START: case TA_START:
return is_ltr ? 0 : -length; return is_ltr ? 0 : -length;
case TA_MIDDLE: case TA_MIDDLE:
...@@ -47,6 +48,7 @@ bool NeedsTextAnchorAdjustment(const ComputedStyle& style) { ...@@ -47,6 +48,7 @@ bool NeedsTextAnchorAdjustment(const ComputedStyle& style) {
switch (style.SvgStyle().TextAnchor()) { switch (style.SvgStyle().TextAnchor()) {
default: default:
NOTREACHED(); NOTREACHED();
FALLTHROUGH;
case TA_START: case TA_START:
return !is_ltr; return !is_ltr;
case TA_MIDDLE: case TA_MIDDLE:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment