Skip to content

GitLab

T
tangled
Commit a5f88b7e authored by James Darpinian's avatar James Darpinian Committed by Commit Bot
Browse files
Options

Cleaning up WebGL test failure expectations. 

Many of these are leftover failure expectations from fixed bugs.
Some were fixed on some platforms but not others. There are some
new failures that were hidden by previous broad suppressions. Also
some tests are only failing because we haven't updated the drivers
on the bots (http://crbug.com/887241).

Bug: 757097, 838133, 672380, 625738, angleproject:2325
Bug: 534697, 849572, 625738, 703779, angleproject:2142
Bug: 757098, 644740, 705865, 602688, angleproject:2103
Bug: 903903, 740769, 662644, 680720, angleproject:1932
Bug: 709874, 887241, 625365, angleproject:2952
Change-Id: I4e39e5a09d31d788d8a8615ad06d1ec88f064f00
Reviewed-on: https://chromium-review.googlesource.com/c/1325197
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607367}
parent 5061842a
Hide whitespace changes
Inline Side-by-side
Showing with 37 additions and 176 deletions
content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
View file @ a5f88b7e
......@@ -51,7 +51,7 @@ class WebGL2ConformanceExpectations(WebGLConformanceExpectations):
# Failing new test
self.Fail(
'conformance2/glsl3/const-struct-from-array-as-function-parameter.html',
bug=874620)
['linux', 'nvidia'], bug=874620)
# Failing new test added in https://github.com/KhronosGroup/WebGL/pull/2665
self.Fail('conformance2/textures/misc/tex-subimage3d-canvas-bug.html',
......@@ -76,36 +76,22 @@ class WebGL2ConformanceExpectations(WebGLConformanceExpectations):
self.Fail('conformance2/transform_feedback/too-small-buffers.html',
['opengl'], bug=832238)
# Failing on Windows and Linux with NVIDIA GPUs and OpenGL driver.
# Failing on NVIDIA OpenGL, but fixed in latest driver
# TODO(http://crbug.com/887241): Upgrade the drivers on the bots.
self.Fail('conformance/glsl/bugs/vector-scalar-arithmetic-inside-loop.html',
['nvidia'], bug=772651)
['linux', 'nvidia'], bug=772651)
self.Fail('conformance/glsl/bugs/' +
'vector-scalar-arithmetic-inside-loop-complex.html',
['nvidia'], bug=772651)
# All platforms.
self.Fail('conformance2/glsl3/tricky-loop-conditions.html', bug=483282)
self.Fail('conformance2/glsl3/array-length-side-effects.html',
bug=2142) # angle bug ID
# Need to implement new error semantics
# https://github.com/KhronosGroup/WebGL/pull/2607
self.Fail('conformance/rendering/draw-elements-out-of-bounds.html',
bug=849572)
# All non-ANGLE platforms.
self.Fail('conformance2/attribs/' +
'gl-bindAttribLocation-aliasing-inactive.html',
['no_angle'], bug=829541)
# OffscreenCanvas.commit
# TODO(fserb): Tests are not up to date with proposed API
self.Fail('conformance2/offscreencanvas/methods-2.html', bug=838133)
self.Fail('conformance2/offscreencanvas/methods-2-worker.html', bug=838133)
self.Fail('conformance/offscreencanvas/' +
'context-attribute-preserve-drawing-buffer.html', bug=838133)
self.Fail('conformance/offscreencanvas/methods.html', bug=838133)
self.Fail('conformance/offscreencanvas/methods-worker.html', bug=838133)
# This test needs to be rewritten to measure its expected
# performance; it's currently too flaky even on release bots.
self.Skip('conformance/rendering/texture-switch-performance.html',
......@@ -120,8 +106,6 @@ class WebGL2ConformanceExpectations(WebGLConformanceExpectations):
self.Fail('conformance2/textures/misc/' +
'integer-cubemap-specification-order-bug.html',
bug=483282) # owner:cwallez, test might be buggy
self.Fail('conformance/textures/misc/tex-sub-image-2d-bad-args.html',
bug=625738)
# Need to implement new lifetime/deletion semantics.
self.Fail('conformance2/vertex_arrays/vertex-array-object.html', bug=739604)
......@@ -144,33 +128,25 @@ class WebGL2ConformanceExpectations(WebGLConformanceExpectations):
'incompatible-texture-type-for-sampler.html',
bug=809237)
# Nvidia bugs fixed in latest driver
# TODO(http://crbug.com/887241): Upgrade the drivers on the bots.
self.Fail('conformance/glsl/bugs/assign-to-swizzled-twice-in-function.html',
['win', 'nvidia', 'vulkan'], bug=798117)
self.Fail('conformance/glsl/bugs/assign-to-swizzled-twice-in-function.html',
['nvidia'], bug=798117)
['linux', 'nvidia'], bug=798117)
self.Fail('conformance/glsl/bugs/' +
'in-parameter-passed-as-inout-argument-and-global.html',
['nvidia'], bug=792210)
# Windows only.
self.Fail('conformance2/buffers/uniform-buffers.html',
['win'], bug=757098)
self.Fail('conformance/glsl/bugs/sampler-struct-function-arg.html',
['win'], bug=2103) # angle bug ID
self.Fail('conformance2/glsl3/array-initialize-with-same-name-array.html',
['win'], bug=757098)
self.Fail('conformance2/rendering/blitframebuffer-outside-readbuffer.html',
['win', 'd3d11'], bug=644740)
self.Fail('conformance2/textures/misc/tex-base-level-bug.html',
['win', 'd3d11'], bug=705865)
self.Flaky('conformance2/textures/svg_image/' +
'tex-2d-rgb565-rgb-unsigned_short_5_6_5.html',
['win'], bug=736926)
self.Fail('conformance2/uniforms/uniform-blocks-with-arrays.html',
['win'], bug=2103) # angle bug ID
self.Fail('conformance2/rendering/' +
'framebuffer-texture-changing-base-level.html',
['win'], bug=2291) # angle bug ID
self.Fail('conformance/glsl/bugs/if-return-and-elseif.html',
['win'], bug=2325) # angle bug ID
# Win / NVidia
self.Flaky('deqp/functional/gles3/fbomultisample*',
......@@ -349,10 +325,6 @@ class WebGL2ConformanceExpectations(WebGLConformanceExpectations):
self.Fail('conformance/misc/webgl-specific-stencil-settings.html',
['passthrough'], bug=844349)
# Passthrough command decoder / D3D11
self.Fail('deqp/functional/gles3/shaderstruct.html',
['win', 'passthrough', 'd3d11'], bug=602688)
# Passthrough command decoder / OpenGL
self.Fail('conformance2/misc/uninitialized-test-2.html',
['passthrough', 'opengl'], bug=602688)
......@@ -789,7 +761,7 @@ class WebGL2ConformanceExpectations(WebGLConformanceExpectations):
self.Fail('conformance/rendering/canvas-alpha-bug.html',
['mac', ('intel', 0x0a2e)], bug=886970)
self.Fail('conformance2/rendering/framebuffer-texture-level1.html',
['mac', 'intel'], bug=680278)
['mac', 'intel'], bug=678526)
self.Fail('conformance2/textures/misc/angle-stuck-depth-textures.html',
['mac', 'no_passthrough', 'intel'], bug=679692)
self.Fail('deqp/functional/gles3/fbomultisample*',
......@@ -811,7 +783,7 @@ class WebGL2ConformanceExpectations(WebGLConformanceExpectations):
self.Fail('deqp/functional/gles3/texturespecification/' +
'random_teximage2d_2d.html',
['mac', 'intel'], bug=483282)
['mac', 'intel'], bug=658657)
self.Fail('deqp/functional/gles3/shadertexturefunction/' +
'texturelod.html',
......@@ -883,7 +855,7 @@ class WebGL2ConformanceExpectations(WebGLConformanceExpectations):
'random_teximage2d_2d.html',
['linux', 'amd', 'intel'], bug=618447)
self.Fail('conformance2/rendering/clipping-wide-points.html',
['linux', 'amd', 'intel'], bug=662644) # WebGL 2.0.1
['linux', 'amd'], bug=662644) # WebGL 2.0.1
# Linux NVIDIA
# This test is flaky both with and without ANGLE.
......@@ -893,13 +865,8 @@ class WebGL2ConformanceExpectations(WebGLConformanceExpectations):
self.Flaky('deqp/functional/gles3/texturespecification/' +
'random_teximage2d_cube.html',
['linux', 'nvidia'], bug=618447)
self.Fail('conformance/glsl/bugs/unary-minus-operator-float-bug.html',
['linux', 'nvidia'], bug=672380)
self.Fail('conformance2/glsl3/vector-dynamic-indexing-swizzled-lvalue.html',
['linux', 'nvidia'], bug=709351)
self.Fail('conformance2/textures/image_bitmap_from_canvas/' +
'tex-3d-srgb8_alpha8-rgba-unsigned_byte.html',
['linux', 'nvidia'], bug=679677)
self.Fail('conformance2/rendering/framebuffer-texture-level1.html',
['linux', 'nvidia', 'opengl'], bug=680278)
self.Fail('conformance2/rendering/multisampling-fragment-evaluation.html',
......@@ -912,9 +879,8 @@ class WebGL2ConformanceExpectations(WebGLConformanceExpectations):
['linux', 'no_passthrough', 'nvidia'], bug=694354)
# Linux NVIDIA Quadro P400
# This test causes a lost device and then the next test fails.
self.Skip('conformance2/rendering/blitframebuffer-size-overflow.html',
['linux', ('nvidia', 0x1cb3)], bug=709320)
self.Fail('conformance2/rendering/blitframebuffer-size-overflow.html',
['linux', ('nvidia', 0x1cb3)], bug=830046)
# Observed flaky on Swarmed bots. Some of these were directly
# observed, some not. We can't afford any flakes on the tryservers
# so mark them all flaky.
......@@ -1008,6 +974,8 @@ class WebGL2ConformanceExpectations(WebGLConformanceExpectations):
['linux', 'intel'], bug=666384)
self.Fail('conformance2/textures/misc/tex-3d-mipmap-levels-intel-bug.html',
['linux', 'intel'], bug=666384)
self.Fail('conformance/extensions/webgl-compressed-texture-astc.html',
['linux', 'intel'], bug=680675)
# Linux Intel with ANGLE only
self.Fail('deqp/functional/gles3/framebufferblit/conversion_07.html',
......@@ -1017,53 +985,6 @@ class WebGL2ConformanceExpectations(WebGLConformanceExpectations):
self.Fail('conformance2/rendering/blitframebuffer-outside-readbuffer.html',
['linux', 'intel', 'opengl'], bug=680276)
# Linux Intel HD 530
self.Fail('conformance/extensions/webgl-compressed-texture-astc.html',
['linux', 'intel'], bug=680720)
self.Fail('conformance2/rendering/blitframebuffer-filter-outofbounds.html',
['linux', 'no_passthrough', 'intel'], bug=680720)
self.Fail('conformance2/rendering/blitframebuffer-filter-srgb.html',
['linux', 'intel', 'no_angle'], bug=680720)
self.Fail('conformance2/rendering/blitframebuffer-outside-readbuffer.html',
['linux', 'intel', 'no_angle'], bug=680720)
self.Fail('deqp/functional/gles3/framebufferblit/conversion_04.html',
['linux', 'intel'], bug=680720)
self.Fail('deqp/functional/gles3/framebufferblit/conversion_08.html',
['linux', 'intel'], bug=680720)
self.Fail('deqp/functional/gles3/framebufferblit/conversion_10.html',
['linux', 'intel'], bug=680720)
self.Fail('deqp/functional/gles3/framebufferblit/conversion_11.html',
['linux', 'intel'], bug=680720)
self.Fail('deqp/functional/gles3/framebufferblit/conversion_12.html',
['linux', 'intel'], bug=680720)
self.Fail('deqp/functional/gles3/framebufferblit/conversion_13.html',
['linux', 'intel'], bug=680720)
self.Fail('deqp/functional/gles3/framebufferblit/conversion_18.html',
['linux', 'intel'], bug=680720)
self.Fail('deqp/functional/gles3/framebufferblit/conversion_25.html',
['linux', 'intel'], bug=680720)
self.Fail('deqp/functional/gles3/framebufferblit/conversion_28.html',
['linux', 'intel'], bug=680720)
self.Fail('deqp/functional/gles3/framebufferblit/conversion_29.html',
['linux', 'intel'], bug=680720)
self.Fail('deqp/functional/gles3/framebufferblit/conversion_30.html',
['linux', 'intel'], bug=680720)
self.Fail('deqp/functional/gles3/framebufferblit/conversion_31.html',
['linux', 'intel'], bug=680720)
self.Fail('deqp/functional/gles3/framebufferblit/conversion_32.html',
['linux', 'intel'], bug=680720)
self.Fail('deqp/functional/gles3/framebufferblit/conversion_33.html',
['linux', 'intel'], bug=680720)
self.Fail('deqp/functional/gles3/framebufferblit/conversion_34.html',
['linux', 'intel'], bug=680720)
self.Fail('deqp/functional/gles3/framebufferblit/' +
'default_framebuffer_00.html',
['linux', 'intel'], bug=680720)
self.Fail('conformance2/glsl3/' +
'vector-dynamic-indexing-swizzled-lvalue.html',
['linux', 'intel'], bug=709874)
# Linux AMD only.
# It looks like AMD shader compiler rejects many valid ES3 semantics.
self.Fail('conformance/glsl/misc/fragcolor-fragdata-invariant.html',
......
content/test/gpu/gpu_tests/webgl_conformance_expectations.py
View file @ a5f88b7e
......@@ -104,30 +104,22 @@ class WebGLConformanceExpectations(GpuTestExpectations):
# https://github.com/KhronosGroup/WebGL/pull/2607
self.Fail('conformance/extensions/' +
'angle-instanced-arrays-out-of-bounds.html', bug=849572)
self.Fail('conformance/rendering/draw-elements-out-of-bounds.html',
bug=849572)
# Failing on Windows and Linux with NVIDIA GPUs and OpenGL driver.
# Nvidia bugs fixed in latest driver
# TODO(http://crbug.com/887241): Upgrade the drivers on the bots.
self.Fail('conformance/glsl/bugs/vector-scalar-arithmetic-inside-loop.html',
['nvidia'], bug=772651)
['linux', 'nvidia'], bug=772651)
self.Fail('conformance/glsl/bugs/' +
'vector-scalar-arithmetic-inside-loop-complex.html',
['nvidia'], bug=772651)
self.Fail('conformance/glsl/bugs/assign-to-swizzled-twice-in-function.html',
['nvidia'], bug=798117)
['win', 'nvidia', 'vulkan'], bug=798117)
self.Fail('conformance/glsl/bugs/assign-to-swizzled-twice-in-function.html',
['linux', 'nvidia'], bug=798117)
self.Fail('conformance/glsl/bugs/' +
'in-parameter-passed-as-inout-argument-and-global.html',
['nvidia'], bug=792210)
# Timing out on multiple platforms right now.
self.Skip('conformance/glsl/bugs/sampler-array-struct-function-arg.html',
bug=757097)
# We need to add WebGL 1 check in command buffer that format/type from
# TexSubImage2D have to match the current texture's.
self.Fail('conformance/textures/misc/tex-sub-image-2d-bad-args.html',
bug=625738)
# This test needs to be rewritten to measure its expected
# performance; it's currently too flaky even on release bots.
self.Skip('conformance/rendering/texture-switch-performance.html',
......@@ -136,21 +128,12 @@ class WebGLConformanceExpectations(GpuTestExpectations):
# Passthrough command decoder / OpenGL
self.Fail('conformance/renderbuffers/framebuffer-test.html',
['passthrough', 'opengl'], bug=665521)
self.Fail('conformance/textures/canvas/*',
['passthrough', 'opengl'], bug=1932) # angle bug ID
self.Fail('conformance/textures/image_bitmap_from_canvas/*',
['passthrough', 'opengl'], bug=1932) # angle bug ID
self.Fail('conformance/textures/webgl_canvas/*',
['passthrough', 'opengl'], bug=1932) # angle bug ID
self.Fail('conformance/extensions/oes-texture-float-with-canvas.html',
['passthrough', 'opengl'], bug=1932) # angle bug ID
# OffscreenCanvas.commit
# TODO(fserb): disabled due to tests not being up to date with proposed API
self.Fail('conformance/offscreencanvas/' +
'context-attribute-preserve-drawing-buffer.html', bug=838133)
self.Fail('conformance/offscreencanvas/methods.html', bug=838133)
self.Fail('conformance/offscreencanvas/methods-worker.html', bug=838133)
self.Fail(
'conformance/textures/canvas/tex-2d-alpha-alpha-unsigned_byte.html',
['passthrough', 'opengl'], bug=2952) # angle bug ID
self.Fail('conformance/textures/canvas/' +
'tex-2d-luminance_alpha-luminance_alpha-unsigned_byte.html',
['passthrough', 'opengl'], bug=2952) # angle bug ID
# Passthrough command decoder / OpenGL / Intel
self.Fail('conformance/glsl/constructors/glsl-construct-mat2.html',
......@@ -201,15 +184,13 @@ class WebGLConformanceExpectations(GpuTestExpectations):
self.Skip('conformance/glsl/bugs/sampler-struct-function-arg.html',
['win'], bug=2103) # angle bug ID
# Note that the following test seems to pass, but it may still be flaky.
self.Fail('conformance/glsl/constructors/' +
self.Flaky('conformance/glsl/constructors/' +
'glsl-construct-vec-mat-index.html',
['win'], bug=525188)
self.Fail('conformance/rendering/point-specific-shader-variables.html',
['win'], bug=616335)
self.Fail('deqp/data/gles2/shaders/functions.html',
['win'], bug=478572)
self.Fail('conformance/glsl/bugs/if-return-and-elseif.html',
['win'], bug=2325) # angle bug ID
# Win NVIDIA failures
self.Flaky('conformance/textures/misc/texture-npot-video.html',
......@@ -608,8 +589,6 @@ class WebGLConformanceExpectations(GpuTestExpectations):
# Mac AMD failures
self.Fail('conformance/glsl/bugs/bool-type-cast-bug-int-float.html',
['mac', 'amd'], bug=483282)
self.Fail('conformance/extensions/webgl-draw-buffers.html',
['mac', 'amd', 'no_passthrough'], bug=625365)
self.Fail('conformance/rendering/clipping-wide-points.html',
['mac', 'amd'], bug=642822)
# TODO(kbr): uncomment the following exepectation after test has
......@@ -651,18 +630,12 @@ class WebGLConformanceExpectations(GpuTestExpectations):
self.Flaky('conformance/textures/image/' +
'tex-2d-rgb-rgb-unsigned_byte.html',
['linux', 'nvidia'], bug=596622)
self.Fail('conformance/glsl/bugs/unary-minus-operator-float-bug.html',
['linux', 'nvidia'], bug=672380)
# NVIDIA P400 OpenGL
self.Fail('conformance/limits/gl-max-texture-dimensions.html',
['linux', ('nvidia', 0x1cb3)], bug=715001)
self.Fail('conformance/textures/misc/texture-size.html',
['linux', ('nvidia', 0x1cb3), 'opengl'], bug=703779)
self.Fail('conformance/extensions/webgl-compressed-texture-size-limit.html',
['linux', ('nvidia', 0x1cb3), 'opengl'], bug=703779)
self.Fail('conformance/textures/misc/texture-size-limit.html',
['linux', ('nvidia', 0x1cb3), 'opengl'], bug=703779)
# AMD
self.Fail('conformance/glsl/misc/fragcolor-fragdata-invariant.html',
......@@ -697,15 +670,17 @@ class WebGLConformanceExpectations(GpuTestExpectations):
# Android failures #
####################
self.Fail('conformance/glsl/bugs/sampler-array-struct-function-arg.html',
['android'], bug=903903)
self.Fail('conformance/glsl/bugs/sequence-operator-evaluation-order.html',
['android'], bug=478572)
['android', 'qualcomm'], bug=478572)
# The following test is very slow and therefore times out on Android bot.
self.Skip('conformance/rendering/multisample-corruption.html',
['android'])
self.Fail('conformance/textures/misc/' +
'copytexsubimage2d-large-partial-copy-corruption.html',
['android', 'no_passthrough'], bug=679697)
['android', 'no_passthrough', 'qualcomm'], bug=679697)
# The following WebView crashes are causing problems with further
# tests in the suite, so skip them for now.
self.Skip('conformance/textures/video/' +
......@@ -730,10 +705,10 @@ class WebGLConformanceExpectations(GpuTestExpectations):
# These video tests appear to be flaky.
self.Flaky('conformance/textures/video/' +
'tex-2d-alpha-alpha-unsigned_byte.html',
['android'], bug=733599)
['android', 'no_passthrough'], bug=733599)
self.Flaky('conformance/textures/video/' +
'tex-2d-luminance_alpha-luminance_alpha-unsigned_byte.html',
['android'], bug=733599)
['android', 'no_passthrough'], bug=733599)
self.Flaky('conformance/textures/video/' +
'tex-2d-luminance-luminance-unsigned_byte.html',
['android'], bug=733599)
......@@ -915,40 +890,6 @@ class WebGLConformanceExpectations(GpuTestExpectations):
'tex-2d-rgb-rgb-unsigned_short_5_6_5.html', ['android', 'nvidia'],
bug=891456)
# Nexus 9 and Shield TV (NVIDIA GPUs currently on the waterfall)
self.Fail('conformance/ogles/GL/array/array_001_to_006.html',
['android', 'nvidia'], bug=740769)
self.Fail('conformance/ogles/GL/functions/functions_009_to_016.html',
['android', 'nvidia'], bug=740769)
self.Fail('conformance/ogles/GL/functions/functions_017_to_024.html',
['android', 'nvidia'], bug=740769)
self.Fail('conformance/ogles/GL/functions/functions_025_to_032.html',
['android', 'nvidia'], bug=740769)
self.Fail('conformance/ogles/GL/functions/functions_033_to_040.html',
['android', 'nvidia'], bug=740769)
self.Fail('conformance/ogles/GL/functions/functions_041_to_048.html',
['android', 'nvidia'], bug=740769)
self.Fail('conformance/ogles/GL/functions/functions_049_to_056.html',
['android', 'nvidia'], bug=740769)
self.Fail('conformance/ogles/GL/functions/functions_057_to_064.html',
['android', 'nvidia'], bug=740769)
self.Fail('conformance/ogles/GL/functions/functions_065_to_072.html',
['android', 'nvidia'], bug=740769)
self.Fail('conformance/ogles/GL/functions/functions_073_to_080.html',
['android', 'nvidia'], bug=740769)
self.Fail('conformance/ogles/GL/functions/functions_081_to_088.html',
['android', 'nvidia'], bug=740769)
self.Fail('conformance/ogles/GL/functions/functions_089_to_096.html',
['android', 'nvidia'], bug=740769)
self.Fail('conformance/ogles/GL/functions/functions_097_to_104.html',
['android', 'nvidia'], bug=740769)
self.Fail('conformance/ogles/GL/functions/functions_105_to_112.html',
['android', 'nvidia'], bug=740769)
self.Fail('conformance/ogles/GL/functions/functions_113_to_120.html',
['android', 'nvidia'], bug=740769)
self.Fail('conformance/ogles/GL/functions/functions_121_to_126.html',
['android', 'nvidia'], bug=740769)
# Flaky timeout on android_n5x_swarming_rel and
# android-marshmallow-arm64-rel.
self.Flaky('conformance/glsl/constructors/glsl-construct-mat3.html',
......
content/test/gpu/gpu_tests/webgl_conformance_expectations_unittest.py
View file @ a5f88b7e
......@@ -56,8 +56,7 @@ class WebGLConformanceExpectationsTest(unittest.TestCase):
'conformance/glsl/constructors/glsl-construct-vec-mat-index.html')
expectation = exps.GetExpectationForTest(
browser, test_info.url, test_info.name)
# TODO(kbr): change this expectation back to "flaky". crbug.com/534697
self.assertEquals(expectation, 'fail')
self.assertEquals(expectation, 'flaky')
def testWebGLExpectationsHaveNoCollisions(self):
exps = webgl_conformance_expectations.WebGLConformanceExpectations()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment