Commit a637d438 authored by spang@chromium.org's avatar spang@chromium.org

Enable unwind support with buildtype=Official branding=Chrome in Debug mode

The previous patch removed unwind support on x64 official builds,
including Debug builds. That may have been a bit too far. Add it back to
Debug builds (but not Release builds).

BUG=180975

Review URL: https://codereview.chromium.org/131193005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244331 0039d316-1c4b-4281-b951-d872f2087c98
parent 0f48fcb9
...@@ -1113,7 +1113,8 @@ ...@@ -1113,7 +1113,8 @@
# Strip the test binaries needed for Linux reliability tests. # Strip the test binaries needed for Linux reliability tests.
'linux_strip_reliability_tests%': 0, 'linux_strip_reliability_tests%': 0,
# If we want stack unwind support for backtrace(). # If we want stack unwind support for backtrace().
'unwind_tables%': 1, 'debug_unwind_tables%': 1,
'release_unwind_tables%': 1,
# Enable TCMalloc. # Enable TCMalloc.
'linux_use_tcmalloc%': 1, 'linux_use_tcmalloc%': 1,
...@@ -1292,9 +1293,9 @@ ...@@ -1292,9 +1293,9 @@
['(branding=="Chrome" and buildtype=="Official")', { ['(branding=="Chrome" and buildtype=="Official")', {
'linux_dump_symbols%': 1, 'linux_dump_symbols%': 1,
# Omit unwind support in official builds to save space. We can use # Omit unwind support in official release builds to save space. We
# breakpad for these builds. # can use breakpad for these builds.
'unwind_tables%': 0, 'release_unwind_tables%': 0,
}], }],
], ],
}], # os_posix==1 and OS!="mac" and OS!="ios" }], # os_posix==1 and OS!="mac" and OS!="ios"
...@@ -3012,6 +3013,11 @@ ...@@ -3012,6 +3013,11 @@
'-Wl,--no-as-needed', '-Wl,--no-as-needed',
], ],
}], }],
['debug_unwind_tables==1', {
'cflags': ['-funwind-tables'],
}, {
'cflags': ['-fno-unwind-tables', '-fno-asynchronous-unwind-tables'],
}],
], ],
}, },
'Release_Base': { 'Release_Base': {
...@@ -3083,6 +3089,11 @@ ...@@ -3083,6 +3089,11 @@
}], }],
], ],
}], }],
['release_unwind_tables==1', {
'cflags': ['-funwind-tables'],
}, {
'cflags': ['-fno-unwind-tables', '-fno-asynchronous-unwind-tables'],
}],
], ],
}, },
}, },
...@@ -3560,11 +3571,6 @@ ...@@ -3560,11 +3571,6 @@
}], }],
], ],
}], }],
['unwind_tables==1', {
'cflags': ['-funwind-tables'],
}, {
'cflags': ['-fno-unwind-tables', '-fno-asynchronous-unwind-tables'],
}],
['linux_use_tcmalloc==0 and android_use_tcmalloc==0', { ['linux_use_tcmalloc==0 and android_use_tcmalloc==0', {
'defines': ['NO_TCMALLOC'], 'defines': ['NO_TCMALLOC'],
}], }],
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment