Commit a660f380 authored by Dave Tapuska's avatar Dave Tapuska Committed by Commit Bot

Remove unused APIs on the WebLocalFrame/Client interfaces

Change-Id: I6a91ea0021077507e968ce2be0adde5588118d74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010169Reviewed-by: default avatarJeremy Roman <jbroman@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733389}
parent 5979bf19
...@@ -176,9 +176,6 @@ class WebLocalFrame : public WebFrame { ...@@ -176,9 +176,6 @@ class WebLocalFrame : public WebFrame {
// Hierarchy ---------------------------------------------------------- // Hierarchy ----------------------------------------------------------
// Returns true if the current frame is a local root.
virtual bool IsLocalRoot() const = 0;
// Returns true if the current frame is a provisional frame. // Returns true if the current frame is a provisional frame.
// TODO(https://crbug.com/578349): provisional frames are a hack that should // TODO(https://crbug.com/578349): provisional frames are a hack that should
// be removed. // be removed.
...@@ -281,9 +278,6 @@ class WebLocalFrame : public WebFrame { ...@@ -281,9 +278,6 @@ class WebLocalFrame : public WebFrame {
// CSS3 Paged Media ---------------------------------------------------- // CSS3 Paged Media ----------------------------------------------------
// Returns true if page box (margin boxes and page borders) is visible.
virtual bool IsPageBoxVisible(int page_index) = 0;
// Returns true if the page style has custom size information. // Returns true if the page style has custom size information.
virtual bool HasCustomPageSizeStyle(int page_index) = 0; virtual bool HasCustomPageSizeStyle(int page_index) = 0;
...@@ -298,11 +292,6 @@ class WebLocalFrame : public WebFrame { ...@@ -298,11 +292,6 @@ class WebLocalFrame : public WebFrame {
int& margin_bottom, int& margin_bottom,
int& margin_left) = 0; int& margin_left) = 0;
// Returns the value for a page property that is only defined when printing.
// printBegin must have been called before this method.
virtual WebString PageProperty(const WebString& property_name,
int page_index) = 0;
// Scripting -------------------------------------------------------------- // Scripting --------------------------------------------------------------
// Executes script in the context of the current page. // Executes script in the context of the current page.
...@@ -414,10 +403,6 @@ class WebLocalFrame : public WebFrame { ...@@ -414,10 +403,6 @@ class WebLocalFrame : public WebFrame {
mojo::ScopedInterfaceEndpointHandle devtools_agent_request) = 0; mojo::ScopedInterfaceEndpointHandle devtools_agent_request) = 0;
// Editing ------------------------------------------------------------- // Editing -------------------------------------------------------------
virtual void SetMarkedText(const WebString& text,
unsigned location,
unsigned length) = 0;
virtual void UnmarkText() = 0; virtual void UnmarkText() = 0;
virtual bool HasMarkedText() const = 0; virtual bool HasMarkedText() const = 0;
...@@ -542,11 +527,6 @@ class WebLocalFrame : public WebFrame { ...@@ -542,11 +527,6 @@ class WebLocalFrame : public WebFrame {
// If the provided node is an image that failed to load, reload it. // If the provided node is an image that failed to load, reload it.
virtual void ReloadImage(const WebNode&) = 0; virtual void ReloadImage(const WebNode&) = 0;
// Feature usage logging --------------------------------------------------
virtual void DidCallAddSearchProvider() = 0;
virtual void DidCallIsSearchProviderInstalled() = 0;
// Iframe sandbox --------------------------------------------------------- // Iframe sandbox ---------------------------------------------------------
// TODO(ekaramad): This method is only exposed for testing for certain tests // TODO(ekaramad): This method is only exposed for testing for certain tests
......
...@@ -108,7 +108,6 @@ class WebMediaStreamDeviceObserver; ...@@ -108,7 +108,6 @@ class WebMediaStreamDeviceObserver;
class WebNavigationControl; class WebNavigationControl;
class WebPlugin; class WebPlugin;
class WebPrescientNetworking; class WebPrescientNetworking;
class WebRTCPeerConnectionHandler;
class WebRelatedAppsFetcher; class WebRelatedAppsFetcher;
class WebServiceWorkerProvider; class WebServiceWorkerProvider;
class WebSocketHandshakeThrottle; class WebSocketHandshakeThrottle;
...@@ -650,10 +649,6 @@ class BLINK_EXPORT WebLocalFrameClient { ...@@ -650,10 +649,6 @@ class BLINK_EXPORT WebLocalFrameClient {
// MediaStream ----------------------------------------------------- // MediaStream -----------------------------------------------------
// A new WebRTCPeerConnectionHandler is created.
virtual void WillStartUsingPeerConnectionHandler(
WebRTCPeerConnectionHandler*) {}
virtual WebMediaStreamDeviceObserver* MediaStreamDeviceObserver() { virtual WebMediaStreamDeviceObserver* MediaStreamDeviceObserver() {
return nullptr; return nullptr;
} }
......
...@@ -1050,14 +1050,6 @@ void WebLocalFrameImpl::ReplaceSelection(const WebString& text) { ...@@ -1050,14 +1050,6 @@ void WebLocalFrameImpl::ReplaceSelection(const WebString& text) {
GetFrame()->GetEditor().ReplaceSelection(text); GetFrame()->GetEditor().ReplaceSelection(text);
} }
void WebLocalFrameImpl::SetMarkedText(const WebString& text,
unsigned location,
unsigned length) {
Vector<ImeTextSpan> decorations;
GetFrame()->GetInputMethodController().SetComposition(text, decorations,
location, length);
}
void WebLocalFrameImpl::UnmarkText() { void WebLocalFrameImpl::UnmarkText() {
GetFrame()->GetInputMethodController().CancelComposition(); GetFrame()->GetInputMethodController().CancelComposition();
} }
...@@ -1640,10 +1632,6 @@ bool WebLocalFrameImpl::HasCustomPageSizeStyle(int page_index) { ...@@ -1640,10 +1632,6 @@ bool WebLocalFrameImpl::HasCustomPageSizeStyle(int page_index) {
EPageSizeType::kAuto; EPageSizeType::kAuto;
} }
bool WebLocalFrameImpl::IsPageBoxVisible(int page_index) {
return GetFrame()->GetDocument()->IsPageBoxVisible(page_index);
}
void WebLocalFrameImpl::PageSizeAndMarginsInPixels(int page_index, void WebLocalFrameImpl::PageSizeAndMarginsInPixels(int page_index,
WebDoubleSize& page_size, WebDoubleSize& page_size,
int& margin_top, int& margin_top,
...@@ -1656,13 +1644,6 @@ void WebLocalFrameImpl::PageSizeAndMarginsInPixels(int page_index, ...@@ -1656,13 +1644,6 @@ void WebLocalFrameImpl::PageSizeAndMarginsInPixels(int page_index,
page_size = size; page_size = size;
} }
WebString WebLocalFrameImpl::PageProperty(const WebString& property_name,
int page_index) {
DCHECK(print_context_);
return print_context_->PageProperty(GetFrame(), property_name.Utf8().c_str(),
page_index);
}
void WebLocalFrameImpl::PrintPagesForTesting( void WebLocalFrameImpl::PrintPagesForTesting(
cc::PaintCanvas* canvas, cc::PaintCanvas* canvas,
const WebSize& page_size_in_pixels) { const WebSize& page_size_in_pixels) {
...@@ -2059,10 +2040,6 @@ WebContentCaptureClient* WebLocalFrameImpl::ContentCaptureClient() const { ...@@ -2059,10 +2040,6 @@ WebContentCaptureClient* WebLocalFrameImpl::ContentCaptureClient() const {
return content_capture_client_; return content_capture_client_;
} }
bool WebLocalFrameImpl::IsLocalRoot() const {
return frame_->IsLocalRoot();
}
bool WebLocalFrameImpl::IsProvisional() const { bool WebLocalFrameImpl::IsProvisional() const {
return frame_->IsProvisional(); return frame_->IsProvisional();
} }
...@@ -2305,16 +2282,6 @@ void WebLocalFrameImpl::SendOrientationChangeEvent() { ...@@ -2305,16 +2282,6 @@ void WebLocalFrameImpl::SendOrientationChangeEvent() {
GetFrame()->DomWindow()->SendOrientationChangeEvent(); GetFrame()->DomWindow()->SendOrientationChangeEvent();
} }
void WebLocalFrameImpl::DidCallAddSearchProvider() {
UseCounter::Count(GetFrame()->GetDocument(),
WebFeature::kExternalAddSearchProvider);
}
void WebLocalFrameImpl::DidCallIsSearchProviderInstalled() {
UseCounter::Count(GetFrame()->GetDocument(),
WebFeature::kExternalIsSearchProviderInstalled);
}
void WebLocalFrameImpl::DispatchMessageEventWithOriginCheck( void WebLocalFrameImpl::DispatchMessageEventWithOriginCheck(
const WebSecurityOrigin& intended_target_origin, const WebSecurityOrigin& intended_target_origin,
const WebDOMMessageEvent& event) { const WebDOMMessageEvent& event) {
...@@ -2356,7 +2323,7 @@ WebNode WebLocalFrameImpl::ContextMenuNode() const { ...@@ -2356,7 +2323,7 @@ WebNode WebLocalFrameImpl::ContextMenuNode() const {
void WebLocalFrameImpl::WillBeDetached() { void WebLocalFrameImpl::WillBeDetached() {
// The |frame_widget_| can be null for frames in non-composited WebViews. // The |frame_widget_| can be null for frames in non-composited WebViews.
if (IsLocalRoot() && frame_widget_) if (frame_->IsLocalRoot() && frame_widget_)
frame_widget_->DidDetachLocalFrameTree(); frame_widget_->DidDetachLocalFrameTree();
if (dev_tools_agent_) if (dev_tools_agent_)
dev_tools_agent_->WillBeDestroyed(); dev_tools_agent_->WillBeDestroyed();
......
...@@ -117,7 +117,6 @@ class CORE_EXPORT WebLocalFrameImpl final ...@@ -117,7 +117,6 @@ class CORE_EXPORT WebLocalFrameImpl final
WebDocument GetDocument() const override; WebDocument GetDocument() const override;
WebString AssignedName() const override; WebString AssignedName() const override;
void SetName(const WebString&) override; void SetName(const WebString&) override;
bool IsLocalRoot() const override;
bool IsProvisional() const override; bool IsProvisional() const override;
WebLocalFrameImpl* LocalRoot() override; WebLocalFrameImpl* LocalRoot() override;
WebFrameWidget* FrameWidget() const override; WebFrameWidget* FrameWidget() const override;
...@@ -146,7 +145,6 @@ class CORE_EXPORT WebLocalFrameImpl final ...@@ -146,7 +145,6 @@ class CORE_EXPORT WebLocalFrameImpl final
bool had_redirect, bool had_redirect,
const WebSourceLocation&) override; const WebSourceLocation&) override;
void SendOrientationChangeEvent() override; void SendOrientationChangeEvent() override;
bool IsPageBoxVisible(int page_index) override;
bool HasCustomPageSizeStyle(int page_index) override; bool HasCustomPageSizeStyle(int page_index) override;
void PageSizeAndMarginsInPixels(int page_index, void PageSizeAndMarginsInPixels(int page_index,
WebDoubleSize& page_size, WebDoubleSize& page_size,
...@@ -154,8 +152,6 @@ class CORE_EXPORT WebLocalFrameImpl final ...@@ -154,8 +152,6 @@ class CORE_EXPORT WebLocalFrameImpl final
int& margin_right, int& margin_right,
int& margin_bottom, int& margin_bottom,
int& margin_left) override; int& margin_left) override;
WebString PageProperty(const WebString& property_name,
int page_index) override;
void ExecuteScript(const WebScriptSource&) override; void ExecuteScript(const WebScriptSource&) override;
void ExecuteScriptInIsolatedWorld(int32_t world_id, void ExecuteScriptInIsolatedWorld(int32_t world_id,
const WebScriptSource&) override; const WebScriptSource&) override;
...@@ -196,9 +192,6 @@ class CORE_EXPORT WebLocalFrameImpl final ...@@ -196,9 +192,6 @@ class CORE_EXPORT WebLocalFrameImpl final
void BindDevToolsAgent( void BindDevToolsAgent(
mojo::ScopedInterfaceEndpointHandle devtools_agent_host_ptr_info, mojo::ScopedInterfaceEndpointHandle devtools_agent_host_ptr_info,
mojo::ScopedInterfaceEndpointHandle devtools_agent_request) override; mojo::ScopedInterfaceEndpointHandle devtools_agent_request) override;
void SetMarkedText(const WebString&,
unsigned location,
unsigned length) override;
void UnmarkText() override; void UnmarkText() override;
bool HasMarkedText() const override; bool HasMarkedText() const override;
WebRange MarkedRange() const override; WebRange MarkedRange() const override;
...@@ -254,8 +247,6 @@ class CORE_EXPORT WebLocalFrameImpl final ...@@ -254,8 +247,6 @@ class CORE_EXPORT WebLocalFrameImpl final
const WebVector<WebString>& words) override; const WebVector<WebString>& words) override;
void SetContentSettingsClient(WebContentSettingsClient*) override; void SetContentSettingsClient(WebContentSettingsClient*) override;
void ReloadImage(const WebNode&) override; void ReloadImage(const WebNode&) override;
void DidCallAddSearchProvider() override;
void DidCallIsSearchProviderInstalled() override;
WebSandboxFlags EffectiveSandboxFlagsForTesting() const override; WebSandboxFlags EffectiveSandboxFlagsForTesting() const override;
bool IsAllowedToDownload() const override; bool IsAllowedToDownload() const override;
bool FindForTesting(int identifier, bool FindForTesting(int identifier,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment