Skip to content

GitLab

T
tangled
Commit a75c4020 authored by Jack Franklin's avatar Jack Franklin Committed by Commit Bot
Browse files
Options

Remove breadcrumbs layout tests 

https://crrev.com/c/2297395 ships a new breadcrumbs component that
includes its own unit tests and DevTools frontend also has an e2e test
for the breadcrumbs. Therefore we don't need to also maintain these
layout tests in Chromium.

Change-Id: Ifefb09a545442d3681a9b4921d4d708c636943d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300081
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: default avatarTim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788568}
parent 1ab49a3f
Show whitespace changes
Inline Side-by-side
Showing with 0 additions and 138 deletions
third_party/blink/web_tests/TestExpectations
View file @ a75c4020
......@@ -6330,7 +6330,6 @@ crbug.com/1046784 http/tests/devtools/elements/styles-4/styles-inline-element-st
crbug.com/1046784 http/tests/devtools/elements/styles-3/styles-add-invalid-property.js [ Pass Timeout ]
crbug.com/1046784 http/tests/devtools/elements/resolve-node-blocked.js [ Pass Timeout ]
crbug.com/1046784 http/tests/devtools/editor/text-editor-selection-to-search.js [ Pass Timeout ]
crbug.com/1046784 http/tests/devtools/elements/shadow/breadcrumb-shadow-roots.js [ Pass Timeout ]
crbug.com/1046784 http/tests/devtools/animation/animation-KeyframeEffect-crash.js [ Pass Timeout ]
crbug.com/1046784 http/tests/devtools/animation/animation-group-matching-transitions.js [ Pass Timeout ]
crbug.com/1046784 http/tests/devtools/storage-panel-dom-storage.js [ Pass Timeout ]
......
third_party/blink/web_tests/http/tests/devtools/elements/breadcrumb-updates-expected.txt deleted 100644 → 0
View file @ 1ab49a3f
Tests that breadcrumbs are updated upon involved element's attribute changes in the Elements panel.
Original breadcrumb:
html > body > div.firstClass > div#target
After class change:
html > body > div.anotherClass > div#target
After class removal:
html > body > div > div#target
third_party/blink/web_tests/http/tests/devtools/elements/breadcrumb-updates.js deleted 100644 → 0
View file @ 1ab49a3f
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
(async function() {
TestRunner.addResult(
`Tests that breadcrumbs are updated upon involved element's attribute changes in the Elements panel.\n`);
await TestRunner.loadModule('elements_test_runner');
await TestRunner.showPanel('elements');
await TestRunner.loadHTML(`
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<div class="firstClass">
<div id="target"></div>
</div>
`);
await TestRunner.evaluateInPagePromise(`
function changeClass()
{
document.getElementsByClassName("firstClass")[0].className = "anotherClass";
}
function deleteClass()
{
document.getElementsByClassName("anotherClass")[0].className = "";
}
`);
ElementsTestRunner.expandElementsTree(step0);
function step0() {
TestRunner.addSniffer(Elements.ElementsBreadcrumbs.prototype, 'update', step1);
ElementsTestRunner.selectNodeWithId('target');
}
function step1() {
ElementsTestRunner.dumpBreadcrumb('Original breadcrumb');
TestRunner.addSniffer(Elements.ElementsBreadcrumbs.prototype, 'update', step2);
TestRunner.evaluateInPage('changeClass()');
}
function step2() {
ElementsTestRunner.dumpBreadcrumb('After class change');
TestRunner.addSniffer(Elements.ElementsBreadcrumbs.prototype, 'update', step3);
TestRunner.evaluateInPage('deleteClass()');
}
function step3() {
ElementsTestRunner.dumpBreadcrumb('After class removal');
TestRunner.completeTest();
}
})();
third_party/blink/web_tests/http/tests/devtools/elements/shadow/breadcrumb-shadow-roots-expected.txt deleted 100644 → 0
View file @ 1ab49a3f
Tests that shadow roots are displayed correctly in breadcrumbs.
User-agent shadow root breadcrumb:
html > body > input > #shadow-root
Open shadow root breadcrumb:
html > body > div#host > #shadow-root
Closed shadow root breadcrumb:
html > body > div#hostClosed > #shadow-root
third_party/blink/web_tests/http/tests/devtools/elements/shadow/breadcrumb-shadow-roots.js deleted 100644 → 0
View file @ 1ab49a3f
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
(async function() {
TestRunner.addResult(`Tests that shadow roots are displayed correctly in breadcrumbs.\n`);
await TestRunner.loadModule('elements_test_runner');
await TestRunner.showPanel('elements');
await TestRunner.loadHTML(`
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<input type="text">
<div id="host"></div>
<div id="hostClosed"></div>
<template id="tmpl">
<style>.red { color: red; }</style>
<div id="inner" class="red">inner</div>
</template>
`);
await TestRunner.evaluateInPagePromise(`
var template = document.querySelector("#tmpl");
var root = document.querySelector("#host").attachShadow({mode: 'open'});
root.appendChild(template.content.cloneNode(true));
var rootClosed = document.querySelector("#hostClosed").attachShadow({mode: 'closed'});
rootClosed.appendChild(template.content.cloneNode(true));
`);
Common.settingForTest('showUAShadowDOM').set(true);
ElementsTestRunner.expandElementsTree(step0);
function step0() {
selectNode(matchUserAgentShadowRoot, step1);
}
function step1() {
ElementsTestRunner.dumpBreadcrumb('User-agent shadow root breadcrumb');
selectNode(matchOpenShadowRoot, step2);
}
function step2() {
ElementsTestRunner.dumpBreadcrumb('Open shadow root breadcrumb');
selectNode(matchClosedShadowRoot, step3);
}
function step3() {
ElementsTestRunner.dumpBreadcrumb('Closed shadow root breadcrumb');
TestRunner.completeTest();
}
function selectNode(matchFunction, next) {
ElementsTestRunner.findNode(matchFunction, callback);
function callback(node) {
TestRunner.addSniffer(Elements.ElementsBreadcrumbs.prototype, 'update', next);
Common.Revealer.reveal(node);
}
}
function matchUserAgentShadowRoot(node) {
return node.shadowRootType() === SDK.DOMNode.ShadowRootTypes.UserAgent;
}
function matchOpenShadowRoot(node) {
return node.shadowRootType() === SDK.DOMNode.ShadowRootTypes.Open;
}
function matchClosedShadowRoot(node) {
return node.shadowRootType() === SDK.DOMNode.ShadowRootTypes.Closed;
}
})();
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment