Commit a79c5acd authored by Devlin Cronin's avatar Devlin Cronin Committed by Commit Bot

[Extensions] Remove unused method

ActionInfo::IsVerboseInstallMessage() was never used. Remove it.

Bug: None
Change-Id: Ic7aa36bdb3332fc0f6eba466eff576854c6c66e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080951Reviewed-by: default avatarIstiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746966}
parent c43e4b3f
...@@ -7,7 +7,6 @@ ...@@ -7,7 +7,6 @@
#include <memory> #include <memory>
#include "base/strings/utf_string_conversions.h" #include "base/strings/utf_string_conversions.h"
#include "chrome/common/extensions/api/commands/commands_handler.h"
#include "extensions/common/constants.h" #include "extensions/common/constants.h"
#include "extensions/common/error_utils.h" #include "extensions/common/error_utils.h"
#include "extensions/common/extension.h" #include "extensions/common/extension.h"
...@@ -201,12 +200,4 @@ void ActionInfo::SetPageActionInfo(Extension* extension, ...@@ -201,12 +200,4 @@ void ActionInfo::SetPageActionInfo(Extension* extension,
std::make_unique<ActionInfoData>(std::move(info))); std::make_unique<ActionInfoData>(std::move(info)));
} }
// static
bool ActionInfo::IsVerboseInstallMessage(const Extension* extension) {
const ActionInfo* page_action_info = GetPageActionInfo(extension);
return page_action_info &&
(CommandsInfo::GetPageActionCommand(extension) ||
!page_action_info->default_icon.empty());
}
} // namespace extensions } // namespace extensions
...@@ -71,10 +71,6 @@ struct ActionInfo { ...@@ -71,10 +71,6 @@ struct ActionInfo {
static void SetPageActionInfo(Extension* extension, static void SetPageActionInfo(Extension* extension,
std::unique_ptr<ActionInfo> info); std::unique_ptr<ActionInfo> info);
// Returns true if the extension needs a verbose install message because
// of its page action.
static bool IsVerboseInstallMessage(const Extension* extension);
// The key this action corresponds to. NOTE: You should only use this if you // The key this action corresponds to. NOTE: You should only use this if you
// care about the actual manifest key. Use the other members (like // care about the actual manifest key. Use the other members (like
// |default_state| for querying general info. // |default_state| for querying general info.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment