DevTools: Partially redesigned DevToolsAndroidBridge and AndroidDeviceManager.

Review URL: https://codereview.chromium.org/287643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274211 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

@@ -34,6 +34,7 @@ class AdbClientSocketTest : public InProcessBrowserTest,
     device_providers.push_back(new AdbDeviceProvider());
     android_bridge_->set_device_providers_for_test(device_providers);
     android_bridge_->AddDeviceListListener(this);
+    content::RunMessageLoop();
   }
 
   virtual void DeviceListChanged(
@@ -125,7 +126,6 @@ class AdbClientSocketTest : public InProcessBrowserTest,
 IN_PROC_BROWSER_TEST_F(AdbClientSocketTest, TestAdbClientSocket) {
   StartMockAdbServer();
   StartTest();
-  content::RunMessageLoop();
   CheckDevices();
   StopMockAdbServer();
 }

chrome/browser/devtools/device/adb/adb_device_info_query.cc

@@ -209,6 +209,7 @@ void AdbDeviceInfoQuery::ReceivedModel(int result,
     return;
   }
   device_info_.model = response;
+  device_info_.connected = true;
   command_callback_.Run(
       kDumpsysCommand,
       base::Bind(&AdbDeviceInfoQuery::ReceivedDumpsys, base::Unretained(this)));

chrome/browser/devtools/device/adb/adb_device_provider.cc

@@ -17,68 +17,48 @@ const char kLocalAbstractCommand[] = "localabstract:%s";
 
 const int kAdbPort = 5037;
 
-class AdbDeviceImpl : public AndroidDeviceManager::Device {
- public:
-  AdbDeviceImpl(const std::string& serial, bool is_connected);
-  virtual void QueryDeviceInfo(const DeviceInfoCallback& callback) OVERRIDE;
-
-  virtual void OpenSocket(const std::string& name,
-                          const SocketCallback& callback) OVERRIDE;
- private:
-  virtual ~AdbDeviceImpl() {}
-
-  void RunCommand(const std::string& command,
-                  const CommandCallback& callback);
-};
-
-AdbDeviceImpl::AdbDeviceImpl(const std::string& serial, bool is_connected)
-    : Device(serial, is_connected) {
-}
-
-void AdbDeviceImpl::QueryDeviceInfo(const DeviceInfoCallback& callback) {
-  AdbDeviceInfoQuery::Start(
-      base::Bind(&AdbDeviceImpl::RunCommand, this), callback);
-}
-
-void AdbDeviceImpl::OpenSocket(const std::string& name,
-                               const SocketCallback& callback) {
-  DCHECK(CalledOnValidThread());
-  std::string socket_name =
-      base::StringPrintf(kLocalAbstractCommand, name.c_str());
-  AdbClientSocket::TransportQuery(kAdbPort, serial(), socket_name, callback);
-}
-
-void AdbDeviceImpl::RunCommand(const std::string& command,
-                               const CommandCallback& callback) {
-  DCHECK(CalledOnValidThread());
-  std::string query = base::StringPrintf(kHostTransportCommand,
-                                         serial().c_str(), command.c_str());
+static void RunCommand(const std::string& serial,
+                       const std::string& command,
+                       const AdbDeviceProvider::CommandCallback& callback) {
+  std::string query = base::StringPrintf(
+      kHostTransportCommand, serial.c_str(), command.c_str());
   AdbClientSocket::AdbQuery(kAdbPort, query, callback);
 }
 
-// static
-void ReceivedAdbDevices(
-    const AdbDeviceProvider::QueryDevicesCallback& callback,
+static void ReceivedAdbDevices(
+    const AdbDeviceProvider::SerialsCallback& callback,
     int result_code,
     const std::string& response) {
-  AndroidDeviceManager::Devices result;
+  std::vector<std::string> result;
   std::vector<std::string> serials;
   Tokenize(response, "\n", &serials);
   for (size_t i = 0; i < serials.size(); ++i) {
     std::vector<std::string> tokens;
     Tokenize(serials[i], "\t ", &tokens);
-    bool offline = tokens.size() > 1 && tokens[1] == "offline";
-    result.push_back(new AdbDeviceImpl(tokens[0], !offline));
+    result.push_back(tokens[0]);
   }
   callback.Run(result);
 }
 
 } // namespace
 
-AdbDeviceProvider::~AdbDeviceProvider() {
-}
-
-void AdbDeviceProvider::QueryDevices(const QueryDevicesCallback& callback) {
+void AdbDeviceProvider::QueryDevices(const SerialsCallback& callback) {
   AdbClientSocket::AdbQuery(
       kAdbPort, kHostDevicesCommand, base::Bind(&ReceivedAdbDevices, callback));
 }
+
+void AdbDeviceProvider::QueryDeviceInfo(const std::string& serial,
+                                        const DeviceInfoCallback& callback) {
+  AdbDeviceInfoQuery::Start(base::Bind(&RunCommand, serial), callback);
+}
+
+void AdbDeviceProvider::OpenSocket(const std::string& serial,
+                                   const std::string& socket_name,
+                                   const SocketCallback& callback) {
+  std::string request =
+      base::StringPrintf(kLocalAbstractCommand, socket_name.c_str());
+  AdbClientSocket::TransportQuery(kAdbPort, serial, request, callback);
+}
+
+AdbDeviceProvider::~AdbDeviceProvider() {
+}

chrome/browser/devtools/device/adb/adb_device_provider.h

@@ -9,9 +9,14 @@
 
 class AdbDeviceProvider : public AndroidDeviceManager::DeviceProvider {
  public:
-  typedef DeviceProvider::QueryDevicesCallback QueryDevicesCallback;
+  virtual void QueryDevices(const SerialsCallback& callback) OVERRIDE;
 
-  virtual void QueryDevices(const QueryDevicesCallback& callback) OVERRIDE;
+  virtual void QueryDeviceInfo(const std::string& serial,
+                               const DeviceInfoCallback& callback) OVERRIDE;
+
+  virtual void OpenSocket(const std::string& serial,
+                          const std::string& socket_name,
+                          const SocketCallback& callback) OVERRIDE;
 
  private:
   virtual ~AdbDeviceProvider();

chrome/browser/devtools/device/adb/mock_adb_server.cc

@@ -463,7 +463,7 @@ class MockAdbServer : SingleConnectionServer::Parser,
       selected_device_ = command.substr(strlen(kHostTransportPrefix));
       SendResponse("");
     } else if (selected_device_ != kSerialOnline) {
-      NOTREACHED() << "Unknown device - " << selected_device_;
+      Send("FAIL", "device offline (x)");
     } else if (command == kDeviceModelCommand) {
       SendResponse(kDeviceModel);
     } else if (command == kOpenedUnixSocketsCommand) {
@@ -480,10 +480,14 @@ class MockAdbServer : SingleConnectionServer::Parser,
     }
   }
 
-  void SendResponse(const std::string& response) {
+  void SendResponse(const std::string& response) { Send("OKAY", response); }
+
+  void Send(const std::string& status, const std::string& response) {
     CHECK(CalledOnValidThread());
+    CHECK_EQ(4U, status.size());
+
     std::stringstream response_stream;
-    response_stream << "OKAY";
+    response_stream << status;
 
     int size = response.size();
     if (size > 0) {

chrome/browser/devtools/device/android_device_manager.h

@@ -23,6 +23,7 @@ class AndroidDeviceManager
  public:
   typedef base::Callback<void(int, const std::string&)> CommandCallback;
   typedef base::Callback<void(int result, net::StreamSocket*)> SocketCallback;
+  typedef base::Callback<void(const std::vector<std::string>&)> SerialsCallback;
 
   struct BrowserInfo {
     BrowserInfo();
@@ -43,117 +44,170 @@ class AndroidDeviceManager
     ~DeviceInfo();
 
     std::string model;
+    bool connected;
     gfx::Size screen_size;
     std::vector<BrowserInfo> browser_info;
   };
 
   typedef base::Callback<void(const DeviceInfo&)> DeviceInfoCallback;
 
-  class Device : public base::RefCounted<Device>,
-                 public base::NonThreadSafe {
+  class AndroidWebSocket : public base::RefCountedThreadSafe<AndroidWebSocket> {
+   public:
+    class Delegate {
+     public:
+      virtual void OnSocketOpened() = 0;
+      virtual void OnFrameRead(const std::string& message) = 0;
+      virtual void OnSocketClosed(bool closed_by_device) = 0;
+
      protected:
-    friend class AndroidDeviceManager;
+      virtual ~Delegate() {}
+    };
+
+    AndroidWebSocket() {}
+
+    virtual void Connect() = 0;
+    virtual void Disconnect() = 0;
+    virtual void SendFrame(const std::string& message) = 0;
+    virtual void ClearDelegate() = 0;
+
+   protected:
+    virtual ~AndroidWebSocket() {}
+
+   private:
+    friend class base::RefCountedThreadSafe<AndroidWebSocket>;
+
+    DISALLOW_COPY_AND_ASSIGN(AndroidWebSocket);
+  };
 
+  class DeviceProvider;
+
+  class Device : public base::RefCountedThreadSafe<Device>,
+                 public base::NonThreadSafe {
+   public:
+    typedef AndroidDeviceManager::DeviceInfoCallback DeviceInfoCallback;
     typedef AndroidDeviceManager::CommandCallback CommandCallback;
     typedef AndroidDeviceManager::SocketCallback SocketCallback;
-    typedef AndroidDeviceManager::DeviceInfoCallback DeviceInfoCallback;
-
-    Device(const std::string& serial, bool is_connected);
 
-    virtual void QueryDeviceInfo(const DeviceInfoCallback& callback) = 0;
+    void QueryDeviceInfo(const DeviceInfoCallback& callback);
 
-    virtual void OpenSocket(const std::string& socket_name,
-                            const SocketCallback& callback) = 0;
+    void OpenSocket(const std::string& socket_name,
+                    const SocketCallback& callback);
 
-    virtual void HttpQuery(const std::string& socket_name,
+    void SendJsonRequest(const std::string& socket_name,
                          const std::string& request,
                          const CommandCallback& callback);
 
+    void HttpUpgrade(const std::string& socket_name,
+                     const std::string& url,
+                     const SocketCallback& callback);
+
+    scoped_refptr<AndroidWebSocket> CreateWebSocket(
+        const std::string& socket_name,
+        const std::string& url,
+        AndroidWebSocket::Delegate* delegate);
+
     std::string serial() { return serial_; }
-    bool is_connected() { return is_connected_; }
 
-    friend class base::RefCounted<Device>;
+   private:
+    friend class AndroidDeviceManager;
+    Device(scoped_refptr<base::MessageLoopProxy> device_message_loop,
+           scoped_refptr<DeviceProvider> provider,
+           const std::string& serial);
+
+    friend class base::RefCountedThreadSafe<Device>;
     virtual ~Device();
 
-   private:
-    const std::string serial_;
-    const bool is_connected_;
+    scoped_refptr<base::MessageLoopProxy> device_message_loop_;
+    scoped_refptr<DeviceProvider> provider_;
+    std::string serial_;
+    base::WeakPtrFactory<Device> weak_factory_;
 
     DISALLOW_COPY_AND_ASSIGN(Device);
   };
 
   typedef std::vector<scoped_refptr<Device> > Devices;
+  typedef base::Callback<void(const Devices&)> DevicesCallback;
 
-  class DeviceProvider
-      : public base::RefCountedThreadSafe<
-            DeviceProvider,
-            content::BrowserThread::DeleteOnUIThread> {
-   protected:
-    friend class AndroidDeviceManager;
+  class DeviceProvider : public base::RefCountedThreadSafe<DeviceProvider> {
+   public:
+    typedef AndroidDeviceManager::SerialsCallback SerialsCallback;
+    typedef AndroidDeviceManager::DeviceInfoCallback DeviceInfoCallback;
+    typedef AndroidDeviceManager::SocketCallback SocketCallback;
+    typedef AndroidDeviceManager::CommandCallback CommandCallback;
 
-    typedef base::Callback<void(const Devices&)> QueryDevicesCallback;
+    virtual void QueryDevices(const SerialsCallback& callback) = 0;
 
-    virtual void QueryDevices(const QueryDevicesCallback& callback) = 0;
+    virtual void QueryDeviceInfo(const std::string& serial,
+                                 const DeviceInfoCallback& callback) = 0;
 
-   protected:
-    friend struct
-        content::BrowserThread::DeleteOnThread<content::BrowserThread::UI>;
-    friend class base::DeleteHelper<DeviceProvider>;
+    virtual void OpenSocket(const std::string& serial,
+                            const std::string& socket_name,
+                            const SocketCallback& callback) = 0;
+
+    virtual void SendJsonRequest(const std::string& serial,
+                                 const std::string& socket_name,
+                                 const std::string& request,
+                                 const CommandCallback& callback);
 
+    virtual void HttpUpgrade(const std::string& serial,
+                             const std::string& socket_name,
+                             const std::string& url,
+                             const SocketCallback& callback);
+
+    virtual void ReleaseDevice(const std::string& serial);
+
+   protected:
+    friend class base::RefCountedThreadSafe<DeviceProvider>;
     DeviceProvider();
     virtual ~DeviceProvider();
   };
 
- public:
-  static scoped_refptr<AndroidDeviceManager> Create();
-
   typedef std::vector<scoped_refptr<DeviceProvider> > DeviceProviders;
-  typedef base::Callback<void (const std::vector<std::string>&)>
-      QueryDevicesCallback;
 
-  void QueryDevices(const DeviceProviders& providers,
-                    const QueryDevicesCallback& callback);
+  static scoped_refptr<AndroidDeviceManager> Create();
 
-  void Stop();
+  void SetDeviceProviders(const DeviceProviders& providers);
 
-  bool IsConnected(const std::string& serial);
+  void QueryDevices(const DevicesCallback& callback);
 
-  void QueryDeviceInfo(const std::string& serial,
-                       const DeviceInfoCallback& callback);
+  struct DeviceDescriptor {
+    DeviceDescriptor();
+    ~DeviceDescriptor();
 
-  void OpenSocket(const std::string& serial,
-                  const std::string& socket_name,
-                  const SocketCallback& callback);
+    scoped_refptr<DeviceProvider> provider;
+    std::string serial;
+  };
 
-  void HttpQuery(const std::string& serial,
-                 const std::string& socket_name,
-                 const std::string& request,
-                 const CommandCallback& callback);
+  typedef std::vector<DeviceDescriptor> DeviceDescriptors;
 
-  void HttpUpgrade(const std::string& serial,
-                   const std::string& socket_name,
-                   const std::string& url,
-                   const SocketCallback& callback);
+ private:
+  class HandlerThread : public base::RefCountedThreadSafe<HandlerThread> {
+   public:
+    static scoped_refptr<HandlerThread> GetInstance();
+    scoped_refptr<base::MessageLoopProxy> message_loop();
 
    private:
-  AndroidDeviceManager();
+    friend class base::RefCountedThreadSafe<HandlerThread>;
+    static HandlerThread* instance_;
+    static void StopThread(base::Thread* thread);
 
-  friend class base::RefCountedThreadSafe<AndroidDeviceManager>;
+    HandlerThread();
+    virtual ~HandlerThread();
+    base::Thread* thread_;
+  };
 
+  friend class base::RefCountedThreadSafe<AndroidDeviceManager>;
+  AndroidDeviceManager();
   virtual ~AndroidDeviceManager();
 
-  void QueryNextProvider(
-      const QueryDevicesCallback& callback,
-      const DeviceProviders& providers,
-      const Devices& total_devices,
-      const Devices& new_devices);
-
-  Device* FindDevice(const std::string& serial);
+  void UpdateDevices(const DevicesCallback& callback,
+                     DeviceDescriptors* descriptors);
 
-  typedef std::map<std::string, scoped_refptr<Device> > DeviceMap;
-  DeviceMap devices_;
+  typedef std::map<std::string, base::WeakPtr<Device> > DeviceWeakMap;
 
-  bool stopped_;
+  scoped_refptr<HandlerThread> handler_thread_;
+  DeviceProviders providers_;
+  DeviceWeakMap devices_;
 };
 
 #endif  // CHROME_BROWSER_DEVTOOLS_DEVICE_ANDROID_DEVICE_MANAGER_H_

chrome/browser/devtools/device/android_web_socket.cc

@@ -4,7 +4,7 @@
 
 #include "base/message_loop/message_loop.h"
 #include "base/rand_util.h"
-#include "chrome/browser/devtools/device/devtools_android_bridge.h"
+#include "chrome/browser/devtools/device/android_device_manager.h"
 #include "content/public/browser/browser_thread.h"
 #include "net/base/io_buffer.h"
 #include "net/base/net_errors.h"
@@ -18,12 +18,11 @@ namespace {
 
 const int kBufferSize = 16 * 1024;
 
-class WebSocketImpl : public DevToolsAndroidBridge::AndroidWebSocket {
+class WebSocketImpl : public AndroidDeviceManager::AndroidWebSocket {
  public:
-  WebSocketImpl(scoped_refptr<DevToolsAndroidBridge> android_bridge,
-                   AndroidDeviceManager* device_manager,
-                   base::MessageLoop* device_message_loop,
-                   const std::string& serial,
+  typedef AndroidDeviceManager::Device Device;
+  WebSocketImpl(scoped_refptr<base::MessageLoopProxy> device_message_loop,
+                scoped_refptr<Device> device,
                 const std::string& socket_name,
                 const std::string& url,
                 Delegate* delegate);
@@ -38,8 +37,7 @@ class WebSocketImpl : public DevToolsAndroidBridge::AndroidWebSocket {
 
   virtual ~WebSocketImpl();
 
-  void ConnectOnHandlerThread();
-  void ConnectedOnHandlerThread(int result, net::StreamSocket* socket);
+  void Connected(int result, net::StreamSocket* socket);
   void StartListeningOnHandlerThread();
   void OnBytesRead(scoped_refptr<net::IOBuffer> response_buffer, int result);
   void SendFrameOnHandlerThread(const std::string& message);
@@ -50,10 +48,8 @@ class WebSocketImpl : public DevToolsAndroidBridge::AndroidWebSocket {
   void OnFrameRead(const std::string& message);
   void OnSocketClosed(bool closed_by_device);
 
-  scoped_refptr<DevToolsAndroidBridge> android_bridge_;
-  AndroidDeviceManager* device_manager_;
-  base::MessageLoop* device_message_loop_;
-  std::string serial_;
+  scoped_refptr<base::MessageLoopProxy> device_message_loop_;
+  scoped_refptr<Device> device_;
   std::string socket_name_;
   std::string url_;
   scoped_ptr<net::StreamSocket> socket_;
@@ -63,17 +59,13 @@ class WebSocketImpl : public DevToolsAndroidBridge::AndroidWebSocket {
 };
 
 WebSocketImpl::WebSocketImpl(
-    scoped_refptr<DevToolsAndroidBridge> android_bridge,
-    AndroidDeviceManager* device_manager,
-    base::MessageLoop* device_message_loop,
-    const std::string& serial,
+    scoped_refptr<base::MessageLoopProxy> device_message_loop,
+    scoped_refptr<Device> device,
     const std::string& socket_name,
     const std::string& url,
     Delegate* delegate)
-    : android_bridge_(android_bridge),
-      device_manager_(device_manager),
-      device_message_loop_(device_message_loop),
-      serial_(serial),
+    : device_message_loop_(device_message_loop),
+      device_(device),
       socket_name_(socket_name),
       url_(url),
       delegate_(delegate) {
@@ -81,11 +73,12 @@ WebSocketImpl::WebSocketImpl(
 
 void WebSocketImpl::Connect() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  device_message_loop_->PostTask(
-      FROM_HERE, base::Bind(&WebSocketImpl::ConnectOnHandlerThread, this));
+  device_->HttpUpgrade(
+      socket_name_, url_, base::Bind(&WebSocketImpl::Connected, this));
 }
 
 void WebSocketImpl::Disconnect() {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   device_message_loop_->PostTask(
       FROM_HERE,
       base::Bind(&WebSocketImpl::DisconnectOnHandlerThread, this, false));
@@ -103,6 +96,7 @@ void WebSocketImpl::ClearDelegate() {
 }
 
 void WebSocketImpl::SendFrameOnHandlerThread(const std::string& message) {
+  DCHECK_EQ(device_message_loop_, base::MessageLoopProxy::current());
   int mask = base::RandInt(0, 0x7FFFFFFF);
   std::string encoded_frame = WebSocket::EncodeFrameHybi17(message, mask);
   request_buffer_ += encoded_frame;
@@ -110,30 +104,25 @@ void WebSocketImpl::SendFrameOnHandlerThread(const std::string& message) {
     SendPendingRequests(0);
 }
 
-WebSocketImpl::~WebSocketImpl() {}
-
-void WebSocketImpl::ConnectOnHandlerThread() {
-  device_manager_->HttpUpgrade(
-      serial_,
-      socket_name_,
-      url_,
-      base::Bind(&WebSocketImpl::ConnectedOnHandlerThread, this));
+WebSocketImpl::~WebSocketImpl() {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 }
 
-void WebSocketImpl::ConnectedOnHandlerThread(
-  int result, net::StreamSocket* socket) {
+void WebSocketImpl::Connected(int result, net::StreamSocket* socket) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   if (result != net::OK || socket == NULL) {
-    BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
-        base::Bind(&WebSocketImpl::OnSocketClosed, this, true));
+    OnSocketClosed(true);
     return;
   }
   socket_.reset(socket);
-  BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
-      base::Bind(&WebSocketImpl::OnSocketOpened, this));
-  StartListeningOnHandlerThread();
+  device_message_loop_->PostTask(
+      FROM_HERE,
+      base::Bind(&WebSocketImpl::StartListeningOnHandlerThread, this));
+  OnSocketOpened();
 }
 
 void WebSocketImpl::StartListeningOnHandlerThread() {
+  DCHECK_EQ(device_message_loop_, base::MessageLoopProxy::current());
   scoped_refptr<net::IOBuffer> response_buffer =
       new net::IOBuffer(kBufferSize);
   int result = socket_->Read(
@@ -146,6 +135,7 @@ void WebSocketImpl::StartListeningOnHandlerThread() {
 
 void WebSocketImpl::OnBytesRead(
     scoped_refptr<net::IOBuffer> response_buffer, int result) {
+  DCHECK_EQ(device_message_loop_, base::MessageLoopProxy::current());
   if (!socket_)
     return;
 
@@ -185,6 +175,7 @@ void WebSocketImpl::OnBytesRead(
 }
 
 void WebSocketImpl::SendPendingRequests(int result) {
+  DCHECK_EQ(device_message_loop_, base::MessageLoopProxy::current());
   if (!socket_)
     return;
   if (result < 0) {
@@ -205,6 +196,7 @@ void WebSocketImpl::SendPendingRequests(int result) {
 }
 
 void WebSocketImpl::DisconnectOnHandlerThread(bool closed_by_device) {
+  DCHECK_EQ(device_message_loop_, base::MessageLoopProxy::current());
   if (!socket_)
     return;
   // Wipe out socket_ first since Disconnect can re-enter this method.
@@ -231,13 +223,10 @@ void WebSocketImpl::OnSocketClosed(bool closed_by_device) {
 
 }  // namespace
 
-scoped_refptr<DevToolsAndroidBridge::AndroidWebSocket>
-DevToolsAndroidBridge::RemoteBrowser::CreateWebSocket(
+scoped_refptr<AndroidDeviceManager::AndroidWebSocket>
+AndroidDeviceManager::Device::CreateWebSocket(
+    const std::string& socket,
     const std::string& url,
-    DevToolsAndroidBridge::AndroidWebSocket::Delegate* delegate) {
-  return new WebSocketImpl(
-      android_bridge_,
-      android_bridge_->device_manager(),
-      android_bridge_->device_message_loop(),
-      serial_, socket_, url, delegate);
+    AndroidDeviceManager::AndroidWebSocket::Delegate* delegate) {
+  return new WebSocketImpl(device_message_loop_, this, socket, url, delegate);
 }

chrome/browser/devtools/device/devtools_android_bridge.h

@@ -72,34 +72,6 @@ class DevToolsAndroidBridge
     DISALLOW_COPY_AND_ASSIGN(Factory);
   };
 
-  class AndroidWebSocket : public base::RefCountedThreadSafe<AndroidWebSocket> {
-   public:
-    class Delegate {
-     public:
-      virtual void OnSocketOpened() = 0;
-      virtual void OnFrameRead(const std::string& message) = 0;
-      virtual void OnSocketClosed(bool closed_by_device) = 0;
-
-     protected:
-      virtual ~Delegate() {}
-    };
-
-    AndroidWebSocket() {}
-
-    virtual void Connect() = 0;
-    virtual void Disconnect() = 0;
-    virtual void SendFrame(const std::string& message) = 0;
-    virtual void ClearDelegate() = 0;
-
-   protected:
-    virtual ~AndroidWebSocket() {}
-
-   private:
-    friend class base::RefCountedThreadSafe<AndroidWebSocket>;
-
-    DISALLOW_COPY_AND_ASSIGN(AndroidWebSocket);
-  };
-
   class RemotePage {
    public:
     virtual ~RemotePage() {}
@@ -108,15 +80,16 @@ class DevToolsAndroidBridge
   };
 
   typedef base::Callback<void(RemotePage*)> RemotePageCallback;
+  typedef base::Callback<void(int, const std::string&)> JsonRequestCallback;
+  typedef AndroidDeviceManager::Device Device;
+  typedef AndroidDeviceManager::AndroidWebSocket AndroidWebSocket;
 
   class RemoteBrowser : public base::RefCounted<RemoteBrowser> {
    public:
-    RemoteBrowser(
-        scoped_refptr<DevToolsAndroidBridge> android_bridge,
-        const std::string& serial,
+    RemoteBrowser(scoped_refptr<Device> device,
                   const AndroidDeviceManager::BrowserInfo& browser_info);
 
-    std::string serial() { return serial_; }
+    std::string serial() { return device_->serial(); }
     std::string socket() { return socket_; }
 
     std::string display_name() { return display_name_; }
@@ -134,9 +107,9 @@ class DevToolsAndroidBridge
     std::vector<RemotePage*> CreatePages();
     void SetPageDescriptors(const base::ListValue&);
 
-    typedef base::Callback<void(int, const std::string&)> JsonRequestCallback;
     void SendJsonRequest(const std::string& request,
                          const JsonRequestCallback& callback);
+
     void SendProtocolCommand(const std::string& debug_url,
                              const std::string& method,
                              base::DictionaryValue* params,
@@ -172,8 +145,7 @@ class DevToolsAndroidBridge
         int result,
         const std::string& response);
 
-    scoped_refptr<DevToolsAndroidBridge> android_bridge_;
-    const std::string serial_;
+    scoped_refptr<Device> device_;
     const std::string socket_;
     std::string display_name_;
     const AndroidDeviceManager::BrowserInfo::Type type_;
@@ -187,12 +159,10 @@ class DevToolsAndroidBridge
 
   class RemoteDevice : public base::RefCounted<RemoteDevice> {
    public:
-    RemoteDevice(scoped_refptr<DevToolsAndroidBridge> android_bridge,
-                 const std::string& serial,
-                 const AndroidDeviceManager::DeviceInfo& device_info,
-                 bool connected);
+    RemoteDevice(scoped_refptr<Device> device,
+                 const AndroidDeviceManager::DeviceInfo& device_info);
 
-    std::string serial() { return serial_; }
+    std::string serial() { return device_->serial(); }
     std::string model() { return model_; }
     bool is_connected() { return connected_; }
     RemoteBrowsers& browsers() { return browsers_; }
@@ -205,8 +175,7 @@ class DevToolsAndroidBridge
     friend class base::RefCounted<RemoteDevice>;
     virtual ~RemoteDevice();
 
-    scoped_refptr<DevToolsAndroidBridge> android_bridge_;
-    std::string serial_;
+    scoped_refptr<Device> device_;
     std::string model_;
     bool connected_;
     RemoteBrowsers browsers_;
@@ -240,7 +209,7 @@ class DevToolsAndroidBridge
 
   void set_device_providers_for_test(
       const AndroidDeviceManager::DeviceProviders& device_providers) {
-    device_providers_ = device_providers;
+    device_manager_->SetDeviceProviders(device_providers);
   }
 
   static bool HasDevToolsWindow(const std::string& agent_id);
@@ -250,43 +219,18 @@ class DevToolsAndroidBridge
       content::BrowserThread::UI>;
   friend class base::DeleteHelper<DevToolsAndroidBridge>;
 
-  class HandlerThread : public base::RefCountedThreadSafe<HandlerThread> {
-   public:
-    static scoped_refptr<HandlerThread> GetInstance();
-    base::MessageLoop* message_loop();
-
-   private:
-    friend class base::RefCountedThreadSafe<HandlerThread>;
-    static HandlerThread* instance_;
-    static void StopThread(base::Thread* thread);
-
-    HandlerThread();
-    virtual ~HandlerThread();
-    base::Thread* thread_;
-  };
-
   virtual ~DevToolsAndroidBridge();
 
-  base::MessageLoop* device_message_loop() {
-    return handler_thread_->message_loop();
-  }
-
-  AndroidDeviceManager* device_manager() {
-    return device_manager_.get();
-  }
-
-  void CreatedDeviceManager(scoped_refptr<AndroidDeviceManager> device_manager);
   void RequestDeviceList();
-  void ReceivedDeviceList(RemoteDevices* devices);
-
+  void ReceivedDeviceList(scoped_ptr<RemoteDevices> devices);
   void RequestDeviceCount();
   void ReceivedDeviceCount(int count);
 
   void CreateDeviceProviders();
 
   Profile* profile_;
-  scoped_refptr<HandlerThread> handler_thread_;
   scoped_refptr<AndroidDeviceManager> device_manager_;
+  RemoteDevices devices_;
 
   typedef std::vector<DeviceListListener*> DeviceListListeners;
   DeviceListListeners device_list_listeners_;
@@ -294,7 +238,6 @@ class DevToolsAndroidBridge
   typedef std::vector<DeviceCountListener*> DeviceCountListeners;
   DeviceCountListeners device_count_listeners_;
 
-  AndroidDeviceManager::DeviceProviders device_providers_;
   PrefChangeRegistrar pref_change_registrar_;
   DISALLOW_COPY_AND_ASSIGN(DevToolsAndroidBridge);
 };

chrome/browser/devtools/device/self_device_provider.cc

@@ -13,29 +13,31 @@ namespace {
 const char kDeviceModel[] = "Local Chrome";
 const char kBrowserName[] = "Chrome";
 const char kLocalhost[] = "127.0.0.1";
+const char kSerial[] = "local";
 
-class SelfAsDevice : public AndroidDeviceManager::Device {
- public:
-  explicit SelfAsDevice(int port);
-
-  virtual void QueryDeviceInfo(const DeviceInfoCallback& callback) OVERRIDE;
+static void RunSocketCallback(
+    const AndroidDeviceManager::SocketCallback& callback,
+    net::StreamSocket* socket,
+    int result) {
+  callback.Run(result, socket);
+}
 
-  virtual void OpenSocket(const std::string& socket_name,
-                          const SocketCallback& callback) OVERRIDE;
- private:
-  virtual ~SelfAsDevice() {}
+}  // namespace
 
-  int port_;
-};
+SelfAsDeviceProvider::SelfAsDeviceProvider(int port) : port_(port) {
+}
 
-SelfAsDevice::SelfAsDevice(int port)
-    : Device("local", true),
-      port_(port)
-{}
+void SelfAsDeviceProvider::QueryDevices(const SerialsCallback& callback) {
+  std::vector<std::string> result;
+  result.push_back(kSerial);
+  callback.Run(result);
+}
 
-void SelfAsDevice::QueryDeviceInfo(const DeviceInfoCallback& callback) {
+void SelfAsDeviceProvider::QueryDeviceInfo(const std::string& serial,
+                                           const DeviceInfoCallback& callback) {
   AndroidDeviceManager::DeviceInfo device_info;
   device_info.model = kDeviceModel;
+  device_info.connected = true;
 
   AndroidDeviceManager::BrowserInfo browser_info;
   browser_info.socket_name = base::IntToString(port_);
@@ -48,16 +50,9 @@ void SelfAsDevice::QueryDeviceInfo(const DeviceInfoCallback& callback) {
       FROM_HERE, base::Bind(callback, device_info));
 }
 
-static void RunSocketCallback(
-    const AndroidDeviceManager::SocketCallback& callback,
-    net::StreamSocket* socket,
-    int result) {
-  callback.Run(result, socket);
-}
-
-void SelfAsDevice::OpenSocket(const std::string& socket_name,
+void SelfAsDeviceProvider::OpenSocket(const std::string& serial,
+                                      const std::string& socket_name,
                                       const SocketCallback& callback) {
-  DCHECK(CalledOnValidThread());
   // Use plain socket for remote debugging and port forwarding on Desktop
   // (debugging purposes).
   net::IPAddressNumber ip_number;
@@ -70,15 +65,3 @@ void SelfAsDevice::OpenSocket(const std::string& socket_name,
       address_list, NULL, net::NetLog::Source());
   socket->Connect(base::Bind(&RunSocketCallback, callback, socket));
 }
-
-} // namespace
-
-SelfAsDeviceProvider::SelfAsDeviceProvider(int port)
-    : port_(port) {
-}
-
-void SelfAsDeviceProvider::QueryDevices(const QueryDevicesCallback& callback) {
-  AndroidDeviceManager::Devices result;
-  result.push_back(new SelfAsDevice(port_));
-  callback.Run(result);
-}

chrome/browser/devtools/device/self_device_provider.h

@@ -12,7 +12,14 @@ class SelfAsDeviceProvider : public AndroidDeviceManager::DeviceProvider {
  public:
   explicit SelfAsDeviceProvider(int port);
 
-  virtual void QueryDevices(const QueryDevicesCallback& callback) OVERRIDE;
+  virtual void QueryDevices(const SerialsCallback& callback) OVERRIDE;
+
+  virtual void QueryDeviceInfo(const std::string& serial,
+                               const DeviceInfoCallback& callback) OVERRIDE;
+
+  virtual void OpenSocket(const std::string& serial,
+                          const std::string& socket_name,
+                          const SocketCallback& callback) OVERRIDE;
 
  private:
   virtual ~SelfAsDeviceProvider(){}

chrome/browser/devtools/device/usb/usb_device_provider.cc

@@ -18,82 +18,33 @@ const char kLocalAbstractCommand[] = "localabstract:%s";
 
 const int kBufferSize = 16 * 1024;
 
-class UsbDeviceImpl : public AndroidDeviceManager::Device {
- public:
-  explicit UsbDeviceImpl(AndroidUsbDevice* device);
-
-  virtual void QueryDeviceInfo(const DeviceInfoCallback& callback) OVERRIDE;
-
-  virtual void OpenSocket(const std::string& name,
-                          const SocketCallback& callback) OVERRIDE;
- private:
-  void OnOpenSocket(const SocketCallback& callback,
-                    net::StreamSocket* socket,
-                    int result);
-  void RunCommand(const std::string& command,
-                  const CommandCallback& callback);
-  void OpenedForCommand(const CommandCallback& callback,
-                        net::StreamSocket* socket,
-                        int result);
-  void OnRead(net::StreamSocket* socket,
-              scoped_refptr<net::IOBuffer> buffer,
-              const std::string& data,
-              const CommandCallback& callback,
-              int result);
-
-  virtual ~UsbDeviceImpl() {}
-  scoped_refptr<AndroidUsbDevice> device_;
-};
-
-
-UsbDeviceImpl::UsbDeviceImpl(AndroidUsbDevice* device)
-    : Device(device->serial(), device->is_connected()),
-      device_(device) {
-  device_->InitOnCallerThread();
-}
-
-void UsbDeviceImpl::QueryDeviceInfo(const DeviceInfoCallback& callback) {
-  AdbDeviceInfoQuery::Start(
-      base::Bind(&UsbDeviceImpl::RunCommand, this), callback);
-}
-
-void UsbDeviceImpl::OpenSocket(const std::string& name,
-                               const SocketCallback& callback) {
-  DCHECK(CalledOnValidThread());
-  std::string socket_name =
-      base::StringPrintf(kLocalAbstractCommand, name.c_str());
-  net::StreamSocket* socket = device_->CreateSocket(socket_name);
-  if (!socket) {
-    callback.Run(net::ERR_CONNECTION_FAILED, NULL);
-    return;
-  }
-  int result = socket->Connect(base::Bind(&UsbDeviceImpl::OnOpenSocket, this,
-                                          callback, socket));
-  if (result != net::ERR_IO_PENDING)
-    callback.Run(result, NULL);
-}
-
-void UsbDeviceImpl::OnOpenSocket(const SocketCallback& callback,
+void OnOpenSocket(const UsbDeviceProvider::SocketCallback& callback,
                   net::StreamSocket* socket,
                   int result) {
   callback.Run(result, result == net::OK ? socket : NULL);
 }
 
-void UsbDeviceImpl::RunCommand(const std::string& command,
-                               const CommandCallback& callback) {
-  DCHECK(CalledOnValidThread());
-  net::StreamSocket* socket = device_->CreateSocket(command);
-  if (!socket) {
-    callback.Run(net::ERR_CONNECTION_FAILED, std::string());
+void OnRead(net::StreamSocket* socket,
+            scoped_refptr<net::IOBuffer> buffer,
+            const std::string& data,
+            const UsbDeviceProvider::CommandCallback& callback,
+            int result) {
+  if (result <= 0) {
+    callback.Run(result, result == 0 ? data : std::string());
+    delete socket;
     return;
   }
-  int result = socket->Connect(base::Bind(&UsbDeviceImpl::OpenedForCommand,
-                                          this, callback, socket));
+
+  std::string new_data = data + std::string(buffer->data(), result);
+  result =
+      socket->Read(buffer,
+                   kBufferSize,
+                   base::Bind(&OnRead, socket, buffer, new_data, callback));
   if (result != net::ERR_IO_PENDING)
-    callback.Run(result, std::string());
+    OnRead(socket, buffer, new_data, callback, result);
 }
 
-void UsbDeviceImpl::OpenedForCommand(const CommandCallback& callback,
+void OpenedForCommand(const UsbDeviceProvider::CommandCallback& callback,
                       net::StreamSocket* socket,
                       int result) {
   if (result != net::OK) {
@@ -101,40 +52,25 @@ void UsbDeviceImpl::OpenedForCommand(const CommandCallback& callback,
     return;
   }
   scoped_refptr<net::IOBuffer> buffer = new net::IOBuffer(kBufferSize);
-  result = socket->Read(buffer, kBufferSize,
-                        base::Bind(&UsbDeviceImpl::OnRead, this,
-                                   socket, buffer, std::string(), callback));
+  result = socket->Read(
+      buffer,
+      kBufferSize,
+      base::Bind(&OnRead, socket, buffer, std::string(), callback));
   if (result != net::ERR_IO_PENDING)
     OnRead(socket, buffer, std::string(), callback, result);
 }
 
-void UsbDeviceImpl::OnRead(net::StreamSocket* socket,
-                           scoped_refptr<net::IOBuffer> buffer,
-                           const std::string& data,
-                           const CommandCallback& callback,
-                           int result) {
-  if (result <= 0) {
-    callback.Run(result, result == 0 ? data : std::string());
-    delete socket;
+void RunCommand(scoped_refptr<AndroidUsbDevice> device,
+                const std::string& command,
+                const UsbDeviceProvider::CommandCallback& callback) {
+  net::StreamSocket* socket = device->CreateSocket(command);
+  if (!socket) {
+    callback.Run(net::ERR_CONNECTION_FAILED, std::string());
     return;
   }
-
-  std::string new_data = data + std::string(buffer->data(), result);
-  result = socket->Read(buffer, kBufferSize,
-                        base::Bind(&UsbDeviceImpl::OnRead, this,
-                                   socket, buffer, new_data, callback));
+  int result = socket->Connect(base::Bind(&OpenedForCommand, callback, socket));
   if (result != net::ERR_IO_PENDING)
-    OnRead(socket, buffer, new_data, callback, result);
-}
-
-static void EnumeratedDevices(
-    const UsbDeviceProvider::QueryDevicesCallback& callback,
-    const AndroidUsbDevices& devices) {
-  AndroidDeviceManager::Devices result;
-  for (AndroidUsbDevices::const_iterator it = devices.begin();
-      it != devices.end(); ++it)
-    result.push_back(new UsbDeviceImpl(*it));
-  callback.Run(result);
+    callback.Run(result, std::string());
 }
 
 } // namespace
@@ -149,10 +85,60 @@ UsbDeviceProvider::UsbDeviceProvider(Profile* profile){
   rsa_key_.reset(AndroidRSAPrivateKey(profile));
 }
 
+void UsbDeviceProvider::QueryDevices(const SerialsCallback& callback) {
+  AndroidUsbDevice::Enumerate(
+      rsa_key_.get(),
+      base::Bind(&UsbDeviceProvider::EnumeratedDevices, this, callback));
+}
+
+void UsbDeviceProvider::QueryDeviceInfo(const std::string& serial,
+                                        const DeviceInfoCallback& callback) {
+  UsbDeviceMap::iterator it = device_map_.find(serial);
+  if (it == device_map_.end() || !it->second->is_connected()) {
+    AndroidDeviceManager::DeviceInfo offline_info;
+    callback.Run(offline_info);
+    return;
+  }
+  AdbDeviceInfoQuery::Start(base::Bind(&RunCommand, it->second), callback);
+}
+
+void UsbDeviceProvider::OpenSocket(const std::string& serial,
+                                   const std::string& name,
+                                   const SocketCallback& callback) {
+  UsbDeviceMap::iterator it = device_map_.find(serial);
+  if (it == device_map_.end()) {
+    callback.Run(net::ERR_CONNECTION_FAILED, NULL);
+    return;
+  }
+  std::string socket_name =
+      base::StringPrintf(kLocalAbstractCommand, name.c_str());
+  net::StreamSocket* socket = it->second->CreateSocket(socket_name);
+  if (!socket) {
+    callback.Run(net::ERR_CONNECTION_FAILED, NULL);
+    return;
+  }
+  int result = socket->Connect(base::Bind(&OnOpenSocket, callback, socket));
+  if (result != net::ERR_IO_PENDING)
+    callback.Run(result, NULL);
+}
+
+void UsbDeviceProvider::ReleaseDevice(const std::string& serial) {
+  device_map_.erase(serial);
+}
+
 UsbDeviceProvider::~UsbDeviceProvider() {
 }
 
-void UsbDeviceProvider::QueryDevices(const QueryDevicesCallback& callback) {
-  AndroidUsbDevice::Enumerate(
-      rsa_key_.get(), base::Bind(&EnumeratedDevices, callback));
+void UsbDeviceProvider::EnumeratedDevices(const SerialsCallback& callback,
+                                          const AndroidUsbDevices& devices) {
+  std::vector<std::string> result;
+  device_map_.clear();
+  for (AndroidUsbDevices::const_iterator it = devices.begin();
+       it != devices.end(); ++it) {
+    result.push_back((*it)->serial());
+    device_map_[(*it)->serial()] = *it;
+    (*it)->InitOnCallerThread();
+  }
+  callback.Run(result);
 }
+

chrome/browser/devtools/device/usb/usb_device_provider.h

@@ -11,20 +11,36 @@ namespace crypto {
 class RSAPrivateKey;
 }
 
+class AndroidUsbDevice;
+
 class UsbDeviceProvider : public AndroidDeviceManager::DeviceProvider {
  public:
-  typedef DeviceProvider::QueryDevicesCallback QueryDevicesCallback;
-
   static void CountDevices(const base::Callback<void(int)>& callback);
 
   explicit UsbDeviceProvider(Profile* profile);
 
-  virtual void QueryDevices(const QueryDevicesCallback& callback) OVERRIDE;
+  virtual void QueryDevices(const SerialsCallback& callback) OVERRIDE;
+
+  virtual void QueryDeviceInfo(const std::string& serial,
+                               const DeviceInfoCallback& callback) OVERRIDE;
+
+  virtual void OpenSocket(const std::string& serial,
+                          const std::string& socket_name,
+                          const SocketCallback& callback) OVERRIDE;
+
+  virtual void ReleaseDevice(const std::string& serial) OVERRIDE;
 
  private:
   virtual ~UsbDeviceProvider();
 
+  void EnumeratedDevices(
+      const SerialsCallback& callback,
+      const std::vector<scoped_refptr<AndroidUsbDevice> >& devices);
+
+  typedef std::map<std::string, scoped_refptr<AndroidUsbDevice> > UsbDeviceMap;
+
   scoped_ptr<crypto::RSAPrivateKey>  rsa_key_;
+  UsbDeviceMap device_map_;
 };
 
 #endif  // CHROME_BROWSER_DEVTOOLS_DEVICE_USB_USB_DEVICE_PROVIDER_H_