Commit a932d613 authored by marja@chromium.org's avatar marja@chromium.org

Tentatively enable StartupBrowserCreatorFirstRunTest.* on official Mac builder.

I recently fixed some places which passed empty URLs around (r272182), and these
tests might have been failing because of the empty URL behavior (empty URLs were
treated as the home page, and maybe the home page is something different on the
official Mac builder than other builders).

Feel free to revert this commit if the tests fail.

R=bartfab@chromium.org
TBR=sky@chromium.org
BUG=314819

Review URL: https://codereview.chromium.org/308083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273825 0039d316-1c4b-4281-b951-d872f2087c98
parent d46bc310
...@@ -1077,14 +1077,7 @@ void StartupBrowserCreatorFirstRunTest::SetUpInProcessBrowserTestFixture() { ...@@ -1077,14 +1077,7 @@ void StartupBrowserCreatorFirstRunTest::SetUpInProcessBrowserTestFixture() {
#endif // defined(ENABLE_CONFIGURATION_POLICY) #endif // defined(ENABLE_CONFIGURATION_POLICY)
} }
#if defined(GOOGLE_CHROME_BUILD) && defined(OS_MACOSX) IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest, SyncPromoForbidden) {
// http://crbug.com/314819
#define MAYBE_SyncPromoForbidden DISABLED_SyncPromoForbidden
#else
#define MAYBE_SyncPromoForbidden SyncPromoForbidden
#endif
IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
MAYBE_SyncPromoForbidden) {
// Consistently enable the welcome page on all platforms. // Consistently enable the welcome page on all platforms.
first_run::SetShouldShowWelcomePage(); first_run::SetShouldShowWelcomePage();
...@@ -1118,14 +1111,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest, ...@@ -1118,14 +1111,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
tab_strip->GetWebContentsAt(1)->GetURL()); tab_strip->GetWebContentsAt(1)->GetURL());
} }
#if defined(GOOGLE_CHROME_BUILD) && defined(OS_MACOSX) IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest, SyncPromoAllowed) {
// http://crbug.com/314819
#define MAYBE_SyncPromoAllowed DISABLED_SyncPromoAllowed
#else
#define MAYBE_SyncPromoAllowed SyncPromoAllowed
#endif
IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
MAYBE_SyncPromoAllowed) {
// Consistently enable the welcome page on all platforms. // Consistently enable the welcome page on all platforms.
first_run::SetShouldShowWelcomePage(); first_run::SetShouldShowWelcomePage();
...@@ -1159,14 +1145,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest, ...@@ -1159,14 +1145,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
tab_strip->GetWebContentsAt(1)->GetURL()); tab_strip->GetWebContentsAt(1)->GetURL());
} }
#if defined(GOOGLE_CHROME_BUILD) && defined(OS_MACOSX)
// http://crbug.com/314819
#define MAYBE_FirstRunTabsPromoAllowed DISABLED_FirstRunTabsPromoAllowed
#else
#define MAYBE_FirstRunTabsPromoAllowed FirstRunTabsPromoAllowed
#endif
IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest, IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
MAYBE_FirstRunTabsPromoAllowed) { FirstRunTabsPromoAllowed) {
// Simulate the following master_preferences: // Simulate the following master_preferences:
// { // {
// "first_run_tabs" : [ // "first_run_tabs" : [
...@@ -1201,15 +1181,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest, ...@@ -1201,15 +1181,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
tab_strip->GetWebContentsAt(1)->GetURL().ExtractFileName()); tab_strip->GetWebContentsAt(1)->GetURL().ExtractFileName());
} }
#if defined(GOOGLE_CHROME_BUILD) && defined(OS_MACOSX)
// http://crbug.com/314819
#define MAYBE_FirstRunTabsContainSyncPromo \
DISABLED_FirstRunTabsContainSyncPromo
#else
#define MAYBE_FirstRunTabsContainSyncPromo FirstRunTabsContainSyncPromo
#endif
IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest, IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
MAYBE_FirstRunTabsContainSyncPromo) { FirstRunTabsContainSyncPromo) {
// Simulate the following master_preferences: // Simulate the following master_preferences:
// { // {
// "first_run_tabs" : [ // "first_run_tabs" : [
...@@ -1249,16 +1222,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest, ...@@ -1249,16 +1222,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
tab_strip->GetWebContentsAt(1)->GetURL()); tab_strip->GetWebContentsAt(1)->GetURL());
} }
#if defined(GOOGLE_CHROME_BUILD) && defined(OS_MACOSX)
// http://crbug.com/314819
#define MAYBE_FirstRunTabsContainNTPSyncPromoAllowed \
DISABLED_FirstRunTabsContainNTPSyncPromoAllowed
#else
#define MAYBE_FirstRunTabsContainNTPSyncPromoAllowed \
FirstRunTabsContainNTPSyncPromoAllowed
#endif
IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest, IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
MAYBE_FirstRunTabsContainNTPSyncPromoAllowed) { FirstRunTabsContainNTPSyncPromoAllowed) {
// Simulate the following master_preferences: // Simulate the following master_preferences:
// { // {
// "first_run_tabs" : [ // "first_run_tabs" : [
...@@ -1296,16 +1261,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest, ...@@ -1296,16 +1261,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
tab_strip->GetWebContentsAt(1)->GetURL().ExtractFileName()); tab_strip->GetWebContentsAt(1)->GetURL().ExtractFileName());
} }
#if defined(GOOGLE_CHROME_BUILD) && defined(OS_MACOSX)
// http://crbug.com/314819
#define MAYBE_FirstRunTabsContainNTPSyncPromoForbidden \
DISABLED_FirstRunTabsContainNTPSyncPromoForbidden
#else
#define MAYBE_FirstRunTabsContainNTPSyncPromoForbidden \
FirstRunTabsContainNTPSyncPromoForbidden
#endif
IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest, IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
MAYBE_FirstRunTabsContainNTPSyncPromoForbidden) { FirstRunTabsContainNTPSyncPromoForbidden) {
// Simulate the following master_preferences: // Simulate the following master_preferences:
// { // {
// "first_run_tabs" : [ // "first_run_tabs" : [
...@@ -1343,15 +1300,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest, ...@@ -1343,15 +1300,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
tab_strip->GetWebContentsAt(1)->GetURL().ExtractFileName()); tab_strip->GetWebContentsAt(1)->GetURL().ExtractFileName());
} }
#if defined(GOOGLE_CHROME_BUILD) && defined(OS_MACOSX)
// http://crbug.com/314819
#define MAYBE_FirstRunTabsSyncPromoForbidden \
DISABLED_FirstRunTabsSyncPromoForbidden
#else
#define MAYBE_FirstRunTabsSyncPromoForbidden FirstRunTabsSyncPromoForbidden
#endif
IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest, IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
MAYBE_FirstRunTabsSyncPromoForbidden) { FirstRunTabsSyncPromoForbidden) {
// Simulate the following master_preferences: // Simulate the following master_preferences:
// { // {
// "first_run_tabs" : [ // "first_run_tabs" : [
...@@ -1385,16 +1335,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest, ...@@ -1385,16 +1335,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
} }
#if defined(ENABLE_CONFIGURATION_POLICY) #if defined(ENABLE_CONFIGURATION_POLICY)
#if defined(GOOGLE_CHROME_BUILD) && defined(OS_MACOSX)
// http://crbug.com/314819
#define MAYBE_RestoreOnStartupURLsPolicySpecified \
DISABLED_RestoreOnStartupURLsPolicySpecified
#else
#define MAYBE_RestoreOnStartupURLsPolicySpecified \
RestoreOnStartupURLsPolicySpecified
#endif
IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest, IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
MAYBE_RestoreOnStartupURLsPolicySpecified) { RestoreOnStartupURLsPolicySpecified) {
// Simulate the following master_preferences: // Simulate the following master_preferences:
// { // {
// "sync_promo": { // "sync_promo": {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment