Change getContentMimeType getContentMetadata to use FileEntry
Change the fileManagerPrivate API to use FileEntry, like all other API in that API group. Move the Blob handling code lower down into the file_manager_private_custom_bindings.js code. Since Blob reading could fail, use an errorUUID to represent the invalid blob and make the C++ generate a chrome.runtime.lastError when the errorUUID is seen. Attach the actual DOMError to that lastError in the return code in the custom bindings JS (to aid debugging). Update the apitest JS to use FileEntry instead of Blob. Update apitest C++ to copy more testing files to the "testing" volume. Add new files_manager test resource "empty.txt", which has no content, to apitest the "empty Blob" case. Bug: 1114622 Change-Id: Ie69c012ec23fac847ea19bbfcc09ad9b23c13c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359872Reviewed-by:Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#798614}
Showing
Please register or sign in to comment