Commit aa49806e authored by Jonathan Ross's avatar Jonathan Ross Committed by Commit Bot

Revert "Add logging when receiving an invalid frame token"

This reverts commit 9dc21ef5.

Reason for revert: This identified the root cause of a flaking test is a bug within the gpu frame submission code path. More work is needed to debug the root cause. In the interim I'm removing this logging until someone can take a closer look

Original change's description:
> Add logging when receiving an invalid frame token
> 
> To investigate issue 1045372 some crash keys were added to log the old
> and new frame tokens however this doesn't work for the flaky browser
> tests I am investigating in issue 1022321. This change adds log messages
> which should show up when the test flakes.
> 
> Bug: 1022321
> Change-Id: If1c88d1cea3dc771c96a4d636b6797a8686b6315
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123030
> Auto-Submit: Reilly Grant <reillyg@chromium.org>
> Commit-Queue: Jonathan Ross <jonross@chromium.org>
> Reviewed-by: Jonathan Ross <jonross@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754145}

TBR=jonross@chromium.org,reillyg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1022321
Change-Id: Ibdcf7b30b77f836bb3d0257c77c056c31f554298
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134608Reviewed-by: default avatarJonathan Ross <jonross@chromium.org>
Reviewed-by: default avatarReilly Grant <reillyg@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755929}
parent cf548d4a
......@@ -35,11 +35,6 @@ void FrameTokenMessageQueue::DidProcessFrame(uint32_t frame_token) {
base::NumberToString(frame_token));
base::debug::DumpWithoutCrashing();
// TODO(reillyg): Remove this once investigation into
// https://crbug.com/1022321 is over.
LOG(ERROR) << "Got invalid frame token: " << frame_token
<< " <= " << last_received_frame_token_;
client_->OnInvalidFrameToken(frame_token);
return;
}
......@@ -64,10 +59,6 @@ void FrameTokenMessageQueue::EnqueueOrRunFrameTokenCallback(
base::OnceClosure callback) {
// Zero token is invalid.
if (!frame_token) {
// TODO(reillyg): Remove this once investigation into
// https://crbug.com/1022321 is over.
LOG(ERROR) << "Got invalid frame token: " << frame_token;
client_->OnInvalidFrameToken(frame_token);
return;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment