Commit aa4de8d3 authored by Tommy Nyquist's avatar Tommy Nyquist Committed by Commit Bot

Revert "aw: Force FullScreenView resize"

This reverts commit d5c71f24.

Reason for revert: Multiple tests failing in: AwContentsClientFullScreenTest.
See bug for details, but this is the blame range:
https://chromium.googlesource.com/chromium/src/+log/d4bdcae63a031f35db804aaf0b5dc61848be0d6e..a3e8b15392454293e2556669b6c093e63e8e2316

Original change's description:
> aw: Force FullScreenView resize
> 
> Follow up to r654240
> 
> Apparently on apps that does not end up resizing the FullScreenView from
> the WebView, avoiding a resize cause odd problems such as FullScreenView
> not getting forwarded key events or not being on top of other views as
> it should be. Instead set the initial height to be arbitrarily 5 pixels
> less in height. This avoids affecting the compositing pipeline
> significantly, since height changes generally has small effects on
> layout.
> 
> Bug: 1054286
> Change-Id: Ia5bbb384a75736784e660567dd7e36bacbc4b5b9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119802
> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
> Commit-Queue: Bo <boliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#753588}

TBR=boliu@chromium.org,tobiasjs@chromium.org

Change-Id: Ia2dd90baf3ae1dfd6bb045b914ea51a26b8863fe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1054286
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122818Reviewed-by: default avatarTommy Nyquist <nyquist@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753810}
parent cd348b23
......@@ -33,11 +33,7 @@ public class FullScreenView extends FrameLayout {
int initialWidth, int initialHeight) {
super(context);
setRight(initialWidth);
// Setting to the exact same dimensions avoids a layout later in some apps.
// This apparently causes some unexpected behavior such as not receiving key events
// Arbitrarily set the height to 5 pixels less to force a layout while also minimizing
// changes to viewport that can affect the graphics pipeline.
setBottom(Math.max(0, initialHeight - 5));
setBottom(initialHeight);
setAwViewMethods(awViewMethods);
mAwContents = awContents;
mInternalAccessAdapter = new InternalAccessAdapter();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment