Skip to content

GitLab

T
tangled
Commit aaa6ca07 authored by Sean Harrison's avatar Sean Harrison Committed by Commit Bot
Browse files
Options

Add missing enums to SettingsPageInteraction enum 

Add:
PRIVACY_SITE_SETTINGS_ALL
PRIVACY_SITE_SETTINGS_AR
PRIVACY_SITE_SETTINGS_VR

These were missed in a previous CL and hits a DCHECK

Add corresponding test to site_settings_page_test.js

Merge all tests into one to remove flakiness, testing each logging call in a separate test was taking too long and causing sporadic timeouts resulting in flakiness.

Now all logging checks are done by navigating around a single test instance and resetting proxy state, speed up removes all flakiness and was significant enough to allow the merging of all 4 split test suites without timeout concerns.

Bug: 1046488, 1048858
Change-Id: I074e2581d3489e179adfdc187e7165284ccc2685
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027447
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738512}
parent 560e52cc
Show whitespace changes
Inline Side-by-side
Showing with 289 additions and 345 deletions
chrome/browser/resources/settings/metrics_browser_proxy.js
View file @ aaa6ca07
...@@ -55,8 +55,11 @@ cr.define('settings', function() { ...@@ -55,8 +55,11 @@ cr.define('settings', function() {
PRIVACY_SITE_SETTINGS_PAYMENT_HANDLER: 36, PRIVACY_SITE_SETTINGS_PAYMENT_HANDLER: 36,
PRIVACY_SITE_SETTINGS_MIXEDSCRIPT: 37, PRIVACY_SITE_SETTINGS_MIXEDSCRIPT: 37,
PRIVACY_SITE_SETTINGS_BLUETOOTH_SCANNING: 38, PRIVACY_SITE_SETTINGS_BLUETOOTH_SCANNING: 38,
PRIVACY_SITE_SETTINGS_ALL: 39,
PRIVACY_SITE_SETTINGS_AR: 40,
PRIVACY_SITE_SETTINGS_VR: 41,
// Leave this at the end. // Leave this at the end.
SETTINGS_MAX_VALUE: 38, SETTINGS_MAX_VALUE: 41,
}; };
/** @interface */ /** @interface */
......
chrome/test/data/webui/settings/cr_settings_browsertest.js
View file @ aaa6ca07
...@@ -982,21 +982,6 @@ TEST_F('CrSettingsSiteSettingsPageTest', 'UMALoggingTests', function() { ...@@ -982,21 +982,6 @@ TEST_F('CrSettingsSiteSettingsPageTest', 'UMALoggingTests', function() {
mocha.run(); mocha.run();
}); });
TEST_F('CrSettingsSiteSettingsPageTest', 'UMALoggingTestsPart2', function() {
settings_site_settings_page.registerUMALoggingTestsPart2();
mocha.run();
});
TEST_F('CrSettingsSiteSettingsPageTest', 'UMALoggingTestsPart3', function() {
settings_site_settings_page.registerUMALoggingTestsPart3();
mocha.run();
});
TEST_F('CrSettingsSiteSettingsPageTest', 'UMALoggingTestsPart4', function() {
settings_site_settings_page.registerUMALoggingTestsPart4();
mocha.run();
});
/** /**
* Test fixture for * Test fixture for
* chrome/browser/resources/settings/privacy_page/ * chrome/browser/resources/settings/privacy_page/
......
chrome/test/data/webui/settings/site_settings_page_test.js
View file @ aaa6ca07
...@@ -24,390 +24,343 @@ cr.define('settings_site_settings_page', function() { ...@@ -24,390 +24,343 @@ cr.define('settings_site_settings_page', function() {
page.remove(); page.remove();
}); });
test('LogCookiesClick', function() { test('LogAllSiteSettingsPageClicks', async function() {
page.$$('#all-sites').click();
let result =
await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals(
settings.SettingsPageInteractions.PRIVACY_SITE_SETTINGS_ALL,
result);
settings.Router.getInstance().navigateTo(settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#cookies').click(); page.$$('#cookies').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions.PRIVACY_SITE_SETTINGS_COOKIES,
.PRIVACY_SITE_SETTINGS_COOKIES,
result); result);
});
});
test('LogLocationClick', function() { settings.Router.getInstance().navigateTo(settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#location').click(); page.$$('#location').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions.PRIVACY_SITE_SETTINGS_LOCATION,
.PRIVACY_SITE_SETTINGS_LOCATION,
result); result);
});
});
test('LogCameraClick', function() { settings.Router.getInstance().navigateTo(settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#camera').click(); page.$$('#camera').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions.PRIVACY_SITE_SETTINGS_CAMERA,
.PRIVACY_SITE_SETTINGS_CAMERA,
result); result);
});
});
test('LogMicrophoneClick', function() { settings.Router.getInstance().navigateTo(settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#microphone').click(); page.$$('#microphone').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions.PRIVACY_SITE_SETTINGS_MICROPHONE,
.PRIVACY_SITE_SETTINGS_MICROPHONE,
result); result);
});
});
test('LogSensorsClick', function() { settings.Router.getInstance().navigateTo(settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#sensors').click(); page.$$('#sensors').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions.PRIVACY_SITE_SETTINGS_SENSORS,
.PRIVACY_SITE_SETTINGS_SENSORS,
result); result);
});
});
test('LogNotificationsClick', function() { settings.Router.getInstance().navigateTo(settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#notifications').click(); page.$$('#notifications').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions
.PRIVACY_SITE_SETTINGS_NOTIFICATIONS, .PRIVACY_SITE_SETTINGS_NOTIFICATIONS,
result); result);
});
});
});
}
// Split tests into 4 to prevent timeout.
function registerUMALoggingTestsPart2() {
suite('SiteSettingsPageUMACheckPart2', function() {
/** @type {settings.TestPrivacyPageBrowserProxy} */
let testBrowserProxy;
/** @type {SettingsSiteSettingsPageElement} */
let page;
setup(function() { settings.Router.getInstance().navigateTo(settings.routes.SITE_SETTINGS);
testBrowserProxy = new TestMetricsBrowserProxy(); testBrowserProxy.reset();
settings.MetricsBrowserProxyImpl.instance_ = testBrowserProxy;
PolymerTest.clearBody();
page = document.createElement('settings-site-settings-page');
document.body.appendChild(page);
Polymer.dom.flush();
});
teardown(function() {
page.remove();
});
test('LogJavascriptClick', function() {
page.$$('#javascript').click(); page.$$('#javascript').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions.PRIVACY_SITE_SETTINGS_JAVASCRIPT,
.PRIVACY_SITE_SETTINGS_JAVASCRIPT,
result); result);
});
});
test('LogFlashClick', function() { settings.Router.getInstance().navigateTo(settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#flash').click(); page.$$('#flash').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions.PRIVACY_SITE_SETTINGS_FLASH, settings.SettingsPageInteractions.PRIVACY_SITE_SETTINGS_FLASH,
result); result);
});
});
test('LogImagesClick', function() { settings.Router.getInstance().navigateTo(settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#images').click(); page.$$('#images').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions.PRIVACY_SITE_SETTINGS_IMAGES,
.PRIVACY_SITE_SETTINGS_IMAGES,
result); result);
});
});
test('LogPopupsClick', function() { settings.Router.getInstance().navigateTo(settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#popups').click(); page.$$('#popups').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions.PRIVACY_SITE_SETTINGS_POPUPS,
.PRIVACY_SITE_SETTINGS_POPUPS,
result); result);
});
});
if (loadTimeData.getBoolean('enableSafeBrowsingSubresourceFilter')) { settings.Router.getInstance().navigateTo(settings.routes.SITE_SETTINGS);
test('LogAdsClick', function() { testBrowserProxy.reset();
page.$$('#ads').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram')
.then(result => {
assertEquals(
settings.SettingsPageInteractions.PRIVACY_SITE_SETTINGS_ADS,
result);
});
});
}
test('LogBackgroundSyncClick', function() {
page.$$('#background-sync').click(); page.$$('#background-sync').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions
.PRIVACY_SITE_SETTINGS_BACKGROUND_SYNC, .PRIVACY_SITE_SETTINGS_BACKGROUND_SYNC,
result); result);
});
});
test('LogSoundClick', function() { settings.Router.getInstance().navigateTo(settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#sound').click(); page.$$('#sound').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions.PRIVACY_SITE_SETTINGS_SOUND, settings.SettingsPageInteractions.PRIVACY_SITE_SETTINGS_SOUND,
result); result);
});
});
});
}
// Split tests into 4 to prevent timeout.
function registerUMALoggingTestsPart3() {
suite('SiteSettingsPageUMACheckPart3', function() {
/** @type {settings.TestPrivacyPageBrowserProxy} */
let testBrowserProxy;
/** @type {SettingsSiteSettingsPageElement} */ if (loadTimeData.getBoolean('enableSafeBrowsingSubresourceFilter')) {
let page; settings.Router.getInstance().navigateTo(
settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
setup(function() { page.$$('#ads').click();
testBrowserProxy = new TestMetricsBrowserProxy(); result =
settings.MetricsBrowserProxyImpl.instance_ = testBrowserProxy; await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
PolymerTest.clearBody(); assertEquals(
page = document.createElement('settings-site-settings-page'); settings.SettingsPageInteractions.PRIVACY_SITE_SETTINGS_ADS,
document.body.appendChild(page); result);
Polymer.dom.flush(); }
});
teardown(function() { settings.Router.getInstance().navigateTo(settings.routes.SITE_SETTINGS);
page.remove(); testBrowserProxy.reset();
});
test('LogAutomaticDownloadsClick', function() {
page.$$('#automatic-downloads').click(); page.$$('#automatic-downloads').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions
.PRIVACY_SITE_SETTINGS_AUTOMATIC_DOWNLOADS, .PRIVACY_SITE_SETTINGS_AUTOMATIC_DOWNLOADS,
result); result);
});
});
test('LogUnsandboxedPluginsClick', function() { settings.Router.getInstance().navigateTo(settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#unsandboxed-plugins').click(); page.$$('#unsandboxed-plugins').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions
.PRIVACY_SITE_SETTINGS_UNSANDBOXED_PLUGINS, .PRIVACY_SITE_SETTINGS_UNSANDBOXED_PLUGINS,
result); result);
});
});
if (!loadTimeData.getBoolean('isGuest')) { if (!loadTimeData.getBoolean('isGuest')) {
test('LogHandlersClick', function() { settings.Router.getInstance().navigateTo(
settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#protocol-handlers').click(); page.$$('#protocol-handlers').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions.PRIVACY_SITE_SETTINGS_HANDLERS,
.PRIVACY_SITE_SETTINGS_HANDLERS,
result); result);
});
});
} }
test('LogMidiDevicesClick', function() { settings.Router.getInstance().navigateTo(settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#midi-devices').click(); page.$$('#midi-devices').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions
.PRIVACY_SITE_SETTINGS_MIDI_DEVICES, .PRIVACY_SITE_SETTINGS_MIDI_DEVICES,
result); result);
});
});
test('LogZoomLevelsClick', function() { settings.Router.getInstance().navigateTo(settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#zoom-levels').click(); page.$$('#zoom-levels').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions.PRIVACY_SITE_SETTINGS_ZOOM_LEVELS,
.PRIVACY_SITE_SETTINGS_ZOOM_LEVELS,
result); result);
});
});
test('LogUSBDevicesClick', function() { settings.Router.getInstance().navigateTo(settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#usb-devices').click(); page.$$('#usb-devices').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions.PRIVACY_SITE_SETTINGS_USB_DEVICES,
.PRIVACY_SITE_SETTINGS_USB_DEVICES,
result); result);
});
});
test('LogSerialPortsClick', function() { settings.Router.getInstance().navigateTo(settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#serial-ports').click(); page.$$('#serial-ports').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions
.PRIVACY_SITE_SETTINGS_SERIAL_PORTS, .PRIVACY_SITE_SETTINGS_SERIAL_PORTS,
result); result);
});
});
});
}
// Split tests into 4 to prevent timeout.
function registerUMALoggingTestsPart4() {
suite('SiteSettingsPageUMACheckPart4', function() {
/** @type {settings.TestPrivacyPageBrowserProxy} */
let testBrowserProxy;
/** @type {SettingsSiteSettingsPageElement} */
let page;
setup(function() {
testBrowserProxy = new TestMetricsBrowserProxy();
settings.MetricsBrowserProxyImpl.instance_ = testBrowserProxy;
PolymerTest.clearBody();
page = document.createElement('settings-site-settings-page');
document.body.appendChild(page);
Polymer.dom.flush();
});
teardown(function() {
page.remove();
});
if (loadTimeData.getBoolean( if (loadTimeData.getBoolean(
'enableNativeFileSystemWriteContentSetting')) { 'enableNativeFileSystemWriteContentSetting')) {
test('LogNativeFileSystemWriteClick', function() { settings.Router.getInstance().navigateTo(
settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#native-file-system-write').click(); page.$$('#native-file-system-write').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions
.PRIVACY_SITE_SETTINGS_NATIVE_FILE_SYSTEM_WRITE, .PRIVACY_SITE_SETTINGS_NATIVE_FILE_SYSTEM_WRITE,
result); result);
});
});
} }
test('LogPDFDocumentsClick', function() { settings.Router.getInstance().navigateTo(settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#pdf-documents').click(); page.$$('#pdf-documents').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions
.PRIVACY_SITE_SETTINGS_PDF_DOCUMENTS, .PRIVACY_SITE_SETTINGS_PDF_DOCUMENTS,
result); result);
});
});
test('LogProtectedContentClick', function() { settings.Router.getInstance().navigateTo(settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#protected-content').click(); page.$$('#protected-content').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions
.PRIVACY_SITE_SETTINGS_PROTECTED_CONTENT, .PRIVACY_SITE_SETTINGS_PROTECTED_CONTENT,
result); result);
});
});
test('LogClipboardClick', function() { settings.Router.getInstance().navigateTo(settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#clipboard').click(); page.$$('#clipboard').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions.PRIVACY_SITE_SETTINGS_CLIPBOARD,
.PRIVACY_SITE_SETTINGS_CLIPBOARD,
result); result);
});
});
if (loadTimeData.getBoolean('enablePaymentHandlerContentSetting')) { if (loadTimeData.getBoolean('enablePaymentHandlerContentSetting')) {
test('LogPaymentHandlerClick', function() { settings.Router.getInstance().navigateTo(
settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#paymentHandler').click(); page.$$('#paymentHandler').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions
.PRIVACY_SITE_SETTINGS_PAYMENT_HANDLER, .PRIVACY_SITE_SETTINGS_PAYMENT_HANDLER,
result); result);
});
});
} }
if (loadTimeData.getBoolean('enableInsecureContentContentSetting')) { if (loadTimeData.getBoolean('enableInsecureContentContentSetting')) {
test('LogMixedscriptClick', function() { settings.Router.getInstance().navigateTo(
settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#mixedscript').click(); page.$$('#mixedscript').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions
.PRIVACY_SITE_SETTINGS_MIXEDSCRIPT, .PRIVACY_SITE_SETTINGS_MIXEDSCRIPT,
result); result);
});
});
} }
if (loadTimeData.getBoolean('enableExperimentalWebPlatformFeatures')) { if (loadTimeData.getBoolean('enableExperimentalWebPlatformFeatures')) {
test('LogBluetoothScanningClick', function() { settings.Router.getInstance().navigateTo(
settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#bluetooth-scanning').click(); page.$$('#bluetooth-scanning').click();
return testBrowserProxy.whenCalled('recordSettingsPageHistogram') result =
.then(result => { await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals( assertEquals(
settings.SettingsPageInteractions settings.SettingsPageInteractions
.PRIVACY_SITE_SETTINGS_BLUETOOTH_SCANNING, .PRIVACY_SITE_SETTINGS_BLUETOOTH_SCANNING,
result); result);
});
});
} }
if (loadTimeData.getBoolean('enableWebXrContentSetting')) {
settings.Router.getInstance().navigateTo(
settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#ar').click();
result =
await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals(
settings.SettingsPageInteractions.PRIVACY_SITE_SETTINGS_AR,
result);
settings.Router.getInstance().navigateTo(
settings.routes.SITE_SETTINGS);
testBrowserProxy.reset();
page.$$('#vr').click();
result =
await testBrowserProxy.whenCalled('recordSettingsPageHistogram');
assertEquals(
settings.SettingsPageInteractions.PRIVACY_SITE_SETTINGS_VR,
result);
}
});
}); });
} }
return { return {
registerUMALoggingTests, registerUMALoggingTests,
registerUMALoggingTestsPart2,
registerUMALoggingTestsPart3,
registerUMALoggingTestsPart4,
}; };
}); });
\ No newline at end of file
tools/metrics/histograms/enums.xml
View file @ aaa6ca07
...@@ -58299,6 +58299,9 @@ Called by update_net_trust_anchors.py.--> ...@@ -58299,6 +58299,9 @@ Called by update_net_trust_anchors.py.-->
<int value="36" label="PRIVACY_SITE_SETTINGS_PAYMENT_HANDLER"/> <int value="36" label="PRIVACY_SITE_SETTINGS_PAYMENT_HANDLER"/>
<int value="37" label="PRIVACY_SITE_SETTINGS_MIXEDSCRIPT"/> <int value="37" label="PRIVACY_SITE_SETTINGS_MIXEDSCRIPT"/>
<int value="38" label="PRIVACY_SITE_SETTINGS_BLUETOOTH_SCANNING"/> <int value="38" label="PRIVACY_SITE_SETTINGS_BLUETOOTH_SCANNING"/>
<int value="39" label="PRIVACY_SITE_SETTINGS_ALL"/>
<int value="40" label="PRIVACY_SITE_SETTINGS_AR"/>
<int value="41" label="PRIVACY_SITE_SETTINGS_VR"/>
</enum> </enum>
<enum name="SettingsResetPromptConfigError"> <enum name="SettingsResetPromptConfigError">
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment