Commit aadcd93b authored by Rob Buis's avatar Rob Buis Committed by Commit Bot

Rename starAtom, nullAtom and emptyAtom in comments

Rename starAtom, nullAtom and emptyAtom in comments to the
new names created after the great Blink rename.

Bug: None
Change-Id: Ibad34e8aa6316d6fb22863292ed35bfcec3d492a
Reviewed-on: https://chromium-review.googlesource.com/671191Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Cr-Commit-Position: refs/heads/master@{#502716}
parent 1fafff57
...@@ -264,7 +264,7 @@ class CORE_EXPORT CSSSelector { ...@@ -264,7 +264,7 @@ class CORE_EXPORT CSSSelector {
// WARNING: Use of QualifiedName by attribute() is a lie. // WARNING: Use of QualifiedName by attribute() is a lie.
// attribute() will return a QualifiedName with prefix and namespaceURI // attribute() will return a QualifiedName with prefix and namespaceURI
// set to starAtom to mean "matches any namespace". Be very careful // set to g_star_atom to mean "matches any namespace". Be very careful
// how you use the returned QualifiedName. // how you use the returned QualifiedName.
// http://www.w3.org/TR/css3-selectors/#attrnmsp // http://www.w3.org/TR/css3-selectors/#attrnmsp
const QualifiedName& Attribute() const; const QualifiedName& Attribute() const;
......
...@@ -69,7 +69,7 @@ bool CSSParserSelector::IsSimple() const { ...@@ -69,7 +69,7 @@ bool CSSParserSelector::IsSimple() const {
if (selector_->Match() == CSSSelector::kTag) { if (selector_->Match() == CSSSelector::kTag) {
// We can't check against anyQName() here because namespace may not be // We can't check against anyQName() here because namespace may not be
// nullAtom. // g_null_atom.
// Example: // Example:
// @namespace "http://www.w3.org/2000/svg"; // @namespace "http://www.w3.org/2000/svg";
// svg:not(:root) { ... // svg:not(:root) { ...
......
...@@ -152,8 +152,8 @@ class CORE_EXPORT Element : public ContainerNode { ...@@ -152,8 +152,8 @@ class CORE_EXPORT Element : public ContainerNode {
bool hasAttribute(const QualifiedName&) const; bool hasAttribute(const QualifiedName&) const;
const AtomicString& getAttribute(const QualifiedName&) const; const AtomicString& getAttribute(const QualifiedName&) const;
// Passing nullAtom as the second parameter removes the attribute when calling // Passing g_null_atom as the second parameter removes the attribute when
// either of these set methods. // calling either of these set methods.
void setAttribute(const QualifiedName&, const AtomicString& value); void setAttribute(const QualifiedName&, const AtomicString& value);
void SetSynchronizedLazyAttribute(const QualifiedName&, void SetSynchronizedLazyAttribute(const QualifiedName&,
const AtomicString& value); const AtomicString& value);
......
...@@ -116,8 +116,8 @@ DEFINE_GLOBAL(QualifiedName, g_null_name); ...@@ -116,8 +116,8 @@ DEFINE_GLOBAL(QualifiedName, g_null_name);
void QualifiedName::InitAndReserveCapacityForSize(unsigned size) { void QualifiedName::InitAndReserveCapacityForSize(unsigned size) {
DCHECK(g_star_atom.Impl()); DCHECK(g_star_atom.Impl());
GetQualifiedNameCache().ReserveCapacityForSize(size + GetQualifiedNameCache().ReserveCapacityForSize(
2 /*starAtom and nullAtom */); size + 2 /*g_star_atom and g_null_atom */);
new ((void*)&g_any_name) new ((void*)&g_any_name)
QualifiedName(g_null_atom, g_star_atom, g_star_atom, true); QualifiedName(g_null_atom, g_star_atom, g_star_atom, true);
new ((void*)&g_null_name) new ((void*)&g_null_name)
......
...@@ -1095,7 +1095,7 @@ void DocumentLoader::InstallNewDocument( ...@@ -1095,7 +1095,7 @@ void DocumentLoader::InstallNewDocument(
// that the name would be nulled and if the name is accessed after we will // that the name would be nulled and if the name is accessed after we will
// fire a UseCounter. If we decide to move forward with this change, we'd // fire a UseCounter. If we decide to move forward with this change, we'd
// actually clean the name here. // actually clean the name here.
// frame_->tree().setName(nullAtom); // frame_->tree().setName(g_null_atom);
frame_->Tree().ExperimentalSetNulledName(); frame_->Tree().ExperimentalSetNulledName();
} }
......
...@@ -286,7 +286,7 @@ AXObject* AXObjectCacheImpl::Get(AccessibleNode* accessible_node) { ...@@ -286,7 +286,7 @@ AXObject* AXObjectCacheImpl::Get(AccessibleNode* accessible_node) {
} }
// FIXME: This probably belongs on Node. // FIXME: This probably belongs on Node.
// FIXME: This should take a const char*, but one caller passes nullAtom. // FIXME: This should take a const char*, but one caller passes g_null_atom.
static bool NodeHasRole(Node* node, const String& role) { static bool NodeHasRole(Node* node, const String& role) {
if (!node || !node->IsElementNode()) if (!node || !node->IsElementNode())
return false; return false;
......
...@@ -47,8 +47,8 @@ struct AtomicStringHash; ...@@ -47,8 +47,8 @@ struct AtomicStringHash;
// count in StringImpl, and would hit a runtime CHECK in // count in StringImpl, and would hit a runtime CHECK in
// AtomicStringTable::remove(). // AtomicStringTable::remove().
// //
// Exception: nullAtom and emptyAtom, are shared in multiple threads, and are // Exception: g_null_atom and g_empty_atom, are shared in multiple threads, and
// never stored in AtomicStringTable. // are never stored in AtomicStringTable.
class WTF_EXPORT AtomicString { class WTF_EXPORT AtomicString {
USING_FAST_MALLOC(AtomicString); USING_FAST_MALLOC(AtomicString);
......
...@@ -50,7 +50,7 @@ struct AtomicStringHash { ...@@ -50,7 +50,7 @@ struct AtomicStringHash {
template <> template <>
struct HashTraits<AtomicString> : SimpleClassHashTraits<AtomicString> { struct HashTraits<AtomicString> : SimpleClassHashTraits<AtomicString> {
// Unlike other types, we can return a const reference for AtomicString's // Unlike other types, we can return a const reference for AtomicString's
// empty value (nullAtom). // empty value (g_null_atom).
typedef const AtomicString& PeekOutType; typedef const AtomicString& PeekOutType;
static const AtomicString& EmptyValue() { return g_null_atom; } static const AtomicString& EmptyValue() { return g_null_atom; }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment