Commit ab63f022 authored by Gordana Cmiljanovic's avatar Gordana Cmiljanovic Committed by Commit Bot

Disable GLVirtualContextsEXTWindowRectanglesTest for some devices

The test is causing crash on devices which do not suport OpenGL ES3.

Bug: 644265
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id98475c27897e1ca4cd207af4d145ab0c4733a85
Reviewed-on: https://chromium-review.googlesource.com/788112Reviewed-by: default avatarKai Ninomiya <kainino@chromium.org>
Reviewed-by: default avatarZhenyao Mo <zmo@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519765}
parent dc5041fa
...@@ -32,12 +32,13 @@ class GLVirtualContextsEXTWindowRectanglesTest : public testing::Test { ...@@ -32,12 +32,13 @@ class GLVirtualContextsEXTWindowRectanglesTest : public testing::Test {
} }
bool IsApplicable() const { bool IsApplicable() const {
// If a driver isn't capable of supporting ES3 context, creating // Not applicable for devices not supporting OpenGLES3.
// ContextGroup will fail. if (!gl_real_shared_.IsInitialized()) {
bool have_es3 = gl_real_shared_.decoder() && return false;
gl_real_shared_.decoder()->GetContextGroup(); }
bool have_ext = GLTestHelper::HasExtension("GL_EXT_window_rectangles"); bool have_ext = GLTestHelper::HasExtension("GL_EXT_window_rectangles");
return have_es3 && have_ext; return have_ext;
} }
GLManager gl_real_shared_; GLManager gl_real_shared_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment