Commit abd2dc65 authored by Ewann's avatar Ewann Committed by Commit Bot

PageInfoRefactoring to Field Trial Testing Configuration

Bug: 1073831
Change-Id: Ib4d61f98b55ab6c2311cd1627ce12391d0c97e58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279974Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790286}
parent 7b9224e9
...@@ -414,6 +414,12 @@ void AssertIsShowingDistillablePage(bool online, const GURL& distillable_url) { ...@@ -414,6 +414,12 @@ void AssertIsShowingDistillablePage(bool online, const GURL& distillable_url) {
@synthesize serverRespondsWithContent = _serverRespondsWithContent; @synthesize serverRespondsWithContent = _serverRespondsWithContent;
@synthesize serverResponseDelay = _serverResponseDelay; @synthesize serverResponseDelay = _serverResponseDelay;
- (AppLaunchConfiguration)appConfigurationForTestCase {
AppLaunchConfiguration config;
config.features_enabled.push_back(kPageInfoRefactoring);
return config;
}
- (void)setUp { - (void)setUp {
[super setUp]; [super setUp];
GREYAssertNil([ReadingListAppInterface clearEntries], GREYAssertNil([ReadingListAppInterface clearEntries],
...@@ -483,9 +489,7 @@ void AssertIsShowingDistillablePage(bool online, const GURL& distillable_url) { ...@@ -483,9 +489,7 @@ void AssertIsShowingDistillablePage(bool online, const GURL& distillable_url) {
// Verify that the Page Info is about offline pages. // Verify that the Page Info is about offline pages.
id<GREYMatcher> pageInfoTitleMatcher = id<GREYMatcher> pageInfoTitleMatcher =
chrome_test_util::StaticTextWithAccessibilityLabelId( chrome_test_util::StaticTextWithAccessibilityLabelId(
base::FeatureList::IsEnabled(kPageInfoRefactoring) IDS_IOS_PAGE_INFO_OFFLINE_PAGE_LABEL);
? IDS_IOS_PAGE_INFO_OFFLINE_PAGE_LABEL
: IDS_IOS_PAGE_INFO_OFFLINE_TITLE);
[[EarlGrey selectElementWithMatcher:pageInfoTitleMatcher] [[EarlGrey selectElementWithMatcher:pageInfoTitleMatcher]
assertWithMatcher:grey_notNil()]; assertWithMatcher:grey_notNil()];
......
...@@ -3355,6 +3355,21 @@ ...@@ -3355,6 +3355,21 @@
] ]
} }
], ],
"IOSPageInfoRefactoring": [
{
"platforms": [
"ios"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"PageInfoRefactoring"
]
}
]
}
],
"IOSReloadSadTab": [ "IOSReloadSadTab": [
{ {
"platforms": [ "platforms": [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment