Commit aca33f4f authored by enne@chromium.org's avatar enne@chromium.org

Remove renderer-side tracking of accelerated compositing

Remove didActivate/didDeactivateCompositor from everywhere that calls it
as it now does nothing.

BUG=none

Review URL: https://codereview.chromium.org/288633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271234 0039d316-1c4b-4281-b951-d872f2087c98
parent ab2c31f7
...@@ -1938,8 +1938,6 @@ void RenderViewImpl::didActivateCompositor() { ...@@ -1938,8 +1938,6 @@ void RenderViewImpl::didActivateCompositor() {
AsWeakPtr()); AsWeakPtr());
} }
#endif #endif
RenderWidget::didActivateCompositor();
} }
void RenderViewImpl::didHandleGestureEvent( void RenderViewImpl::didHandleGestureEvent(
......
...@@ -383,7 +383,6 @@ RenderWidget::RenderWidget(blink::WebPopupType popup_type, ...@@ -383,7 +383,6 @@ RenderWidget::RenderWidget(blink::WebPopupType popup_type,
popup_type_(popup_type), popup_type_(popup_type),
pending_window_rect_count_(0), pending_window_rect_count_(0),
suppress_next_char_events_(false), suppress_next_char_events_(false),
is_accelerated_compositing_active_(false),
screen_info_(screen_info), screen_info_(screen_info),
device_scale_factor_(screen_info_.deviceScaleFactor), device_scale_factor_(screen_info_.deviceScaleFactor),
is_threaded_compositing_enabled_(false), is_threaded_compositing_enabled_(false),
...@@ -486,11 +485,8 @@ void RenderWidget::CompleteInit() { ...@@ -486,11 +485,8 @@ void RenderWidget::CompleteInit() {
init_complete_ = true; init_complete_ = true;
if (webwidget_) { if (webwidget_)
if (is_threaded_compositing_enabled_ || ForceCompositingModeEnabled()) {
webwidget_->enterForceCompositingMode(true); webwidget_->enterForceCompositingMode(true);
}
}
if (compositor_) if (compositor_)
StartCompositor(); StartCompositor();
...@@ -784,13 +780,9 @@ void RenderWidget::OnWasShown(bool needs_repainting) { ...@@ -784,13 +780,9 @@ void RenderWidget::OnWasShown(bool needs_repainting) {
return; return;
// Generate a full repaint. // Generate a full repaint.
if (!is_accelerated_compositing_active_) {
didInvalidateRect(gfx::Rect(size_.width(), size_.height()));
} else {
if (compositor_) if (compositor_)
compositor_->SetNeedsForcedRedraw(); compositor_->SetNeedsForcedRedraw();
scheduleComposite(); scheduleComposite();
}
} }
void RenderWidget::OnWasSwappedOut() { void RenderWidget::OnWasSwappedOut() {
...@@ -1172,19 +1164,6 @@ void RenderWidget::AutoResizeCompositor() { ...@@ -1172,19 +1164,6 @@ void RenderWidget::AutoResizeCompositor() {
compositor_->setViewportSize(size_, physical_backing_size_); compositor_->setViewportSize(size_, physical_backing_size_);
} }
void RenderWidget::didActivateCompositor() {
TRACE_EVENT0("gpu", "RenderWidget::didActivateCompositor");
is_accelerated_compositing_active_ = true;
webwidget_->enterForceCompositingMode(true);
}
void RenderWidget::didDeactivateCompositor() {
TRACE_EVENT0("gpu", "RenderWidget::didDeactivateCompositor");
is_accelerated_compositing_active_ = false;
}
void RenderWidget::initializeLayerTreeView() { void RenderWidget::initializeLayerTreeView() {
compositor_ = RenderWidgetCompositor::Create( compositor_ = RenderWidgetCompositor::Create(
this, is_threaded_compositing_enabled_); this, is_threaded_compositing_enabled_);
...@@ -1485,12 +1464,8 @@ void RenderWidget::OnRepaint(gfx::Size size_to_paint) { ...@@ -1485,12 +1464,8 @@ void RenderWidget::OnRepaint(gfx::Size size_to_paint) {
} }
set_next_paint_is_repaint_ack(); set_next_paint_is_repaint_ack();
if (is_accelerated_compositing_active_ && compositor_) { if (compositor_)
compositor_->SetNeedsRedrawRect(gfx::Rect(size_to_paint)); compositor_->SetNeedsRedrawRect(gfx::Rect(size_to_paint));
} else {
gfx::Rect repaint_rect(size_to_paint.width(), size_to_paint.height());
didInvalidateRect(repaint_rect);
}
} }
void RenderWidget::OnSyntheticGestureCompleted() { void RenderWidget::OnSyntheticGestureCompleted() {
...@@ -1546,12 +1521,7 @@ void RenderWidget::SetDeviceScaleFactor(float device_scale_factor) { ...@@ -1546,12 +1521,7 @@ void RenderWidget::SetDeviceScaleFactor(float device_scale_factor) {
return; return;
device_scale_factor_ = device_scale_factor; device_scale_factor_ = device_scale_factor;
if (!is_accelerated_compositing_active_) {
didInvalidateRect(gfx::Rect(size_.width(), size_.height()));
} else {
scheduleComposite(); scheduleComposite();
}
} }
void RenderWidget::OnOrientationChange() { void RenderWidget::OnOrientationChange() {
......
...@@ -122,8 +122,6 @@ class CONTENT_EXPORT RenderWidget ...@@ -122,8 +122,6 @@ class CONTENT_EXPORT RenderWidget
virtual void suppressCompositorScheduling(bool enable); virtual void suppressCompositorScheduling(bool enable);
virtual void willBeginCompositorFrame(); virtual void willBeginCompositorFrame();
virtual void didAutoResize(const blink::WebSize& new_size); virtual void didAutoResize(const blink::WebSize& new_size);
virtual void didActivateCompositor() OVERRIDE;
virtual void didDeactivateCompositor();
virtual void initializeLayerTreeView(); virtual void initializeLayerTreeView();
virtual blink::WebLayerTreeView* layerTreeView(); virtual blink::WebLayerTreeView* layerTreeView();
virtual void didBecomeReadyForAdditionalInput(); virtual void didBecomeReadyForAdditionalInput();
...@@ -641,10 +639,6 @@ class CONTENT_EXPORT RenderWidget ...@@ -641,10 +639,6 @@ class CONTENT_EXPORT RenderWidget
// Indicates if the next sequence of Char events should be suppressed or not. // Indicates if the next sequence of Char events should be suppressed or not.
bool suppress_next_char_events_; bool suppress_next_char_events_;
// Set to true if painting to the window is handled by the accelerated
// compositor.
bool is_accelerated_compositing_active_;
// Properties of the screen hosting this RenderWidget instance. // Properties of the screen hosting this RenderWidget instance.
blink::WebScreenInfo screen_info_; blink::WebScreenInfo screen_info_;
......
...@@ -324,22 +324,16 @@ void RenderWidgetFullscreenPepper::DidChangeCursor( ...@@ -324,22 +324,16 @@ void RenderWidgetFullscreenPepper::DidChangeCursor(
void RenderWidgetFullscreenPepper::SetLayer(blink::WebLayer* layer) { void RenderWidgetFullscreenPepper::SetLayer(blink::WebLayer* layer) {
layer_ = layer; layer_ = layer;
bool compositing = !!layer_; if (!layer_) {
if (compositing != is_accelerated_compositing_active_) { compositor_->clearRootLayer();
if (compositing) { return;
}
if (!layerTreeView()) if (!layerTreeView())
initializeLayerTreeView(); initializeLayerTreeView();
if (!layerTreeView())
return;
layer_->setBounds(blink::WebSize(size())); layer_->setBounds(blink::WebSize(size()));
layer_->setDrawsContent(true); layer_->setDrawsContent(true);
compositor_->setDeviceScaleFactor(device_scale_factor_); compositor_->setDeviceScaleFactor(device_scale_factor_);
compositor_->setRootLayer(*layer_); compositor_->setRootLayer(*layer_);
didActivateCompositor();
} else {
didDeactivateCompositor();
}
}
} }
bool RenderWidgetFullscreenPepper::OnMessageReceived(const IPC::Message& msg) { bool RenderWidgetFullscreenPepper::OnMessageReceived(const IPC::Message& msg) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment