Commit ad3abd6d authored by Mohamed Amir Yosef's avatar Mohamed Amir Yosef Committed by Commit Bot

[Passwords] Smaller arrow in the move bubble

This CL uses a smaller arrow (and different arrow) in the move bubble
to be aligned with the arrow used in move bubble in
chrome://settings/passwords
It also adds some margins around the new smaller arrow.

Screenshot: https://screenshot.googleplex.com/3ApL5zYMe8A2HQi

Bug: 1100814
Change-Id: I83caa8ad0ec2d78a65cc9bd5517b17068d6cce6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461318Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815641}
parent 90a3c86d
......@@ -32,6 +32,7 @@ aggregate_vector_icons2("chrome_vector_icons") {
"caret_down.icon",
"caret_up.icon",
"cast_for_education.icon",
"chevron_right.icon",
"click_to_call_illustration.icon",
"click_to_call_illustration_dark.icon",
"close_all.icon",
......
// Copyright 2020 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
CANVAS_DIMENSIONS, 24,
MOVE_TO, 7.59f, 18.59f,
LINE_TO, 9, 20,
R_LINE_TO, 8, -8,
R_LINE_TO, -8, -8,
R_LINE_TO, -1.41f, 1.41f,
LINE_TO, 14.17f, 12,
CLOSE
......@@ -25,6 +25,7 @@
#include "ui/gfx/paint_vector_icon.h"
#include "ui/gfx/text_constants.h"
#include "ui/views/bubble/bubble_frame_view.h"
#include "ui/views/controls/color_tracking_icon_view.h"
#include "ui/views/controls/label.h"
#include "ui/views/layout/flex_layout.h"
#include "ui/views/layout/layout_provider.h"
......@@ -186,12 +187,18 @@ MoveToAccountStoreBubbleView::MovingBannerView::MovingBannerView(
SetLayoutManager(std::make_unique<views::FlexLayout>())
->SetOrientation(views::LayoutOrientation::kHorizontal)
.SetMainAxisAlignment(views::LayoutAlignment::kCenter)
.SetCrossAxisAlignment(views::LayoutAlignment::kCenter);
.SetCrossAxisAlignment(views::LayoutAlignment::kCenter)
.SetDefault(
views::kMarginsKey,
gfx::Insets(
/*vertical=*/0,
/*horizontal=*/ChromeLayoutProvider::Get()->GetDistanceMetric(
views::DISTANCE_RELATED_BUTTON_HORIZONTAL)));
from_view = AddChildView(std::move(from_image));
auto arrow_view = std::make_unique<VectorIconView>(
kBookmarkbarTouchOverflowIcon, kImageSize);
auto arrow_view = std::make_unique<views::ColorTrackingIconView>(
kChevronRightIcon, gfx::kFaviconSize);
arrow_view->EnableCanvasFlippingForRTLUI(true);
AddChildView(std::move(arrow_view));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment