Commit ad6bcbc3 authored by tonyg@chromium.org's avatar tonyg@chromium.org

Revert of Fix and reenable checkbox in Polymer page set....

Revert of Fix and reenable checkbox in Polymer page set. (https://codereview.chromium.org/437353002/)

Reason for revert:
Fails on N5 (at least).

Unhandled exception while running http://www.polymer-project.org/components/paper-elements/demo.html#paper-checkbox

Traceback (most recent call last):
  _RunPage at tools/telemetry/telemetry/page/page_runner.py:533
    test.RunPage(page, page_state.tab, results)
  RunPage at tools/telemetry/telemetry/page/page_test.py:232
    self._RunMethod(page, self._action_name_to_run, action_runner)
  _RunMethod at tools/telemetry/telemetry/page/page_test.py:241
    run_method(action_runner)
  RunSmoothness at tools/perf/page_sets/polymer.py:124
    self.TouchEverything(action_runner)
  TouchEverything at tools/perf/page_sets/polymer.py:154
    self.DoActionOnWidgetType(action_runner, tappable_type, self.TapWidget)
  DoActionOnWidgetType at tools/perf/page_sets/polymer.py:169
    element_query + '.offsetParent != null'):
  EvaluateJavaScript at tools/telemetry/telemetry/page/actions/action_runner.py:148
    return self._tab.EvaluateJavaScript(expression)
  EvaluateJavaScript at tools/telemetry/telemetry/core/web_contents.py:108
    expr, context_id=None, timeout=timeout)
  EvaluateJavaScriptInContext at tools/telemetry/telemetry/core/web_contents.py:124
    expr, context_id=context_id, timeout=timeout)
  EvaluateJavaScript at tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py:176
    return self._runtime.Evaluate(expr, context_id, timeout)
  Evaluate at tools/telemetry/telemetry/core/backends/chrome/inspector_runtime.py:46
    raise exceptions.EvaluateException(res['result']['result']['description'])
EvaluateException: TypeError: Cannot read property 'offsetParent' of undefined

Locals:
  context_id : None
  expr       : 'document.querySelector("sampler-scaffold").$.frame.contentDocument.querySelectorAll("body paper-checkbox:not([disabled]):not([active]):not([checked])")[2].offsetParent != null'
  request    : {'params': {'returnByValue': True, 'expression': 'document.querySelector("sampler-scaffold").$.frame.contentDocument.querySelectorAll("body paper-checkbox:not([disabled]):not([active]):not([checked])")[2].offsetParent != null'}, 'method': 'Runtime.evaluate', 'id': 173}
  res        : {u'id': 173, u'result': {u'wasThrown': True, u'exceptionDetails': {u'url': u'', u'text': u"Uncaught TypeError: Cannot read property 'offsetParent' of undefined", u'line': 1, u'column': 68}, u'result': {u'className': u'TypeError', u'type': u'object', u'description': u"TypeError: Cannot read property 'offsetParent' of undefined", u'objectId': u'{"injectedScriptId":4,"id":1}'}}}
  timeout    : 90

http://chromegw/i/chromium.perf/builders/Android%20Nexus5%20Perf/builds/1213/steps/smoothness.polymer/logs/stdio

Original issue's description:
> Fix and reenable checkbox in Polymer page set.
> 
> BUG=394756
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287596

TBR=dtu@chromium.org,nduca@chromium.org,wiltzius@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=394756

Review URL: https://codereview.chromium.org/443793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287667 0039d316-1c4b-4281-b951-d872f2087c98
parent 3bd21fe3
......@@ -145,7 +145,8 @@ class PolymerSampler(PolymerPage):
'paper-checkbox',
'paper-fab',
'paper-icon-button',
'paper-radio-button',
# crbug.com/394756
# 'paper-radio-button',
'paper-tab',
'paper-toggle-button',
'x-shadow',
......@@ -161,7 +162,7 @@ class PolymerSampler(PolymerPage):
# currently active as they typically don't produce animation frames.
element_list_query = (self.iframe_js +
('.contentDocument.querySelectorAll("body %s:not([disabled]):'
'not([active]):not([checked])")' % widget_type))
'not([active])")' % widget_type))
roles_count_query = element_list_query + '.length'
for i in range(action_runner.EvaluateJavaScript(roles_count_query)):
element_query = element_list_query + ("[%d]" % i)
......@@ -205,7 +206,8 @@ class PolymerPageSet(page_set_module.PageSet):
'paper-checkbox',
'paper-fab',
'paper-icon-button',
'paper-radio-button',
# crbug.com/394756
# 'paper-radio-button',
'paper-shadow',
'paper-tabs',
'paper-toggle-button',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment