Commit ad7c11cd authored by mseaborn@chromium.org's avatar mseaborn@chromium.org

NaCl: Stop disabling the sandbox on Linux for testing in nacl_integration

These days, Linux Chromium uses two sandboxes simultaneously: a SUID
sandbox and (on recent kernels) a seccomp-BPF sandbox.  There's no
reason to disable the seccomp-BPF sandbox when running NaCl tests.
There's not much reason to disable the SUID sandbox either: the SUID
helper should be installed on the bots these days, but if it's not
present Chromium should continue fine without it.

BUG=none
TEST=nacl_integration

Review URL: https://codereview.chromium.org/11412294

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170855 0039d316-1c4b-4281-b951-d872f2087c98
parent e96a5bc1
......@@ -286,11 +286,6 @@ class ChromeLauncher(BrowserLauncher):
if self.options.ppapi_plugin is None:
cmd.append('--enable-nacl')
disable_sandbox = False
# Sandboxing Chrome on Linux requires a SUIDed helper binary. This
# binary may not be installed, so disable sandboxing to avoid the
# corner cases where it may fail. This is a little scarry, because it
# means we are not testing NaCl inside the outer sandbox on Linux.
disable_sandbox |= PLATFORM == 'linux'
# Chrome process can't access file within sandbox
disable_sandbox |= self.options.nacl_exe_stdin is not None
disable_sandbox |= self.options.nacl_exe_stdout is not None
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment