Move needsPreviewElement to TimelineUIUtilsImple and make it private

Drive-by: removed formatter for counters field which is not in the protocol anymore.

BUG=361045
R=loislo@chromium.org

Review URL: https://codereview.chromium.org/343613004

git-svn-id: svn://svn.chromium.org/blink/trunk@176495 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

@@ -13,7 +13,6 @@ InspectorTest.timelinePropertyFormatters = {
     usedHeapSizeDelta: "skip",
     mimeType: "formatAsTypeName",
     id: "formatAsTypeName",
-    counters: "formatAsTypeName",
     timerId: "formatAsTypeName",
     scriptLine: "formatAsTypeName",
     layerId: "formatAsTypeName",

third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

@@ -212,26 +212,6 @@ WebInspector.TimelineUIUtils.recordStyle = function(record)
     return result;
 }
 
-/**
- * @param {string=} recordType
- * @return {boolean}
- */
-WebInspector.TimelineUIUtils.needsPreviewElement = function(recordType)
-{
-    if (!recordType)
-        return false;
-    const recordTypes = WebInspector.TimelineModel.RecordType;
-    switch (recordType) {
-    case recordTypes.ResourceSendRequest:
-    case recordTypes.ResourceReceiveResponse:
-    case recordTypes.ResourceReceivedData:
-    case recordTypes.ResourceFinish:
-        return true;
-    default:
-        return false;
-    }
-}
-
 /**
  * @param {!WebInspector.TimelineModel} model
  * @param {!{name: string, tasks: !Array.<!{startTime: number, endTime: number}>, firstTaskIndex: number, lastTaskIndex: number}} info

third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js

@@ -265,6 +265,26 @@ WebInspector.TimelineUIUtilsImpl.buildDetailsNode = function(record, linkifier,
     }
 }
 
+/**
+ * @param {string=} recordType
+ * @return {boolean}
+ */
+WebInspector.TimelineUIUtilsImpl._needsPreviewElement = function(recordType)
+{
+    if (!recordType)
+        return false;
+    const recordTypes = WebInspector.TimelineModel.RecordType;
+    switch (recordType) {
+    case recordTypes.ResourceSendRequest:
+    case recordTypes.ResourceReceiveResponse:
+    case recordTypes.ResourceReceivedData:
+    case recordTypes.ResourceFinish:
+        return true;
+    default:
+        return false;
+    }
+}
+
 /**
  * @param {!WebInspector.TimelineModel.Record} record
  * @param {!WebInspector.TimelineModel} model
@@ -278,7 +298,7 @@ WebInspector.TimelineUIUtilsImpl.generateDetailsContent = function(record, model
     var relatedNode = null;
     var recordData = record.data();
     var barrier = new CallbackBarrier();
-    if (!imageElement && WebInspector.TimelineUIUtils.needsPreviewElement(record.type()))
+    if (!imageElement && WebInspector.TimelineUIUtilsImpl._needsPreviewElement(record.type()))
         WebInspector.DOMPresentationUtils.buildImagePreviewContents(record.target(), recordData["url"], false, barrier.createCallback(saveImage));
     if (recordData["backendNodeId"])
         record.target().domModel.pushNodesByBackendIdsToFrontend([recordData["backendNodeId"]], barrier.createCallback(setRelatedNode));