Commit ae885bc1 authored by Darwin Huang's avatar Darwin Huang Committed by Commit Bot

Clipboard: Update links and comments

Update some now-obsolete links and update comment style

Change-Id: Ie98f57284c21c2a420c8c11d33d140df5fbfee8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576220
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: default avatarVictor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652761}
parent 6cb4fd14
......@@ -305,8 +305,8 @@ DataObject* DataObject::Create(WebDragData data) {
// This should never happen when dragging in.
break;
case WebDragData::Item::kStorageTypeFileSystemFile: {
// FIXME: The file system URL may refer a user visible file, see
// http://crbug.com/429077
// TODO(http://crbug.com/429077): The file system URL may refer a user
// visible file.
has_file_system = true;
FileMetadata file_metadata;
file_metadata.length = item.file_system_file_size;
......@@ -363,8 +363,8 @@ WebDragData DataObject::ToWebDragData() {
item.file_system_file_size = file->size();
item.file_system_id = original_item->FileSystemId();
} else {
// FIXME: support dragging constructed Files across renderers, see
// http://crbug.com/394955
// TODO(http://crbug.com/394955): support dragging constructed Files
// across renderers.
item.storage_type = WebDragData::Item::kStorageTypeString;
item.string_type = "text/plain";
item.string_data = file->name();
......
......@@ -74,7 +74,7 @@ class CORE_EXPORT DataObject : public GarbageCollectedFinalized<DataObject>,
// DataTransferItemList support.
uint32_t length() const;
DataObjectItem* Item(uint32_t index);
// FIXME: Implement V8DataTransferItemList::indexedPropertyDeleter to get this
// TODO: Implement V8DataTransferItemList::indexedPropertyDeleter to get this
// called.
void DeleteItem(uint32_t index);
void ClearAll();
......
......@@ -127,7 +127,7 @@ File* DataObjectItem::GetAsFile() const {
if (file_)
return file_.Get();
DCHECK(shared_buffer_);
// FIXME: This code is currently impossible--we never populate
// TODO: This code is currently impossible--we never populate
// |shared_buffer_| when dragging in. At some point though, we may need to
// support correctly converting a shared buffer into a file.
return nullptr;
......@@ -180,7 +180,7 @@ String DataObjectItem::GetAsString() const {
}
bool DataObjectItem::IsFilename() const {
// FIXME: https://bugs.webkit.org/show_bug.cgi?id=81261: When we properly
// TODO(https://bugs.webkit.org/show_bug.cgi?id=81261): When we properly
// support File dragout, we'll need to make sure this works as expected for
// DragDataChromium.
return kind_ == kFileKind && file_;
......
......@@ -159,7 +159,7 @@ class DraggedNodeImageBuilder {
} // namespace
static DragOperation ConvertEffectAllowedToDragOperation(const String& op) {
// Values specified in
// http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#dom-datatransfer-effectallowed
// https://html.spec.whatwg.org/multipage/dnd.html#dom-datatransfer-effectallowed
if (op == "uninitialized")
return kDragOperationEvery;
if (op == "none")
......@@ -597,7 +597,7 @@ bool DataTransfer::HasDropZoneType(const String& keyword) {
}
DataTransferItemList* DataTransfer::items() {
// FIXME: According to the spec, we are supposed to return the same collection
// TODO: According to the spec, we are supposed to return the same collection
// of items each time. We now return a wrapper that always wraps the *same*
// set of items, so JS shouldn't be able to tell, but we probably still want
// to fix this.
......
......@@ -50,9 +50,9 @@ enum class DataTransferAccessPolicy;
// Used for drag and drop and copy/paste.
// Drag and Drop:
// http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html
// https://html.spec.whatwg.org/multipage/dnd.html
// Clipboard API (copy/paste):
// http://dev.w3.org/2006/webapi/clipops/clipops.html
// https://w3c.github.io/clipboard-apis/
class CORE_EXPORT DataTransfer final : public ScriptWrappable,
public DataObject::Observer {
USING_GARBAGE_COLLECTED_MIXIN(DataTransfer);
......
......@@ -248,7 +248,7 @@ bool SystemClipboard::IsValidBufferType(mojom::ClipboardBuffer buffer) {
#else
// Chrome OS and non-X11 unix builds do not support
// the X selection clipboard.
// TODO: remove the need for this case, see http://crbug.com/361753
// TODO(http://crbug.com/361753): remove the need for this case.
return false;
#endif
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment