Commit aeab6180 authored by jdoerrie's avatar jdoerrie Committed by Commit Bot

[Passwords] Rename Google Password Manager Feature Flag

This change renames the already existing feature flag from
kManagePasswordsAlternativeUIAndroid to kGooglePasswordManager to better
reflect that the flag is platform agnostic.

Bug: 904821
Change-Id: I5c7f0e529de53230578b0a25115b6d3428bbf940
Reviewed-on: https://chromium-review.googlesource.com/c/1333651Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607696}
parent caca9998
...@@ -170,9 +170,9 @@ const base::Feature* kFeaturesExposedToJava[] = { ...@@ -170,9 +170,9 @@ const base::Feature* kFeaturesExposedToJava[] = {
&omnibox::kHideSteadyStateUrlScheme, &omnibox::kHideSteadyStateUrlScheme,
&omnibox::kHideSteadyStateUrlTrivialSubdomains, &omnibox::kHideSteadyStateUrlTrivialSubdomains,
&omnibox::kQueryInOmnibox, &omnibox::kQueryInOmnibox,
&password_manager::features::kGooglePasswordManager,
&password_manager::features::kPasswordSearchMobile, &password_manager::features::kPasswordSearchMobile,
&password_manager::features::kPasswordsKeyboardAccessory, &password_manager::features::kPasswordsKeyboardAccessory,
&password_manager::features::kManagePasswordsAlternativeUIAndroid,
&translate::kTranslateAndroidManualTrigger, &translate::kTranslateAndroidManualTrigger,
&unified_consent::kUnifiedConsent, &unified_consent::kUnifiedConsent,
&subresource_filter::kSafeBrowsingSubresourceFilter, &subresource_filter::kSafeBrowsingSubresourceFilter,
......
...@@ -28,10 +28,6 @@ const base::Feature kDeleteCorruptedPasswords = { ...@@ -28,10 +28,6 @@ const base::Feature kDeleteCorruptedPasswords = {
const base::Feature kHtmlBasedUsernameDetector = { const base::Feature kHtmlBasedUsernameDetector = {
"HtmlBaseUsernameDetector", base::FEATURE_ENABLED_BY_DEFAULT}; "HtmlBaseUsernameDetector", base::FEATURE_ENABLED_BY_DEFAULT};
// Replace Chrome > Settings > Passwords with the new PWM UI on Android.
const base::Feature kManagePasswordsAlternativeUIAndroid = {
"ManagePasswordsAlternativeUIAndroid", base::FEATURE_DISABLED_BY_DEFAULT};
// Controls whether password requirements can be overridden for domains // Controls whether password requirements can be overridden for domains
// (as opposed to only relying on the autofill server). // (as opposed to only relying on the autofill server).
const base::Feature kPasswordGenerationRequirementsDomainOverrides = { const base::Feature kPasswordGenerationRequirementsDomainOverrides = {
...@@ -69,6 +65,10 @@ const base::Feature kRecoverPasswordsForSyncUsers = { ...@@ -69,6 +65,10 @@ const base::Feature kRecoverPasswordsForSyncUsers = {
const base::Feature kFillOnAccountSelect = {"fill-on-account-select", const base::Feature kFillOnAccountSelect = {"fill-on-account-select",
base::FEATURE_DISABLED_BY_DEFAULT}; base::FEATURE_DISABLED_BY_DEFAULT};
// Integration with Google's Password Manager for signed-in and sync users.
const base::Feature kGooglePasswordManager = {
"google-password-manager", base::FEATURE_DISABLED_BY_DEFAULT};
// Enables new password form parsing mechanism for filling passwords, details in // Enables new password form parsing mechanism for filling passwords, details in
// https://goo.gl/QodPH1 // https://goo.gl/QodPH1
const base::Feature kNewPasswordFormParsing = { const base::Feature kNewPasswordFormParsing = {
......
...@@ -23,7 +23,7 @@ extern const base::Feature kDeleteCorruptedPasswords; ...@@ -23,7 +23,7 @@ extern const base::Feature kDeleteCorruptedPasswords;
extern const base::Feature kHtmlBasedUsernameDetector; extern const base::Feature kHtmlBasedUsernameDetector;
extern const base::Feature kPasswordGenerationRequirementsDomainOverrides; extern const base::Feature kPasswordGenerationRequirementsDomainOverrides;
extern const base::Feature kFillOnAccountSelect; extern const base::Feature kFillOnAccountSelect;
extern const base::Feature kManagePasswordsAlternativeUIAndroid; extern const base::Feature kGooglePasswordManager;
extern const base::Feature kMigrateLinuxToLoginDB; extern const base::Feature kMigrateLinuxToLoginDB;
extern const base::Feature kNewPasswordFormParsing; extern const base::Feature kNewPasswordFormParsing;
extern const base::Feature kNewPasswordFormParsingForSaving; extern const base::Feature kNewPasswordFormParsingForSaving;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment