Commit aebf828f authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Remove SetUp() test functions that just call SetUp().

TBR=jianli@chromium.org,piman@chromium.org,rdevlin.cronin@chromium.org

Change-Id: I4a2871883bd28d525b960e89362545af57681c18
Reviewed-on: https://chromium-review.googlesource.com/c/1337375Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Reviewed-by: default avatarDan Erat <derat@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608975}
parent 60d72c0b
...@@ -220,17 +220,7 @@ TEST_F(AppListModelTest, AppOrder) { ...@@ -220,17 +220,7 @@ TEST_F(AppListModelTest, AppOrder) {
} }
} }
class AppListModelFolderTest : public AppListModelTest { using AppListModelFolderTest = AppListModelTest;
public:
AppListModelFolderTest() {}
~AppListModelFolderTest() override {}
// testing::Test overrides:
void SetUp() override { AppListModelTest::SetUp(); }
private:
DISALLOW_COPY_AND_ASSIGN(AppListModelFolderTest);
};
TEST_F(AppListModelFolderTest, FolderItem) { TEST_F(AppListModelFolderTest, FolderItem) {
AppListFolderItem* folder = new AppListFolderItem("folder1"); AppListFolderItem* folder = new AppListFolderItem("folder1");
......
...@@ -16,16 +16,7 @@ namespace ash { ...@@ -16,16 +16,7 @@ namespace ash {
namespace assistant { namespace assistant {
namespace util { namespace util {
class DeepLinkUnitTest : public AshTestBase { using DeepLinkUnitTest = AshTestBase;
protected:
DeepLinkUnitTest() = default;
~DeepLinkUnitTest() override = default;
void SetUp() override { AshTestBase::SetUp(); }
private:
DISALLOW_COPY_AND_ASSIGN(DeepLinkUnitTest);
};
TEST_F(DeepLinkUnitTest, CreateAssistantSettingsDeepLink) { TEST_F(DeepLinkUnitTest, CreateAssistantSettingsDeepLink) {
ASSERT_EQ(GURL("googleassistant://settings"), ASSERT_EQ(GURL("googleassistant://settings"),
......
...@@ -19,8 +19,6 @@ namespace ash { ...@@ -19,8 +19,6 @@ namespace ash {
class DragDropTrackerTest : public AshTestBase { class DragDropTrackerTest : public AshTestBase {
public: public:
void SetUp() override { AshTestBase::SetUp(); }
aura::Window* CreateTestWindow(const gfx::Rect& bounds) { aura::Window* CreateTestWindow(const gfx::Rect& bounds) {
static int window_id = 0; static int window_id = 0;
return CreateTestWindowInShellWithDelegate( return CreateTestWindowInShellWithDelegate(
...@@ -174,4 +172,4 @@ TEST_F(DragDropTrackerTest, ConvertEvent) { ...@@ -174,4 +172,4 @@ TEST_F(DragDropTrackerTest, ConvertEvent) {
EXPECT_EQ(original11.flags(), converted11->flags()); EXPECT_EQ(original11.flags(), converted11->flags());
} }
} // namespace aura } // namespace ash
...@@ -349,8 +349,6 @@ TEST_F(CrostiniManagerTest, InstallLinuxPackageSignalFailure) { ...@@ -349,8 +349,6 @@ TEST_F(CrostiniManagerTest, InstallLinuxPackageSignalFailure) {
class CrostiniManagerRestartTest : public CrostiniManagerTest, class CrostiniManagerRestartTest : public CrostiniManagerTest,
public CrostiniManager::RestartObserver { public CrostiniManager::RestartObserver {
public: public:
void SetUp() override { CrostiniManagerTest::SetUp(); }
void RestartCrostiniCallback(base::OnceClosure closure, void RestartCrostiniCallback(base::OnceClosure closure,
CrostiniResult result) { CrostiniResult result) {
restart_crostini_callback_count_++; restart_crostini_callback_count_++;
......
...@@ -2436,8 +2436,6 @@ TEST_F(NetErrorHelperCoreAutoReloadTest, ManualReloadShowsError) { ...@@ -2436,8 +2436,6 @@ TEST_F(NetErrorHelperCoreAutoReloadTest, ManualReloadShowsError) {
class NetErrorHelperCoreHistogramTest class NetErrorHelperCoreHistogramTest
: public NetErrorHelperCoreAutoReloadTest { : public NetErrorHelperCoreAutoReloadTest {
public: public:
void SetUp() override { NetErrorHelperCoreAutoReloadTest::SetUp(); }
static const char kCountAtStop[]; static const char kCountAtStop[];
static const char kErrorAtStop[]; static const char kErrorAtStop[];
static const char kCountAtSuccess[]; static const char kCountAtSuccess[];
......
...@@ -107,8 +107,6 @@ class TranslateScriptBrowserTest : public ChromeRenderViewTest { ...@@ -107,8 +107,6 @@ class TranslateScriptBrowserTest : public ChromeRenderViewTest {
} }
private: private:
void SetUp() override { ChromeRenderViewTest::SetUp(); }
double ExecuteScriptAndGetNumberResult(const std::string& script) { double ExecuteScriptAndGetNumberResult(const std::string& script) {
WebScriptSource source = WebScriptSource source =
WebScriptSource(blink::WebString::FromASCII(script)); WebScriptSource(blink::WebString::FromASCII(script));
......
...@@ -33,8 +33,6 @@ class MarkOperationDoneTaskTest : public PrefetchTaskTestBase { ...@@ -33,8 +33,6 @@ class MarkOperationDoneTaskTest : public PrefetchTaskTestBase {
MarkOperationDoneTaskTest() = default; MarkOperationDoneTaskTest() = default;
~MarkOperationDoneTaskTest() override = default; ~MarkOperationDoneTaskTest() override = default;
void SetUp() override { PrefetchTaskTestBase::SetUp(); }
int64_t InsertAwaitingGCMOperation(std::string name) { int64_t InsertAwaitingGCMOperation(std::string name) {
return InsertPrefetchItemInStateWithOperation( return InsertPrefetchItemInStateWithOperation(
name, PrefetchItemState::AWAITING_GCM); name, PrefetchItemState::AWAITING_GCM);
......
...@@ -292,8 +292,6 @@ class MAYBE_PrintRenderFrameHelperTest : public PrintRenderFrameHelperTestBase { ...@@ -292,8 +292,6 @@ class MAYBE_PrintRenderFrameHelperTest : public PrintRenderFrameHelperTestBase {
MAYBE_PrintRenderFrameHelperTest() {} MAYBE_PrintRenderFrameHelperTest() {}
~MAYBE_PrintRenderFrameHelperTest() override {} ~MAYBE_PrintRenderFrameHelperTest() override {}
void SetUp() override { PrintRenderFrameHelperTestBase::SetUp(); }
private: private:
DISALLOW_COPY_AND_ASSIGN(MAYBE_PrintRenderFrameHelperTest); DISALLOW_COPY_AND_ASSIGN(MAYBE_PrintRenderFrameHelperTest);
}; };
......
...@@ -7,10 +7,7 @@ ...@@ -7,10 +7,7 @@
namespace content { namespace content {
class BlinkPlatformAudioHardwareTest : public RenderViewTest { using BlinkPlatformAudioHardwareTest = RenderViewTest;
protected:
void SetUp() override { RenderViewTest::SetUp(); }
};
// Test that calling audioHardware functions from blink::Platform without a v8 // Test that calling audioHardware functions from blink::Platform without a v8
// context returns valid values. // context returns valid values.
......
...@@ -27,8 +27,6 @@ class ErrorMapUnitTest : public testing::Test { ...@@ -27,8 +27,6 @@ class ErrorMapUnitTest : public testing::Test {
ErrorMapUnitTest() { } ErrorMapUnitTest() { }
~ErrorMapUnitTest() override {} ~ErrorMapUnitTest() override {}
void SetUp() override { testing::Test::SetUp(); }
protected: protected:
ErrorMap errors_; ErrorMap errors_;
}; };
......
...@@ -53,8 +53,6 @@ class PassthroughProgramCacheTest : public GpuServiceTest, ...@@ -53,8 +53,6 @@ class PassthroughProgramCacheTest : public GpuServiceTest,
int32_t blob_count() { return blob_count_; } int32_t blob_count() { return blob_count_; }
protected: protected:
void SetUp() override { GpuServiceTest::SetUp(); }
std::string MakeKey(size_t len, uint8_t start_byte) { std::string MakeKey(size_t len, uint8_t start_byte) {
std::string binary_key(len, '.'); std::string binary_key(len, '.');
......
...@@ -23,9 +23,6 @@ class NinePieceImageGridTest : public RenderingTest { ...@@ -23,9 +23,6 @@ class NinePieceImageGridTest : public RenderingTest {
nullptr, nullptr, nullptr, nullptr, nullptr, cssvalue::kRepeating); nullptr, nullptr, nullptr, nullptr, nullptr, cssvalue::kRepeating);
return StyleGeneratedImage::Create(*gradient); return StyleGeneratedImage::Create(*gradient);
} }
private:
void SetUp() override { RenderingTest::SetUp(); }
}; };
TEST_F(NinePieceImageGridTest, NinePieceImagePainting_NoDrawables) { TEST_F(NinePieceImageGridTest, NinePieceImagePainting_NoDrawables) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment