Commit af00649c authored by dcheng@chromium.org's avatar dcheng@chromium.org

base::Bind() conversion for chrome/browser/rlz

BUG=none
TEST=trybot runs


Review URL: http://codereview.chromium.org/8570021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110841 0039d316-1c4b-4281-b951-d872f2087c98
parent b5d58d94
...@@ -13,12 +13,13 @@ ...@@ -13,12 +13,13 @@
#include <algorithm> #include <algorithm>
#include "base/bind.h"
#include "base/bind_helpers.h"
#include "base/file_path.h" #include "base/file_path.h"
#include "base/message_loop.h" #include "base/message_loop.h"
#include "base/path_service.h" #include "base/path_service.h"
#include "base/string_util.h" #include "base/string_util.h"
#include "base/synchronization/lock.h" #include "base/synchronization/lock.h"
#include "base/task.h"
#include "base/threading/thread.h" #include "base/threading/thread.h"
#include "base/threading/thread_restrictions.h" #include "base/threading/thread_restrictions.h"
#include "base/utf_string_conversions.h" #include "base/utf_string_conversions.h"
...@@ -198,10 +199,12 @@ bool RLZTracker::Init(bool first_run, int delay, bool google_default_search, ...@@ -198,10 +199,12 @@ bool RLZTracker::Init(bool first_run, int delay, bool google_default_search,
} }
void RLZTracker::ScheduleDelayedInit(int delay) { void RLZTracker::ScheduleDelayedInit(int delay) {
// The RLZTracker is a singleton object that outlives any runnable tasks
// that will be queued up.
BrowserThread::PostDelayedTask( BrowserThread::PostDelayedTask(
BrowserThread::FILE, BrowserThread::FILE,
FROM_HERE, FROM_HERE,
NewRunnableMethod(this, &RLZTracker::DelayedInit), base::Bind(&RLZTracker::DelayedInit, base::Unretained(this)),
delay); delay);
} }
...@@ -391,7 +394,8 @@ bool RLZTracker::ScheduleGetAccessPointRlz(rlz_lib::AccessPoint point) { ...@@ -391,7 +394,8 @@ bool RLZTracker::ScheduleGetAccessPointRlz(rlz_lib::AccessPoint point) {
string16* not_used = NULL; string16* not_used = NULL;
BrowserThread::PostTask( BrowserThread::PostTask(
BrowserThread::FILE, FROM_HERE, BrowserThread::FILE, FROM_HERE,
NewRunnableFunction(&RLZTracker::GetAccessPointRlz, point, not_used)); base::IgnoreReturn<bool>(
base::Bind(&RLZTracker::GetAccessPointRlz, point, not_used)));
return true; return true;
} }
......
...@@ -14,10 +14,8 @@ ...@@ -14,10 +14,8 @@
#include <string> #include <string>
#include "base/basictypes.h" #include "base/basictypes.h"
#include "base/memory/ref_counted.h"
#include "base/memory/singleton.h" #include "base/memory/singleton.h"
#include "base/string16.h" #include "base/string16.h"
#include "base/task.h"
#include "content/public/browser/notification_observer.h" #include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h" #include "content/public/browser/notification_registrar.h"
#include "rlz/win/lib/rlz_lib.h" #include "rlz/win/lib/rlz_lib.h"
...@@ -150,10 +148,6 @@ class RLZTracker : public content::NotificationObserver { ...@@ -150,10 +148,6 @@ class RLZTracker : public content::NotificationObserver {
DISALLOW_COPY_AND_ASSIGN(RLZTracker); DISALLOW_COPY_AND_ASSIGN(RLZTracker);
}; };
// The RLZTracker is a singleton object that outlives any runnable tasks
// that will be queued up.
DISABLE_RUNNABLE_METHOD_REFCOUNT(RLZTracker);
#endif // defined(OS_WIN) #endif // defined(OS_WIN)
#endif // CHROME_BROWSER_RLZ_RLZ_H_ #endif // CHROME_BROWSER_RLZ_RLZ_H_
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment