Commit af150f27 authored by Henrik Grunell's avatar Henrik Grunell Committed by Commit Bot

Revert "Setting dcheck_always_on for all chromium.webrtc.fyi bots."

This reverts commit c6e6fea4.

Reason for revert: Breaks WebRTC tests.

Original change's description:
> Setting dcheck_always_on for all chromium.webrtc.fyi bots.
> 
> We recently discovered DCHECK errors when WebRTC was rolling into
> Chromium, but they should have been caught by the chromium.webrtc.fyi
> waterfall.
> 
> Using dcheck_always_on in chromium.webrtc.fyi seems a good idea to
> reduce this kind of failures.
> 
> Bug: None
> Change-Id: Ibab78987f83cbacf2583c2a081b28082171c105b
> Reviewed-on: https://chromium-review.googlesource.com/1065733
> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Patrik Höglund <phoglund@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565580}

TBR=phoglund@chromium.org,dpranke@chromium.org,mbonadei@chromium.org

Change-Id: Ibf20c38a4e79ea5a21264bd5c6d09440044eb1c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/1092713Reviewed-by: default avatarHenrik Grunell <grunell@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565608}
parent bdb56ef8
......@@ -474,20 +474,20 @@
},
'chromium.webrtc': {
'Linux Builder': 'release_bot_chrome_with_codecs_dcheck_always_on',
'Mac Builder': 'release_bot_chrome_with_codecs_dcheck_always_on',
'Win Builder': 'release_bot_x86_minimal_symbols_no_com_init_hooks_with_codecs_dcheck_always_on',
'Linux Builder': 'release_bot_chrome_with_codecs',
'Mac Builder': 'release_bot_chrome_with_codecs',
'Win Builder': 'release_bot_x86_minimal_symbols_no_com_init_hooks_with_codecs',
},
'chromium.webrtc.fyi': {
'Android Builder': 'android_release_bot_minimal_symbols_dcheck_always_on',
'Android Builder': 'android_release_bot_minimal_symbols',
'Android Builder (dbg)': 'android_debug_static_bot',
'Android Builder ARM64 (dbg)': 'android_debug_static_bot_arm64',
'Linux Builder': 'release_bot_chrome_with_codecs_dcheck_always_on',
'Linux Builder': 'release_bot_chrome_with_codecs',
'Linux Builder (dbg)': 'debug_bot',
'Mac Builder': 'release_bot_chrome_with_codecs_dcheck_always_on',
'Mac Builder': 'release_bot_chrome_with_codecs',
'Mac Builder (dbg)': 'debug_bot',
'Win Builder': 'release_bot_x86_minimal_symbols_no_com_init_hooks_with_codecs_dcheck_always_on',
'Win Builder': 'release_bot_x86_minimal_symbols_no_com_init_hooks_with_codecs',
'Win Builder (dbg)': 'debug_bot_x86_minimal_symbols_no_com_init_hooks_with_codecs',
},
......@@ -923,11 +923,6 @@
'strip_debug_info',
],
'android_release_bot_minimal_symbols_dcheck_always_on': [
'android', 'release_bot', 'minimal_symbols',
'strip_debug_info', 'dcheck_always_on',
],
'android_clang_tot_release_minimal_symbols': [
'android', 'release', 'static', 'minimal_symbols',
'strip_debug_info', 'clang_tot',
......@@ -1257,7 +1252,7 @@
'debug_bot_x86_minimal_symbols': [ 'debug_bot', 'x86', 'minimal_symbols' ],
'debug_bot_x86_minimal_symbols_no_com_init_hooks_with_codecs': [
'debug_bot', 'x86', 'minimal_symbols', 'no_com_init_hooks', 'chrome_with_codecs',
'debug_bot', 'x86', 'minimal_symbols', 'no_com_init_hooks', 'chrome_with_codecs'
],
'debug_libfuzzer_asan': [
......@@ -1500,8 +1495,8 @@
'release_bot', 'arm64',
],
'release_bot_chrome_with_codecs_dcheck_always_on': [
'release_bot', 'chrome_with_codecs', 'dcheck_always_on',
'release_bot_chrome_with_codecs': [
'release_bot', 'chrome_with_codecs',
],
'release_bot_enable_blink_heap_verification_dcheck_always_on': [
......@@ -1554,9 +1549,8 @@
'release_bot', 'x86', 'minimal_symbols', 'enable_archive_compression'
],
'release_bot_x86_minimal_symbols_no_com_init_hooks_with_codecs_dcheck_always_on': [
'release_bot', 'x86', 'minimal_symbols', 'no_com_init_hooks', 'chrome_with_codecs',
'dcheck_always_on',
'release_bot_x86_minimal_symbols_no_com_init_hooks_with_codecs': [
'release_bot', 'x86', 'minimal_symbols', 'no_com_init_hooks', 'chrome_with_codecs'
],
'release_libfuzzer_asan': [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment