Commit afb00be0 authored by Alex Rudenko's avatar Alex Rudenko Committed by Commit Bot

Remove unused Dispose method from InspectTool

This CL removes InspectTool::Dispose method that was never
implemented by any of the tools.

Change-Id: I5c8c3dea03a0b98f6915f31120f66ab8760c3428
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417891Reviewed-by: default avatarAndrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808241}
parent 614a0bfb
...@@ -471,8 +471,6 @@ Response InspectorOverlayAgent::disable() { ...@@ -471,8 +471,6 @@ Response InspectorOverlayAgent::disable() {
resize_timer_active_ = false; resize_timer_active_ = false;
frame_overlay_.reset(); frame_overlay_.reset();
frame_resource_name_ = 0; frame_resource_name_ = 0;
if (persistent_tool_)
persistent_tool_->Dispose();
persistent_tool_ = nullptr; persistent_tool_ = nullptr;
PickTheRightTool(); PickTheRightTool();
SetNeedsUnbufferedInput(false); SetNeedsUnbufferedInput(false);
...@@ -722,8 +720,6 @@ Response InspectorOverlayAgent::highlightNode( ...@@ -722,8 +720,6 @@ Response InspectorOverlayAgent::highlightNode(
Response InspectorOverlayAgent::setShowGridOverlays( Response InspectorOverlayAgent::setShowGridOverlays(
std::unique_ptr<protocol::Array<protocol::Overlay::GridNodeHighlightConfig>> std::unique_ptr<protocol::Array<protocol::Overlay::GridNodeHighlightConfig>>
grid_node_highlight_configs) { grid_node_highlight_configs) {
if (persistent_tool_)
persistent_tool_->Dispose();
persistent_tool_ = nullptr; persistent_tool_ = nullptr;
if (grid_node_highlight_configs->size()) { if (grid_node_highlight_configs->size()) {
...@@ -1395,9 +1391,6 @@ void InspectorOverlayAgent::SetInspectTool(InspectTool* inspect_tool) { ...@@ -1395,9 +1391,6 @@ void InspectorOverlayAgent::SetInspectTool(InspectTool* inspect_tool) {
if (!view || !frame) if (!view || !frame)
return; return;
if (inspect_tool_ && inspect_tool_ != persistent_tool_)
inspect_tool_->Dispose();
if (inspect_tool && enabled_.Get()) { if (inspect_tool && enabled_.Get()) {
inspect_tool_ = inspect_tool; inspect_tool_ = inspect_tool;
// If the tool supports persistent overlays, the resources of the persistent // If the tool supports persistent overlays, the resources of the persistent
......
...@@ -99,7 +99,6 @@ class CORE_EXPORT InspectTool : public GarbageCollected<InspectTool> { ...@@ -99,7 +99,6 @@ class CORE_EXPORT InspectTool : public GarbageCollected<InspectTool> {
virtual void Draw(float scale) {} virtual void Draw(float scale) {}
virtual void Dispatch(const String& message) {} virtual void Dispatch(const String& message) {}
virtual void Trace(Visitor* visitor) const; virtual void Trace(Visitor* visitor) const;
virtual void Dispose() {}
virtual bool HideOnHideHighlight(); virtual bool HideOnHideHighlight();
virtual bool HideOnMouseMove(); virtual bool HideOnMouseMove();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment