Commit b0c24cd7 authored by Hans Wennborg's avatar Hans Wennborg Committed by Commit Bot

Remove/replace unnecessary logging.h includes in .cc files (ios)

CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved
to the much smaller headers check.h, check_op.h, and notreached.h,
respectively.

This CL updates .cc files to use those headers instead when
possible, with the purpose of saving compile time.

(Split out from https://crrev.com/c/2164525 which also has
notes on how the change was generated.)

Bug: 1031540
Change-Id: I7ddc52fb3cc2ecdf730bdac44603760ef885f9c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164530
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: default avatarMark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762786}
parent 583466dd
...@@ -4,7 +4,6 @@ ...@@ -4,7 +4,6 @@
#include "ios/chrome/browser/application_context.h" #include "ios/chrome/browser/application_context.h"
#include "base/logging.h"
namespace { namespace {
// Global ApplicationContext instance. // Global ApplicationContext instance.
......
...@@ -8,10 +8,10 @@ ...@@ -8,10 +8,10 @@
#include <vector> #include <vector>
#include "base/bind.h" #include "base/bind.h"
#include "base/check_op.h"
#include "base/command_line.h" #include "base/command_line.h"
#include "base/feature_list.h" #include "base/feature_list.h"
#include "base/files/file_path.h" #include "base/files/file_path.h"
#include "base/logging.h"
#include "base/macros.h" #include "base/macros.h"
#include "base/memory/ptr_util.h" #include "base/memory/ptr_util.h"
#include "base/path_service.h" #include "base/path_service.h"
......
...@@ -4,7 +4,6 @@ ...@@ -4,7 +4,6 @@
#include "ios/chrome/browser/bookmarks/bookmark_client_impl.h" #include "ios/chrome/browser/bookmarks/bookmark_client_impl.h"
#include "base/logging.h"
#include "base/metrics/user_metrics.h" #include "base/metrics/user_metrics.h"
#include "base/task/cancelable_task_tracker.h" #include "base/task/cancelable_task_tracker.h"
#include "components/bookmarks/browser/bookmark_node.h" #include "components/bookmarks/browser/bookmark_node.h"
......
...@@ -5,7 +5,8 @@ ...@@ -5,7 +5,8 @@
#include "ios/chrome/browser/bookmarks/bookmark_remover_helper.h" #include "ios/chrome/browser/bookmarks/bookmark_remover_helper.h"
#include "base/bind.h" #include "base/bind.h"
#include "base/logging.h" #include "base/check_op.h"
#include "base/notreached.h"
#include "base/threading/sequenced_task_runner_handle.h" #include "base/threading/sequenced_task_runner_handle.h"
#include "components/bookmarks/browser/bookmark_model.h" #include "components/bookmarks/browser/bookmark_model.h"
#include "ios/chrome/browser/bookmarks/bookmark_model_factory.h" #include "ios/chrome/browser/bookmarks/bookmark_model_factory.h"
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "ios/chrome/browser/bookmarks/bookmarks_utils.h" #include "ios/chrome/browser/bookmarks/bookmarks_utils.h"
#include "base/logging.h" #include "base/check.h"
#include "base/metrics/histogram_macros.h" #include "base/metrics/histogram_macros.h"
#include "base/stl_util.h" #include "base/stl_util.h"
#include "components/bookmarks/browser/bookmark_model.h" #include "components/bookmarks/browser/bookmark_model.h"
......
...@@ -6,8 +6,8 @@ ...@@ -6,8 +6,8 @@
#include <string> #include <string>
#include "base/check.h"
#include "base/feature_list.h" #include "base/feature_list.h"
#include "base/logging.h"
#include "base/stl_util.h" #include "base/stl_util.h"
#include "components/url_formatter/url_fixer.h" #include "components/url_formatter/url_fixer.h"
#include "ios/chrome/browser/chrome_url_constants.h" #include "ios/chrome/browser/chrome_url_constants.h"
......
...@@ -10,9 +10,10 @@ ...@@ -10,9 +10,10 @@
#include <memory> #include <memory>
#include <utility> #include <utility>
#include "base/check_op.h"
#include "base/i18n/case_conversion.h" #include "base/i18n/case_conversion.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h" #include "base/memory/ptr_util.h"
#include "base/notreached.h"
#include "base/values.h" #include "base/values.h"
#include "components/prefs/pref_registry_simple.h" #include "components/prefs/pref_registry_simple.h"
#include "components/prefs/scoped_user_pref_update.h" #include "components/prefs/scoped_user_pref_update.h"
......
...@@ -6,9 +6,9 @@ ...@@ -6,9 +6,9 @@
#include <utility> #include <utility>
#include "base/check.h"
#include "base/files/file_path.h" #include "base/files/file_path.h"
#include "base/files/file_util.h" #include "base/files/file_util.h"
#include "base/logging.h"
#include "base/sequenced_task_runner.h" #include "base/sequenced_task_runner.h"
#include "base/threading/thread_restrictions.h" #include "base/threading/thread_restrictions.h"
#include "components/bookmarks/browser/bookmark_model.h" #include "components/bookmarks/browser/bookmark_model.h"
......
...@@ -4,8 +4,8 @@ ...@@ -4,8 +4,8 @@
#include "ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_impl.h" #include "ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_impl.h"
#include "base/logging.h"
#include "base/metrics/histogram_functions.h" #include "base/metrics/histogram_functions.h"
#include "base/notreached.h"
#include "base/sequenced_task_runner.h" #include "base/sequenced_task_runner.h"
#include "base/task/post_task.h" #include "base/task/post_task.h"
#include "components/keyed_service/ios/browser_state_dependency_manager.h" #include "components/keyed_service/ios/browser_state_dependency_manager.h"
......
...@@ -6,7 +6,7 @@ ...@@ -6,7 +6,7 @@
#include "base/bind.h" #include "base/bind.h"
#include "base/callback.h" #include "base/callback.h"
#include "base/logging.h" #include "base/check_op.h"
#include "components/bookmarks/browser/bookmark_model.h" #include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/browser/model_loader.h" #include "components/bookmarks/browser/model_loader.h"
#include "components/history/core/browser/history_service.h" #include "components/history/core/browser/history_service.h"
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "ios/chrome/browser/overlays/overlay_callback_manager_impl.h" #include "ios/chrome/browser/overlays/overlay_callback_manager_impl.h"
#include "base/logging.h" #include "base/check.h"
OverlayCallbackManagerImpl::OverlayCallbackManagerImpl() = default; OverlayCallbackManagerImpl::OverlayCallbackManagerImpl() = default;
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "ios/chrome/browser/overlays/public/overlay_dispatch_callback.h" #include "ios/chrome/browser/overlays/public/overlay_dispatch_callback.h"
#include "base/logging.h" #include "base/check.h"
#include "ios/chrome/browser/overlays/public/overlay_response_support.h" #include "ios/chrome/browser/overlays/public/overlay_response_support.h"
OverlayDispatchCallback::OverlayDispatchCallback( OverlayDispatchCallback::OverlayDispatchCallback(
......
...@@ -4,7 +4,6 @@ ...@@ -4,7 +4,6 @@
#include "ios/chrome/browser/overlays/public/overlay_request_support.h" #include "ios/chrome/browser/overlays/public/overlay_request_support.h"
#include "base/logging.h"
#include "base/no_destructor.h" #include "base/no_destructor.h"
namespace { namespace {
......
...@@ -4,7 +4,6 @@ ...@@ -4,7 +4,6 @@
#include "ios/chrome/browser/overlays/public/overlay_response_support.h" #include "ios/chrome/browser/overlays/public/overlay_response_support.h"
#include "base/logging.h"
#include "base/no_destructor.h" #include "base/no_destructor.h"
namespace { namespace {
......
...@@ -6,7 +6,7 @@ ...@@ -6,7 +6,7 @@
#include "base/bind.h" #include "base/bind.h"
#include "base/callback.h" #include "base/callback.h"
#include "base/logging.h" #include "base/check.h"
#include "ios/chrome/browser/overlays/public/overlay_callback_manager.h" #include "ios/chrome/browser/overlays/public/overlay_callback_manager.h"
#include "ios/chrome/browser/overlays/public/overlay_dispatch_callback.h" #include "ios/chrome/browser/overlays/public/overlay_dispatch_callback.h"
#include "ios/chrome/browser/overlays/public/overlay_response_support.h" #include "ios/chrome/browser/overlays/public/overlay_response_support.h"
......
...@@ -7,8 +7,8 @@ ...@@ -7,8 +7,8 @@
#include <vector> #include <vector>
#include "base/bind.h" #include "base/bind.h"
#include "base/check.h"
#include "base/feature_list.h" #include "base/feature_list.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h" #include "base/memory/ptr_util.h"
#include "base/metrics/histogram_macros.h" #include "base/metrics/histogram_macros.h"
#include "components/policy/core/browser/browser_policy_connector.h" #include "components/policy/core/browser/browser_policy_connector.h"
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "ios/chrome/browser/reading_list/offline_url_utils.h" #include "ios/chrome/browser/reading_list/offline_url_utils.h"
#include "base/logging.h" #include "base/check.h"
#include "base/strings/string_util.h" #include "base/strings/string_util.h"
#include "base/strings/stringprintf.h" #include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h" #include "base/strings/utf_string_conversions.h"
......
...@@ -5,8 +5,9 @@ ...@@ -5,8 +5,9 @@
#include "ios/chrome/browser/rlz/rlz_tracker_delegate_impl.h" #include "ios/chrome/browser/rlz/rlz_tracker_delegate_impl.h"
#include "base/bind.h" #include "base/bind.h"
#include "base/check.h"
#include "base/command_line.h" #include "base/command_line.h"
#include "base/logging.h" #include "base/notreached.h"
#include "components/omnibox/browser/omnibox_event_global_tracker.h" #include "components/omnibox/browser/omnibox_event_global_tracker.h"
#include "components/omnibox/browser/omnibox_log.h" #include "components/omnibox/browser/omnibox_log.h"
#include "components/search_engines/template_url.h" #include "components/search_engines/template_url.h"
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "ios/chrome/browser/search_engines/template_url_service_client_impl.h" #include "ios/chrome/browser/search_engines/template_url_service_client_impl.h"
#include "base/logging.h" #include "base/check_op.h"
#include "base/time/time.h" #include "base/time/time.h"
#include "components/history/core/browser/history_service.h" #include "components/history/core/browser/history_service.h"
#include "components/history/core/browser/history_types.h" #include "components/history/core/browser/history_types.h"
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "ios/chrome/browser/search_engines/ui_thread_search_terms_data.h" #include "ios/chrome/browser/search_engines/ui_thread_search_terms_data.h"
#include "base/logging.h" #include "base/check.h"
#include "base/strings/string16.h" #include "base/strings/string16.h"
#include "components/google/core/common/google_util.h" #include "components/google/core/common/google_util.h"
#include "components/omnibox/browser/omnibox_field_trial.h" #include "components/omnibox/browser/omnibox_field_trial.h"
......
...@@ -4,7 +4,9 @@ ...@@ -4,7 +4,9 @@
#include "ios/chrome/browser/ui/badges/badge_type_util.h" #include "ios/chrome/browser/ui/badges/badge_type_util.h"
#include "base/logging.h" #include <ostream>
#include "base/notreached.h"
BadgeType BadgeTypeForInfobarType(InfobarType infobar_type) { BadgeType BadgeTypeForInfobarType(InfobarType infobar_type) {
switch (infobar_type) { switch (infobar_type) {
......
...@@ -6,8 +6,8 @@ ...@@ -6,8 +6,8 @@
#include "base/bind.h" #include "base/bind.h"
#include "base/bind_helpers.h" #include "base/bind_helpers.h"
#include "base/check.h"
#include "base/files/file_path.h" #include "base/files/file_path.h"
#include "base/logging.h"
#include "base/no_destructor.h" #include "base/no_destructor.h"
#include "base/task/post_task.h" #include "base/task/post_task.h"
#include "components/autofill/core/browser/webdata/autofill_webdata_service.h" #include "components/autofill/core/browser/webdata/autofill_webdata_service.h"
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "ios/chrome/common/x_callback_url.h" #include "ios/chrome/common/x_callback_url.h"
#include "base/logging.h" #include "base/check.h"
#include "base/strings/string_util.h" #include "base/strings/string_util.h"
#include "base/strings/stringprintf.h" #include "base/strings/stringprintf.h"
#include "net/base/escape.h" #include "net/base/escape.h"
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "ios/net/chunked_data_stream_uploader.h" #include "ios/net/chunked_data_stream_uploader.h"
#include "base/logging.h" #include "base/check_op.h"
#include "net/base/io_buffer.h" #include "net/base/io_buffer.h"
#include "net/base/net_errors.h" #include "net/base/net_errors.h"
......
...@@ -6,7 +6,6 @@ ...@@ -6,7 +6,6 @@
#include <algorithm> #include <algorithm>
#include "base/logging.h"
#include "net/cookies/cookie_options.h" #include "net/cookies/cookie_options.h"
namespace net { namespace net {
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "ios/web/common/referrer_util.h" #include "ios/web/common/referrer_util.h"
#include "base/logging.h" #include "base/notreached.h"
#include "ios/web/public/navigation/referrer.h" #include "ios/web/public/navigation/referrer.h"
#include "url/gurl.h" #include "url/gurl.h"
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "ios/web/history_state_util.h" #include "ios/web/history_state_util.h"
#include "base/logging.h" #include "base/check.h"
#include "url/gurl.h" #include "url/gurl.h"
namespace web { namespace web {
......
...@@ -4,7 +4,6 @@ ...@@ -4,7 +4,6 @@
#include "ios/web/public/security/cert_policy.h" #include "ios/web/public/security/cert_policy.h"
#include "base/logging.h"
#include "net/cert/x509_certificate.h" #include "net/cert/x509_certificate.h"
namespace web { namespace web {
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "ios/web/public/security/certificate_policy_cache.h" #include "ios/web/public/security/certificate_policy_cache.h"
#include "base/logging.h" #include "base/check_op.h"
#include "ios/web/public/thread/web_thread.h" #include "ios/web/public/thread/web_thread.h"
namespace web { namespace web {
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "ios/web/public/webui/web_ui_ios_message_handler.h" #include "ios/web/public/webui/web_ui_ios_message_handler.h"
#include "base/logging.h" #include "base/notreached.h"
#include "base/strings/string_number_conversions.h" #include "base/strings/string_number_conversions.h"
#include "base/strings/utf_string_conversions.h" #include "base/strings/utf_string_conversions.h"
#include "base/values.h" #include "base/values.h"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment