[LayoutNG] Fix paint invalidation of LayoutText

Root cause of missing invalidations:
LayoutObject::AdjustStyleDifference was not marking LayoutText with NG rendering
as NeedPaintInvalidation. This caused invalidation not to propagate to document.
It was not marked because
LayoutObject:1789 ToLayoutText(this)->HasTextBoxes() always returned false for NG.

The fix was to make HasTextBoxes() NG-aware. This caused 2 callers
of HasTextBoxes() to behave incorrectly. Created HasLegacyTextBoxes(),
and added a TODO to remove them.

Bug: 819372
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: If2c4ddc0c9c707d11bb9115ef26ac578387c8359
Reviewed-on: https://chromium-review.googlesource.com/961526
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543885}

third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG

@@ -114,6 +114,7 @@ crbug.com/591099 compositing/geometry/foreground-layer.html [ Failure ]
 crbug.com/591099 compositing/geometry/repaint-foreground-layer.html [ Failure ]
 crbug.com/591099 compositing/geometry/video-opacity-overlay.html [ Failure ]
 crbug.com/714962 compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner.html [ Failure ]
+crbug.com/714962 compositing/gestures/gesture-tapHighlight-on-promoted-overflow-div-scrolled.html [ Failure ]
 crbug.com/714962 compositing/gestures/gesture-tapHighlight-simple-multi-line.html [ Pass ]
 crbug.com/714962 compositing/gestures/gesture-tapHighlight-with-squashing.html [ Pass ]
 crbug.com/591099 compositing/iframes/floating-self-painting-frame.html [ Failure ]
@@ -265,14 +266,13 @@ crbug.com/591099 editing/selection/dont-select-text-overflow-ellipsis-when-wrapp
 crbug.com/591099 editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed.html [ Failure ]
 crbug.com/591099 editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl.html [ Failure ]
 crbug.com/591099 editing/selection/dont-select-text-overflow-ellipsis-when-wrapping.html [ Failure ]
-crbug.com/591099 editing/selection/doubleclick-beside-cr-span.html [ Timeout ]
+crbug.com/591099 editing/selection/doubleclick-beside-cr-span.html [ Failure Timeout ]
 crbug.com/591099 editing/selection/drag-in-iframe.html [ Failure ]
 crbug.com/591099 editing/selection/expanding-selections.html [ Failure ]
 crbug.com/591099 editing/selection/expanding-selections2.html [ Failure ]
 crbug.com/591099 editing/selection/extend-by-sentence-001.html [ Failure ]
 crbug.com/591099 editing/selection/extend-inside-transforms-backward.html [ Failure ]
 crbug.com/591099 editing/selection/extend-inside-transforms-forward.html [ Failure ]
-crbug.com/714962 editing/selection/extend-selection-after-double-click.html [ Failure ]
 crbug.com/591099 editing/selection/extend-selection-bidi.html [ Failure ]
 crbug.com/591099 editing/selection/focus-body.html [ Failure ]
 crbug.com/591099 editing/selection/home-end.html [ Timeout ]
@@ -287,9 +287,6 @@ crbug.com/591099 editing/selection/modify_extend/extend_by_character.html [ Fail
 crbug.com/714962 editing/selection/modify_extend/extend_forward_line_crash.html [ Failure ]
 crbug.com/714962 editing/selection/modify_move/move-by-paragraph.html [ Failure ]
 crbug.com/714962 editing/selection/modify_move/move-forward-after-line-break.html [ Failure ]
-crbug.com/591099 editing/selection/modify_move/move_by_sentence_boundary.html [ Failure ]
-crbug.com/714962 editing/selection/modify_move/move_by_word_with_underscore.html [ Failure ]
-crbug.com/591099 editing/selection/mouse/extend_by_word_with_base_is_end.html [ Failure ]
 crbug.com/591099 editing/selection/move-3875618-fix.html [ Failure ]
 crbug.com/591099 editing/selection/move-3875641-fix.html [ Failure ]
 crbug.com/591099 editing/selection/move-by-line-002.html [ Failure ]
@@ -311,7 +308,6 @@ crbug.com/591099 editing/selection/select-text-overflow-ellipsis-mixed-in-rtl.ht
 crbug.com/591099 editing/selection/select-text-overflow-ellipsis.html [ Failure ]
 crbug.com/591099 editing/selection/selection-button-text.html [ Failure ]
 crbug.com/591099 editing/selection/shift-click.html [ Failure ]
-crbug.com/714962 editing/selection/skip-over-contenteditable.html [ Failure ]
 crbug.com/591099 editing/selection/transformed-selection-rects.html [ Failure ]
 crbug.com/591099 editing/selection/triple-click-in-pre.html [ Failure ]
 crbug.com/591099 editing/selection/word-granularity.html [ Failure ]
@@ -1509,7 +1505,6 @@ crbug.com/591099 fast/css-generated-content/float-first-letter-siblings-convert-
 crbug.com/714962 fast/css-generated-content/hover-inline.html [ Failure ]
 crbug.com/591099 fast/css-generated-content/table-before-after-child-add.html [ Failure ]
 crbug.com/591099 fast/css-generated-content/table-cell-before-after-child-add.html [ Failure ]
-crbug.com/591099 fast/css-generated-content/table-parts-before-and-after.html [ Crash ]
 crbug.com/591099 fast/css-generated-content/table-row-before-after-child-add.html [ Failure ]
 crbug.com/591099 fast/css-generated-content/table-row-group-to-inline.html [ Failure ]
 crbug.com/591099 fast/css-generated-content/table-row-group-with-before.html [ Failure ]
@@ -1638,7 +1633,6 @@ crbug.com/591099 fast/css/absolute-child-with-percent-height-inside-relative-par
 crbug.com/591099 fast/css/absolute-inline-alignment-2.html [ Pass ]
 crbug.com/714962 fast/css/absolute-inline-alignment.html [ Failure ]
 crbug.com/591099 fast/css/background-image-with-baseurl.html [ Failure Pass ]
-crbug.com/714962 fast/css/border-current-color.html [ Failure ]
 crbug.com/591099 fast/css/case-transform.html [ Failure ]
 crbug.com/591099 fast/css/color-correction-on-backgrounds.html [ Failure ]
 crbug.com/591099 fast/css/containment/size-and-layout-containment.html [ Failure ]
@@ -1649,7 +1643,6 @@ crbug.com/591099 fast/css/first-child-pseudo-class.html [ Failure ]
 crbug.com/714962 fast/css/first-letter-before-hit-test.html [ Failure ]
 crbug.com/714962 fast/css/first-letter-hit-test.html [ Failure ]
 crbug.com/714962 fast/css/first-letter-hover-hit-test.html [ Failure ]
-crbug.com/591099 fast/css/first-letter-hover.html [ Failure ]
 crbug.com/714962 fast/css/first-letter-range-insert.html [ Failure ]
 crbug.com/714962 fast/css/first-line-change-color-direct.html [ Failure ]
 crbug.com/714962 fast/css/first-line-change-color.html [ Failure ]
@@ -1666,7 +1659,6 @@ crbug.com/591099 fast/css/getComputedStyle/getComputedStyle-margin-percentage.ht
 crbug.com/591099 fast/css/getComputedStyle/getComputedStyle-resolved-values.html [ Timeout ]
 crbug.com/714962 fast/css/getComputedStyle/getComputedStyle-zoom-and-background-size.html [ Failure ]
 crbug.com/714962 fast/css/hover-pseudo-element-quirks.html [ Failure ]
-crbug.com/591099 fast/css/hover-subselector.html [ Failure ]
 crbug.com/591099 fast/css/ignore-empty-focus-ring-rects.html [ Failure ]
 crbug.com/591099 fast/css/import_with_baseurl.html [ Failure ]
 crbug.com/591099 fast/css/large-numbers.html [ Timeout ]
@@ -1699,11 +1691,9 @@ crbug.com/591099 fast/css/text-overflow-ellipsis.html [ Failure ]
 crbug.com/714962 fast/css/user-drag-none.html [ Pass ]
 crbug.com/591099 fast/css/vertical-align-lengths.html [ Failure ]
 crbug.com/591099 fast/css/word-space-extra.html [ Failure ]
-crbug.com/714962 fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-style.html [ Failure ]
 crbug.com/591099 fast/css3-text/css3-text-decoration/text-decoration-skip-ink.html [ Failure ]
 crbug.com/591099 fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto.html [ Failure ]
 crbug.com/591099 fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-cjk.html [ Failure ]
-crbug.com/714962 fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-dynamic.html [ Failure ]
 crbug.com/714962 fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-subscript.html [ Failure ]
 crbug.com/714962 fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-vertical.html [ Failure ]
 crbug.com/591099 fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under.html [ Failure ]
@@ -1735,7 +1725,6 @@ crbug.com/714962 fast/dom/Range/getBoundingClientRect-linebreak-character.html [
 crbug.com/714962 fast/dom/Range/getBoundingClientRect.html [ Failure ]
 crbug.com/714962 fast/dom/Range/getClientRects-character.html [ Failure ]
 crbug.com/591099 fast/dom/Range/getClientRects-leading-trailing-whitespaces.html [ Failure ]
-crbug.com/591099 fast/dom/Range/range-expand.html [ Failure ]
 crbug.com/591099 fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html [ Timeout ]
 crbug.com/591099 fast/dom/Window/window-lookup-precedence.html [ Timeout ]
 crbug.com/591099 fast/dom/Window/window-postmessage-clone-deep-array.html [ Failure ]
@@ -1788,7 +1777,6 @@ crbug.com/591099 fast/events/pointerevents/touch-capture.html [ Timeout ]
 crbug.com/714962 fast/events/pointerevents/touch-pointer-events.html [ Pass ]
 crbug.com/591099 fast/events/scale-and-scroll-iframe-window.html [ Pass ]
 crbug.com/591099 fast/events/select-element.html [ Timeout ]
-crbug.com/591099 fast/events/selectstart-by-double-triple-clicks.html [ Failure ]
 crbug.com/591099 fast/events/sequential-focus-navigation-starting-point.html [ Failure ]
 crbug.com/591099 fast/events/touch/compositor-touch-hit-rects-scroll.html [ Failure ]
 crbug.com/591099 fast/events/touch/compositor-touch-hit-rects.html [ Failure ]
@@ -1823,17 +1811,6 @@ crbug.com/591099 fast/forms/select/select-style.html [ Failure ]
 crbug.com/591099 fast/forms/selection-direction.html [ Timeout ]
 crbug.com/591099 fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom125.html [ Failure ]
 crbug.com/591099 fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom200.html [ Failure ]
-crbug.com/714962 fast/forms/suggestion-picker/date-suggestion-picker-appearance.html [ Failure ]
-crbug.com/714962 fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew.html [ Failure ]
-crbug.com/714962 fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl.html [ Failure ]
-crbug.com/714962 fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar.html [ Failure ]
-crbug.com/714962 fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance.html [ Failure ]
-crbug.com/714962 fast/forms/suggestion-picker/month-suggestion-picker-appearance.html [ Failure ]
-crbug.com/591099 fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew.html [ Failure ]
-crbug.com/714962 fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl.html [ Failure ]
-crbug.com/714962 fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar.html [ Failure ]
-crbug.com/714962 fast/forms/suggestion-picker/time-suggestion-picker-appearance.html [ Failure ]
-crbug.com/714962 fast/forms/suggestion-picker/week-suggestion-picker-appearance.html [ Failure ]
 crbug.com/591099 fast/forms/text-control-intrinsic-widths.html [ Timeout ]
 crbug.com/591099 fast/forms/textarea/textarea-align.html [ Failure ]
 crbug.com/591099 fast/forms/textarea/textarea-metrics.html [ Timeout ]
@@ -1849,12 +1826,7 @@ crbug.com/591099 fast/gradients/unprefixed-list-item-gradient.html [ Failure ]
 crbug.com/591099 fast/hidpi/broken-image-icon-hidpi.html [ Failure ]
 crbug.com/591099 fast/hidpi/image-set-list-style-image.html [ Failure ]
 crbug.com/591099 fast/hidpi/image-set-shape-outside.html [ Failure ]
-crbug.com/714962 fast/history/visited-link-hover-emphasis-color.html [ Failure ]
 crbug.com/591099 fast/history/visited-link-hover-outline-color.html [ Failure ]
-crbug.com/714962 fast/history/visited-link-hover-text-decoration-color.html [ Failure ]
-crbug.com/714962 fast/history/visited-link-hover-text-fill-color.html [ Failure ]
-crbug.com/714962 fast/history/visited-link-hover-text-stroke-color.html [ Failure ]
-crbug.com/714962 fast/history/visited-link-hover.html [ Failure ]
 crbug.com/714962 fast/html/layout-runs-and-floats-crash.html [ Failure ]
 crbug.com/591099 fast/inline-block/baseline-vertical.html [ Failure ]
 crbug.com/591099 fast/inline-block/contenteditable-baseline.html [ Failure ]
@@ -2620,7 +2592,6 @@ crbug.com/714962 fast/text/glyph-reordering.html [ Failure ]
 crbug.com/591099 fast/text/hide-atomic-inlines-after-ellipsis.html [ Failure ]
 crbug.com/591099 fast/text/international/bidi-linebreak-002.html [ Failure ]
 crbug.com/591099 fast/text/international/bidi-linebreak-003.html [ Failure ]
-crbug.com/714962 fast/text/international/cjk-segmentation.html [ Failure ]
 crbug.com/591099 fast/text/international/combining-marks-position.html [ Failure ]
 crbug.com/714962 fast/text/international/hindi-whitespace.html [ Failure ]
 crbug.com/714962 fast/text/international/iso-8859-8.html [ Failure ]
@@ -2662,7 +2633,6 @@ crbug.com/591099 fast/text/place-rtl-ellipsis-in-inline-blocks.html [ Failure ]
 crbug.com/714962 fast/text/selection/flexbox-selection-nested.html [ Failure ]
 crbug.com/591099 fast/text/selection/flexbox-selection.html [ Failure ]
 crbug.com/591099 fast/text/selection/khmer-selection.html [ Failure ]
-crbug.com/591099 fast/text/selection/offsetForPosition-complex-fallback.html [ Failure ]
 crbug.com/714962 fast/text/selection/pre-wrap-overflow-selection.html [ Failure ]
 crbug.com/591099 fast/text/selection/selection-hard-linebreak.html [ Failure ]
 crbug.com/591099 fast/text/selection/selection-rect-rounding.html [ Failure ]
@@ -2935,7 +2905,6 @@ crbug.com/714962 images/color-profile-background-clip-text.html [ Failure ]
 crbug.com/591099 images/color-profile-image-filter-all.html [ Failure ]
 crbug.com/591099 images/color-profile-image-shape.html [ Failure ]
 crbug.com/591099 images/color-profile-munsell-adobe-to-srgb.html [ Failure ]
-crbug.com/591099 images/image-hover-display-alt.html [ Failure ]
 crbug.com/591099 images/missing-image-border-zoom.html [ Failure ]
 crbug.com/591099 images/percent-height-image.html [ Failure ]
 crbug.com/591099 images/png-suite/test.html [ Failure ]
@@ -3260,7 +3229,6 @@ crbug.com/591099 paint/invalidation/table/cached-change-tbody-border-width.html
 crbug.com/591099 paint/invalidation/table/caret-contenteditable-content-after.html [ Failure ]
 crbug.com/591099 paint/invalidation/table/collapsed-border-cell-resize.html [ Failure ]
 crbug.com/591099 paint/invalidation/table/collapsed-border-change-rowspan.html [ Failure ]
-crbug.com/591099 paint/invalidation/table/collapsed-border-current-color.html [ Crash ]
 crbug.com/591099 paint/invalidation/table/composited-table-background-col-initial-empty.html [ Failure ]
 crbug.com/591099 paint/invalidation/table/composited-table-background-col-span-initial-empty.html [ Failure ]
 crbug.com/591099 paint/invalidation/table/composited-table-background-col-span.html [ Failure ]
@@ -3292,7 +3260,6 @@ crbug.com/591099 paint/invalidation/table/table-section-repaint.html [ Failure ]
 crbug.com/591099 paint/invalidation/table/table-shrink-row-repaint.html [ Failure ]
 crbug.com/591099 paint/invalidation/table/table-two-pass-layout-overpaint.html [ Failure ]
 crbug.com/591099 paint/invalidation/text-append-dirty-lines.html [ Failure ]
-crbug.com/714962 paint/invalidation/text-decoration-invalidation.html [ Failure ]
 crbug.com/591099 paint/invalidation/text-emphasis-h.html [ Failure ]
 crbug.com/591099 paint/invalidation/text-emphasis-v.html [ Failure ]
 crbug.com/591099 paint/invalidation/text-match-document-change.html [ Failure ]
@@ -3464,8 +3431,6 @@ crbug.com/591099 svg/transforms/text-with-pattern-inside-transformed-html.xhtml
 crbug.com/591099 svg/transforms/transformed-text-fill-pattern.html [ Failure ]
 crbug.com/591099 svg/wicd/test-scalable-background-image1.xhtml [ Failure ]
 crbug.com/591099 svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm [ Failure ]
-crbug.com/591099 tables/layering/paint-test-layering-1.html [ Failure ]
-crbug.com/591099 tables/layering/paint-test-layering-2.html [ Failure ]
 crbug.com/591099 tables/mozilla/bugs/bug101674.html [ Failure ]
 crbug.com/591099 tables/mozilla/bugs/bug110566.html [ Failure ]
 crbug.com/714962 tables/mozilla/bugs/bug11384q.html [ Failure ]
@@ -3542,7 +3507,6 @@ crbug.com/591099 tables/mozilla_expected_failures/marvin/table_overflow_caption_
 crbug.com/591099 tables/mozilla_expected_failures/marvin/table_overflow_caption_top.html [ Failure ]
 crbug.com/714962 touchadjustment/context-menu-select-text.html [ Failure ]
 crbug.com/714962 touchadjustment/context-menu-text-subtargets.html [ Failure ]
-crbug.com/714962 touchadjustment/touch-links-longpress.html [ Failure ]
 crbug.com/591099 transforms/2d/compound-transforms-vs-containers.html [ Failure ]
 crbug.com/591099 transforms/2d/hindi-rotated.html [ Failure ]
 crbug.com/591099 transforms/2d/transform-2d.html [ Timeout ]

third_party/WebKit/Source/core/layout/LayoutText.cpp

@@ -306,12 +306,25 @@ void LayoutText::DeleteTextBoxes() {
 
 Optional<FloatPoint> LayoutText::GetUpperLeftCorner() const {
   DCHECK(!IsBR());
-  if (!HasTextBoxes())
+  // TODO(layoutng) Implement GetUpperLeftCorner for layoutng
+  if (!HasLegacyTextBoxes())
     return WTF::nullopt;
   return FloatPoint(LinesBoundingBox().X(),
                     FirstTextBox()->Root().LineTop().ToFloat());
 }
 
+bool LayoutText::HasTextBoxes() const {
+  if (RuntimeEnabledFeatures::LayoutNGEnabled()) {
+    auto fragments = NGPaintFragment::InlineFragmentsFor(this);
+    if (fragments.IsInLayoutNGInlineFormattingContext())
+      return !(fragments.begin() == fragments.end());
+    // When legacy is forced, IsInLayoutNGInlineFormattingContext is false,
+    // and we fall back to normal HasTextBox
+    return FirstTextBox();
+  }
+  return FirstTextBox();
+}
+
 scoped_refptr<StringImpl> LayoutText::OriginalText() const {
   Node* e = GetNode();
   return (e && e->IsTextNode()) ? ToText(e)->DataImpl() : nullptr;
@@ -2298,7 +2311,7 @@ LayoutRect LayoutText::DebugRect() const {
       LayoutRect(IntRect(first_run_offset.X(), first_run_offset.Y(),
                          lines_box.Width(), lines_box.Height()));
   LayoutBlock* block = ContainingBlock();
-  if (block && HasTextBoxes())
+  if (block && HasLegacyTextBoxes())
     block->AdjustChildDebugRect(rect);
 
   return rect;

third_party/WebKit/Source/core/layout/LayoutText.h

@@ -204,7 +204,11 @@ class CORE_EXPORT LayoutText : public LayoutObject {
 
   // True if we have inline text box children which implies rendered text (or
   // whitespace) output.
-  bool HasTextBoxes() const { return FirstTextBox(); }
+  bool HasTextBoxes() const;
+
+  // TODO(layoutng) Legacy-only implementation of HasTextBoxes.
+  // All callers should call HasTextBoxes instead, and take NG into account.
+  bool HasLegacyTextBoxes() const { return FirstTextBox(); }
 
   // Returns the Position in DOM that corresponds to the given offset in the
   // |text_| string.