Commit b2a3d143 authored by vitaliii's avatar vitaliii Committed by Commit Bot

[Sheriff] Disable 3 SSLErrorHandlerDateInvalidTest on Linux TSAN (flaky).

Disable
 SSLErrorHandlerDateInvalidTest.TimeQueryHangs
 SSLErrorHandlerDateInvalidTest.NoTimeQueries
 SSLErrorHandlerDateInvalidTest.TimeQueryStarted
on Linux TSAN because flaky.

TBR=agl@chromium.org

Bug: 989289, 989225, 989128
Change-Id: I23df095539a5f0eaf5a3070ccea35067998e981b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728554Reviewed-by: default avatarvitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682677}
parent 2269150b
......@@ -1058,6 +1058,12 @@ TEST_F(SSLErrorHandlerNameMismatchTest,
SSLErrorHandler::SHOW_SSL_INTERSTITIAL_OVERRIDABLE, 1);
}
// Flakily fails on linux_chromium_tsan_rel_ng. http://crbug.com/989128
#if defined(OS_LINUX) && defined(THREAD_SANITIZER)
#define MAYBE_TimeQueryStarted DISABLED_TimeQueryStarted
#else
#define MAYBE_TimeQueryStarted TimeQueryStarted
#endif
TEST_F(SSLErrorHandlerDateInvalidTest, TimeQueryStarted) {
base::HistogramTester histograms;
base::Time network_time;
......@@ -1089,6 +1095,13 @@ TEST_F(SSLErrorHandlerDateInvalidTest, TimeQueryStarted) {
// Tests that an SSL interstitial is shown if the accuracy of the system
// clock can't be determined because network time is unavailable.
// Flakily fails on linux_chromium_tsan_rel_ng. http://crbug.com/989225
#if defined(OS_LINUX) && defined(THREAD_SANITIZER)
#define MAYBE_NoTimeQueries DISABLED_NoTimeQueries
#else
#define MAYBE_NoTimeQueries NoTimeQueries
#endif
TEST_F(SSLErrorHandlerDateInvalidTest, NoTimeQueries) {
base::HistogramTester histograms;
base::Time network_time;
......@@ -1109,7 +1122,14 @@ TEST_F(SSLErrorHandlerDateInvalidTest, NoTimeQueries) {
// Tests that an SSL interstitial is shown if determing the accuracy of
// the system clock times out (e.g. because a network time query hangs).
TEST_F(SSLErrorHandlerDateInvalidTest, TimeQueryHangs) {
// Flakily fails on linux_chromium_tsan_rel_ng. http://crbug.com/989289
#if defined(OS_LINUX) && defined(THREAD_SANITIZER)
#define MAYBE_TimeQueryHangs DISABLED_TimeQueryHangs
#else
#define MAYBE_TimeQueryHangs TimeQueryHangs
#endif
TEST_F(SSLErrorHandlerDateInvalidTest, MAYBE_TimeQueryHangs) {
base::HistogramTester histograms;
base::Time network_time;
base::TimeDelta uncertainty;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment