Commit b2f288ae authored by David Maunder's avatar David Maunder Committed by Chromium LUCI CQ

Batch TabModelSelectorTabModelObserverTest

Speedup: 4500ms -> 1810ms (61% improvement)

Bug: 1166382
Change-Id: I75839a35b02373bf31235c05aef3cc2bd2b6c74f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628314Reviewed-by: default avatarMichael Thiessen <mthiesse@chromium.org>
Reviewed-by: default avatarWei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843554}
parent 7d29603f
...@@ -8,12 +8,13 @@ import androidx.test.filters.SmallTest; ...@@ -8,12 +8,13 @@ import androidx.test.filters.SmallTest;
import org.junit.Assert; import org.junit.Assert;
import org.junit.Before; import org.junit.Before;
import org.junit.Rule; import org.junit.ClassRule;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.chromium.base.test.BaseJUnit4ClassRunner; import org.chromium.base.test.BaseJUnit4ClassRunner;
import org.chromium.base.test.UiThreadTest; import org.chromium.base.test.UiThreadTest;
import org.chromium.base.test.util.Batch;
import org.chromium.base.test.util.CallbackHelper; import org.chromium.base.test.util.CallbackHelper;
import org.chromium.chrome.browser.tab.Tab; import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tab.TabLaunchType; import org.chromium.chrome.browser.tab.TabLaunchType;
...@@ -28,16 +29,17 @@ import java.util.concurrent.TimeoutException; ...@@ -28,16 +29,17 @@ import java.util.concurrent.TimeoutException;
* Tests for the TabModelSelectorTabModelObserver. * Tests for the TabModelSelectorTabModelObserver.
*/ */
@RunWith(BaseJUnit4ClassRunner.class) @RunWith(BaseJUnit4ClassRunner.class)
@Batch(Batch.PER_CLASS)
public class TabModelSelectorTabModelObserverTest { public class TabModelSelectorTabModelObserverTest {
@Rule @ClassRule
public final TabModelSelectorObserverTestRule mTestRule = public static final TabModelSelectorObserverTestRule sTestRule =
new TabModelSelectorObserverTestRule(); new TabModelSelectorObserverTestRule();
private TabModelSelectorBase mSelector; private TabModelSelectorBase mSelector;
@Before @Before
public void setUp() { public void setUp() {
mSelector = mTestRule.getSelector(); mSelector = sTestRule.getSelector();
} }
@Test @Test
...@@ -75,7 +77,7 @@ public class TabModelSelectorTabModelObserverTest { ...@@ -75,7 +77,7 @@ public class TabModelSelectorTabModelObserverTest {
registrationCompleteCallback.notifyCalled(); registrationCompleteCallback.notifyCalled();
} }
}; };
mSelector.initialize(mTestRule.getNormalTabModel(), mTestRule.getIncognitoTabModel()); mSelector.initialize(sTestRule.getNormalTabModel(), sTestRule.getIncognitoTabModel());
registrationCompleteCallback.waitForCallback(0); registrationCompleteCallback.waitForCallback(0);
assertAllModelsHaveObserver(mSelector, observer); assertAllModelsHaveObserver(mSelector, observer);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment