Commit b2feeb92 authored by kevino@webkit.org's avatar kevino@webkit.org

[wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation

implements pthread_t in a way that makes it impossible to check its validity,
which is needed by ThreadingPthreads.cpp.


git-svn-id: svn://svn.chromium.org/blink/trunk@54043 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 8ea41dae
2010-01-28 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation
implements pthread_t in a way that makes it impossible to check its validity,
which is needed by ThreadingPthreads.cpp.
* wscript:
2010-01-28 Oliver Hunt <oliver@apple.com> 2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough. Reviewed by Gavin Barraclough.
......
...@@ -34,13 +34,14 @@ jscore_excludes.extend(get_excludes(jscore_dir, ['*CF.cpp', '*Symbian.cpp'])) ...@@ -34,13 +34,14 @@ jscore_excludes.extend(get_excludes(jscore_dir, ['*CF.cpp', '*Symbian.cpp']))
sources = [] sources = []
jscore_excludes.extend(get_excludes(jscore_dir, ['*Win.cpp', '*None.cpp'])) jscore_excludes.extend(get_excludes(jscore_dir, ['*None.cpp']))
if building_on_win32: if building_on_win32:
jscore_excludes += ['ExecutableAllocatorPosix.cpp', 'MarkStackPosix.cpp'] jscore_excludes += ['ExecutableAllocatorPosix.cpp', 'MarkStackPosix.cpp', 'ThreadingPthreads.cpp']
sources += ['jit/ExecutableAllocatorWin.cpp', 'runtime/MarkStackWin.cpp'] sources += ['jit/ExecutableAllocatorWin.cpp', 'runtime/MarkStackWin.cpp']
else: else:
jscore_excludes.append('JSStringRefBSTR.cpp') jscore_excludes.append('JSStringRefBSTR.cpp')
jscore_excludes.extend(get_excludes(jscore_dir, ['*Win.cpp']))
def generate_jscore_derived_sources(): def generate_jscore_derived_sources():
# build the derived sources # build the derived sources
......
2010-01-28 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation
implements pthread_t in a way that makes it impossible to check its validity,
which is needed by ThreadingPthreads.cpp.
* DumpRenderTree/wscript:
* wx/build/settings.py:
2010-01-28 Andras Becsi <abecsi@webkit.org> 2010-01-28 Andras Becsi <abecsi@webkit.org>
Adding myself to the committer list. No review needed. Adding myself to the committer list. No review needed.
......
...@@ -57,7 +57,7 @@ def build(bld): ...@@ -57,7 +57,7 @@ def build(bld):
includes = ' '.join(include_paths), includes = ' '.join(include_paths),
source = sources, source = sources,
target = 'DumpRenderTree', target = 'DumpRenderTree',
uselib = 'WXWEBKIT WX ' + get_config(), uselib = 'JSCORE ICU WXWEBKIT WX ' + get_config(),
libpath = [output_dir], libpath = [output_dir],
uselib_local = '', uselib_local = '',
install_path = output_dir) install_path = output_dir)
......
...@@ -74,7 +74,7 @@ ports = [ ...@@ -74,7 +74,7 @@ ports = [
] ]
port_uses = { port_uses = {
'wx': ['CURL','PTHREADS', 'WXGC'], 'wx': ['CURL', 'WXGC'],
} }
jscore_dirs = [ jscore_dirs = [
...@@ -256,9 +256,6 @@ def common_configure(conf): ...@@ -256,9 +256,6 @@ def common_configure(conf):
# This one also occurs in C code, so disable it there as well. # This one also occurs in C code, so disable it there as well.
conf.env.append_value('CCFLAGS', ['/wd4996']) conf.env.append_value('CCFLAGS', ['/wd4996'])
for use in port_uses[build_port]:
conf.env.append_value('CXXDEFINES', ['WTF_USE_%s' % use])
if build_port == "wx": if build_port == "wx":
update_wx_deps(conf, wk_root, msvc_version) update_wx_deps(conf, wk_root, msvc_version)
...@@ -355,6 +352,7 @@ def common_configure(conf): ...@@ -355,6 +352,7 @@ def common_configure(conf):
conf.env['LIB_XSLT'] = ['libxslt'] conf.env['LIB_XSLT'] = ['libxslt']
else: else:
if build_port == 'wx': if build_port == 'wx':
port_uses['wx'].append('PTHREADS')
conf.env.append_value('LIB', ['jpeg', 'png', 'pthread']) conf.env.append_value('LIB', ['jpeg', 'png', 'pthread'])
conf.env.append_value('LIBPATH', os.path.join(wklibs_dir, 'unix', 'lib')) conf.env.append_value('LIBPATH', os.path.join(wklibs_dir, 'unix', 'lib'))
conf.env.append_value('CPPPATH', os.path.join(wklibs_dir, 'unix', 'include')) conf.env.append_value('CPPPATH', os.path.join(wklibs_dir, 'unix', 'include'))
...@@ -375,3 +373,6 @@ def common_configure(conf): ...@@ -375,3 +373,6 @@ def common_configure(conf):
conf.check_cfg(package='gtk+-2.0', args='--cflags --libs', uselib_store='WX', mandatory=True) conf.check_cfg(package='gtk+-2.0', args='--cflags --libs', uselib_store='WX', mandatory=True)
conf.check_cfg(package='sqlite3', args='--cflags --libs', uselib_store='SQLITE3', mandatory=True) conf.check_cfg(package='sqlite3', args='--cflags --libs', uselib_store='SQLITE3', mandatory=True)
conf.check_cfg(path='icu-config', args='--cflags --ldflags', package='', uselib_store='ICU', mandatory=True) conf.check_cfg(path='icu-config', args='--cflags --ldflags', package='', uselib_store='ICU', mandatory=True)
for use in port_uses[build_port]:
conf.env.append_value('CXXDEFINES', ['WTF_USE_%s' % use])
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment