Commit b4f1a520 authored by Findit's avatar Findit

Revert "CrOS Shelf: add background over app list"

This reverts commit 468ce86a.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 587137 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQ2OGNlODZhMDEwY2U4MzEzZTZiOTJhNGZmYjhhNGEzODYxODkzNDIM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28784

Sample Failed Step: ash_unittests

Original change's description:
> CrOS Shelf: add background over app list
> 
> Currently the shelf is fully transparent when the app
> list is open. In thr new UI, we want to make it slightly
> darker to distinguish it from the app list.
> 
> Bug: 878601
> Change-Id: I5167e684e174c2d48334f45fa9b1c66e79ba32b7
> Reviewed-on: https://chromium-review.googlesource.com/1194067
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Manu Cornet <manucornet@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587137}

Change-Id: I92133a3f12ad29bd54f2d20f8f1bba53b7d1762a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 878601
Reviewed-on: https://chromium-review.googlesource.com/1196027
Cr-Commit-Position: refs/heads/master@{#587354}
parent 2553594a
...@@ -84,11 +84,7 @@ std::pair<int, int> GetTargetColorAlphaValues( ...@@ -84,11 +84,7 @@ std::pair<int, int> GetTargetColorAlphaValues(
target_item_color_alpha = SK_AlphaTRANSPARENT; target_item_color_alpha = SK_AlphaTRANSPARENT;
break; break;
case SHELF_BACKGROUND_APP_LIST: case SHELF_BACKGROUND_APP_LIST:
if (chromeos::switches::ShouldUseShelfNewUi()) { target_shelf_color_alpha = SK_AlphaTRANSPARENT;
target_shelf_color_alpha = kShelfTranslucentOverAppList;
} else {
target_shelf_color_alpha = SK_AlphaTRANSPARENT;
}
target_item_color_alpha = SK_AlphaTRANSPARENT; target_item_color_alpha = SK_AlphaTRANSPARENT;
break; break;
case SHELF_BACKGROUND_SPLIT_VIEW: case SHELF_BACKGROUND_SPLIT_VIEW:
......
...@@ -65,7 +65,6 @@ constexpr float kShelfInkDropVisibleOpacity = 0.2f; ...@@ -65,7 +65,6 @@ constexpr float kShelfInkDropVisibleOpacity = 0.2f;
ASH_EXPORT constexpr SkColor kShelfIconColor = SK_ColorWHITE; ASH_EXPORT constexpr SkColor kShelfIconColor = SK_ColorWHITE;
// The alpha value for the shelf background. // The alpha value for the shelf background.
ASH_EXPORT constexpr int kShelfTranslucentOverAppList = 77; // 30%
ASH_EXPORT constexpr int kShelfTranslucentAlpha = 153; // 60% ASH_EXPORT constexpr int kShelfTranslucentAlpha = 153; // 60%
ASH_EXPORT constexpr int kShelfTranslucentMaximizedWindowNewUi = 230; // 90% ASH_EXPORT constexpr int kShelfTranslucentMaximizedWindowNewUi = 230; // 90%
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment