Commit b567f934 authored by Sahel Sharify's avatar Sahel Sharify Committed by Commit Bot

Trace delta of GSUs in InputHandlerProxy::HandleGestureScrollUpdate.

This cl records the deltas of GSU events arrived to the renderer.
The trace helps with debugging cases that scroll events are unexpectedly
ignored.

Bug: 797708
Change-Id: I855caa42a0751e63df540f95e4345720f16befb1
Reviewed-on: https://chromium-review.googlesource.com/894179Reviewed-by: default avatarDave Tapuska <dtapuska@chromium.org>
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534426}
parent 880762a9
...@@ -737,6 +737,12 @@ InputHandlerProxy::HandleGestureScrollUpdate( ...@@ -737,6 +737,12 @@ InputHandlerProxy::HandleGestureScrollUpdate(
DCHECK(expect_scroll_update_end_); DCHECK(expect_scroll_update_end_);
#endif #endif
gfx::Vector2dF scroll_delta(-gesture_event.data.scroll_update.delta_x,
-gesture_event.data.scroll_update.delta_y);
TRACE_EVENT_INSTANT2("input", "InputHandlerProxy::HandleGestureScrollUpdate",
TRACE_EVENT_SCOPE_THREAD, "dx", scroll_delta.x(), "dy",
scroll_delta.y());
if (scroll_sequence_ignored_) if (scroll_sequence_ignored_)
return DROP_EVENT; return DROP_EVENT;
...@@ -745,8 +751,6 @@ InputHandlerProxy::HandleGestureScrollUpdate( ...@@ -745,8 +751,6 @@ InputHandlerProxy::HandleGestureScrollUpdate(
cc::ScrollState scroll_state = CreateScrollStateForGesture(gesture_event); cc::ScrollState scroll_state = CreateScrollStateForGesture(gesture_event);
gfx::Point scroll_point(gesture_event.x, gesture_event.y); gfx::Point scroll_point(gesture_event.x, gesture_event.y);
gfx::Vector2dF scroll_delta(-gesture_event.data.scroll_update.delta_x,
-gesture_event.data.scroll_update.delta_y);
if (ShouldAnimate(gesture_event.data.scroll_update.delta_units != if (ShouldAnimate(gesture_event.data.scroll_update.delta_units !=
blink::WebGestureEvent::ScrollUnits::kPixels)) { blink::WebGestureEvent::ScrollUnits::kPixels)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment