Commit b64c1dee authored by Bo Liu's avatar Bo Liu Committed by Commit Bot

android: Reset input connection on detach

BaseInputConnection will keep a reference to the container view, which
causes leaks after onDetachedFromWindow.

Bug: 1149336
Change-Id: Iee7683092ea6f8878a09de78a09d044d8d29d246
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536785
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Reviewed-by: default avatarChangwan Ryu <changwan@chromium.org>
Auto-Submit: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827959}
parent 7e6d5a9e
...@@ -310,5 +310,6 @@ public class ThreadedInputConnectionFactory implements ChromiumBaseInputConnecti ...@@ -310,5 +310,6 @@ public class ThreadedInputConnectionFactory implements ChromiumBaseInputConnecti
if (DEBUG_LOGS) Log.d(TAG, "onViewDetachedFromWindow"); if (DEBUG_LOGS) Log.d(TAG, "onViewDetachedFromWindow");
if (mCheckInvalidator != null) mCheckInvalidator.invalidate(); if (mCheckInvalidator != null) mCheckInvalidator.invalidate();
if (mProxyView != null) mProxyView.onOriginalViewDetachedFromWindow(); if (mProxyView != null) mProxyView.onOriginalViewDetachedFromWindow();
mThreadedInputConnection = null;
} }
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment